Closed (fixed)
Project:
Upgrade Status
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Jan 2022 at 18:32 UTC
Updated:
11 Feb 2022 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tmaiochi commentedWorking on it.
Comment #3
tmaiochi commentedI fix all PHPCS messages in info files. There are other PHPCS errors and warnings that will be fixed in other issues.
Comment #4
victoria-marina commentedI'll review it
Comment #5
victoria-marina commentedAll the errors from .info files, were fixed after the #3. It's a RTBC for me.
Comment #6
gábor hojtsyThanks, sent for automated tests. I don't think the
projectkeys still have any significance, they used to have some, but for a while we exempt the test modules from project collation to be able to test them individually, so the project key should not make a difference.Let's see what will the tests say.
Comment #7
gábor hojtsyAll failed, right :D So for mock contributed projects we detect them based on an explicit
projectkey which you removed, so now they are categorized under custom projects, but they should be identified as mock contrib projects. The project keys need to not be removed. You can add a comment above it to explain this is to identify the module as a mock contributed project.Comment #8
tmaiochi commentedI'll put back the
projectin info files.Comment #9
tmaiochi commentedI put all the
projectback in info filesComment #10
gábor hojtsyNow the fails show that the UI tests have various checks to find the modules appear and they include the "version number" that now you are removing, so those tests need to be changed.
Comment #11
tmaiochi commentedHey @Gábor Hojtsy I think that I identified the problem in test I just commented the lines, because I have no experience working with tests. So I think you need to open a new issue to do this or ask for someone else resolve this here.
Comment #12
gábor hojtsyI think removing the version numbers would still match them properly, even if those would be slightly less specific, this would only be a real problem if the module names would somehow be substrings of each other which I don't think is the case for either of them. Let's try this.
Comment #14
gábor hojtsyLanded this with slightly modified comment in the info file, thanks both!