Fix missing dependency injections

I'll review it.

@tmaiochi as the class UpgradeStatusCommands is a service, it needs to have the new injected dependency as an argument on the .services file.

Hello, I reviewed and found that on file UpgradeStatusForm.php, because of the injection of the dependency of users Roles, the use statement of Roles is no longer used, so we have a new phpcs error for unused use statement.

Besides that, everything looks good and the module is working as far as I can test it.

Thank you!

With that patch, the dependency injections were fixed, no new errors were added, everything looks good and the module is working as far as I can test it.
Moving to RTBC

Thanks, this looks good other than these two IMHO:

1. +++ b/src/Commands/UpgradeStatusCommands.php
   @@ -43,6 +44,13 @@ class UpgradeStatusCommands extends DrushCommands {
   +   * The key value.
   
   @@ -54,16 +62,20 @@ class UpgradeStatusCommands extends DrushCommands {
   +   *   The key value.
   

   I would say this is "The key-value storage" or somesuch. What is the comment for such properties elsewhere in this module or core?

2. +++ b/src/Form/UpgradeStatusForm.php
   @@ -120,6 +122,27 @@ class UpgradeStatusForm extends FormBase {
   +   * The users permission.
   

   Is this the current user's permissions? That would be clearer.

Also as the drush command does not have automated test coverage, did you manually test that it still works?

"The key value." was changed to "Defines the key/value store factory interface."
which I agree is better explained.

For some reason, the User permission is not showing on the interdiff? but was changed to "Defines an interface to list available permissions."

I tested in the interface, but now I also tested the dush command for checkstyle.
Thank you for the reminder!

Sorry for not integrating this when it was done. Unfortunately definitely does not apply anymore. Also 3.x is not supported anymore.

Drush commans now have some automated test coverage so that will not need to be manually tested.

I did add all credits to #3459216: Fix all phpcs issues though, so your efforts are not uncredited. Thanks all!