Problem/Motivation

Hello,

I just saw that https://www.drupal.org/project/facets 8.x-1.x has been marked as unsupported.

This module should be marked as compatible with 2.0.x branch.

CommentFileSizeAuthor
#4 facets-form-update-facets-module-3254498-4.patch628 bytessmulvih2

Issue fork facets_form-3254498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

proweb.ua’s picture

proweb.ua commented

composer.json

change
"drupal/facets": "^1.8"
to
"drupal/facets": "^2.0"

Aaron Gil Martinez made their first commit to this issue’s fork.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Active » Needs review
StatusFileSize
new facets-form-update-facets-module-3254498-4.patch628 bytes

I'm using this with drupal/facets 2.0.1 and it's working as expected. It would be good to also remove the drupal/facets patch since this is now included in the 2.0.x branch.

Status: Needs review » Needs work

The last submitted patch, 4: facets-form-update-facets-module-3254498-4.patch, failed testing. View results

escuriola made their first commit to this issue’s fork.

andras_szilagyi’s picture

andras_szilagyi commented
Related issues: +#3280015: Failing tests due to urlencode

This is blocked by #3280015

escuriola opened merge request !27

andras_szilagyi’s picture

andras_szilagyi commented
Status: Needs work » Fixed

merged, thank you all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.