Closed (fixed)
Project:
Facets Form
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 May 2022 at 22:06 UTC
Updated:
1 Jun 2022 at 10:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
donquixote commentedComment #3
donquixote commentedCode style fix.
Comment #6
donquixote commentedThe tests in facets module all use
Url::fromUserInput()to test facet urls.So I am doing the same here, but with a helper method for convenience.
One thing I am not sure about is IntegrationTest::assertCurrentUrl().
For some reason there is no complaining about url-encoded square brackets here.
Also the part after
$this->assertSession()->addressEquals($expected_url);seems weird: If query parts are in different order, wouldn't this already cause the previous assertion to fail?Comment #7
donquixote commentedSo the actual problem was this: #3164686: WebAssert::addressEquals() and AssertLegacyTrait::assertUrl() fail to check the querystring
With Drupal 9.2.*, the tests would pass because the query string was ignored in the assertions.
With Drupal 9.3.*, the tests fail because of urlencode, and because some of them actually had wrong expectations.
Comment #8
donquixote commentedComment #11
andras_szilagyi commentedmerged, thx