1️⃣ Is this the right thing? I'm not sure in terms of Svelte and our workflow what should be committed vs. not.#3245954: Modify .gitignore to exclude build files.

chrisfromredfin I feel like @Rajab Natshah might know the answer here, or even @Ron Northcutt or @grasmash.
gaurav.kapoor Looking for inputs as well. AFAIK build files should be ignored, would be interesting to see how it is being handled in other projects which provide JS code.
mandclu To me the down side of excluding build files is that it would make it harder for others to contribute without them. Maybe have a separate repo that includes them? (edited)
grasmash we’re committing them
grasmash other wise, our users would need to run npm to use project browser
grasmash that would not be good
Ron Northcutt Agreed. Perhaps we can work on something cleaner later. But, remember that the whole point of Svelte is to generate the JS you need for a project.

2️⃣ This is a good issue for people to look at if you are just wanting to dip your toes into making some basic changes to the Svelte components. I would recommend working in an issue fork! #3245948: Resolve issues shown when running the build process for Svelte app.

chrisfromredfin This mostly relates to small a11y concerns that the linter found, like an tag without an href, etc.
gaurav.kapoor +1, it's a novice thing, doesn't require a lot of Svelte knowledge also.

3️⃣ A note about MR's: we like MR's (issue forks) rather than patch workflow, but either is fine. But if you need help learning Gitlab / MR, we're here! It's easier than I thought.

irinaz Hi @chrisfromredfin,  I am talking with @timplunkett (he/him) now about using Gitlab for project browser
chrisfromredfin ok, cool! lmk what if anything you may need from me
timplunkett (he/him) Gitlab proper, not the D.o-Gitlab hybrid. As a means of helping push forward the efforts in #gitlab
timplunkett (he/him) Specifically https://drupal.slack.com/archives/CGKLP028K/p1635963036038500
irinaz @chrisfromredfin do you have time to zoom so we can talk about details of this project?
chrisfromredfin sure i've got some time!
chrisfromredfin @irinaz

4️⃣ A brief summary/update from yesterday's SBS meeting.

leslieg Chris and I met on Monday to discuss the roadmap for MVP and the later phases. We discussed the site builder/UX components of the proposed MVP items yesterday in the SBS threadsUpdated Figma design. Jillian updated the Figma for the Card view
leslieg Discussed which modules we’s start with for card sort and adding brief descriptions and logos - list of top 100 or list returned from current filters on recommended tab(edited)
leslieg Discussed list of categories for mvp - include all 54 or only those from the top 100 modules. Group thought latter(edited)
leslieg AmyJune volunteered to take on the issue of checking text on the download instructions for ease of understanding by site builder. issue /project_browser/issues/3247332
leslieg Discussion on allowing selection of multiple categories as filter - with ANDing being used. Agreed this is probably a useful thing for MVP
bsnodgrass (he/him) good summary
chrisfromredfin Many of these appear in the MVP roadmap (thread 5️⃣ I think)
bsnodgrass (he/him) follow up filtering the pulled data set in data studio, comparing the favorite modules list, and getting the card sorting going is probably next up. This will provide some insight into how to clean up categories and projects.
leslieg yes @chrisfromredfin - we discussed the SBS related items from the MVP roadmap. No one identified any items that were missing

5️⃣ I am about to file an issue that is Leslie's and my proposed "MVP Delineation," that is, what features we think belong in MVP and guide us toward a 1.0.0 release, and which will be incremental iterations coming later. I will update the thread when I get that posted.

chrisfromredfin OK here we are. I will update with things we thought were phase 2 now.
chrisfromredfin #3247441: [PLAN] What belongs inside and outside the MVP (1.0.0)
chrisfromredfin I think I will just give 2 weeks for feedback on this MVP, then it will become finalized, so we don't go on and on. ping / cc @Ron Northcutt as I feel like you'll probably have good input here.
bsnodgrass (he/him) I still feel like this one is pretty close, should we recap and look for final comments for the MVP in the same 2 weeks?
chrisfromredfin Not sure what you mean exactly.
mandclu One thing I'm not clear about from that issue: is the "Recommended" tab based on the top 100 modules, based on actual alignment with the site's Drupal version, or a combination?
chrisfromredfin It is, in fact, unclear. :slightly_smiling_face: But the way I think about it is that the "recommended" tab is whatever modules meet a certain criteria. I think one of those criteria is "Works with this site" but also things like "has security coverage" etc. We are NOT limiting the "recommended" tab to 100 modules, but are identifying 100 modules that is hopefully a small enough data set for us to attack to have good images and good short first paragraphs/sentences so when they show up in PB day one they look good
mandclu OK great, just wanted to make sure there wasn't some kind of implied connection between the top 100 modules and the recommended tab that I wasn't aware of
mandclu One other comment on that issue: "real search API keyword search" is listed under "UI implementation" which some might consider a tad misleading, if technically accurate
mandclu Maybe it would be better to have a section for "quality of recommendations" or similar

6️⃣ The topic of how we should integrate with autoupdates project came up yesterday at the SBS meeting. I thought that was a better discussion for this group today to take on

tim Down that path a technical question - are there some modules that need to be installed at the same time?
chrisfromredfin Yes, but composer does that for you (which is the nice part of it and adopting its use through the UI). If a module depends on another module, and you install module B, it will install the dependency (A) for you.
chrisfromredfin That issue is here and some piece of it has been committed: #3245770: Create a service to composer install via package_manager from Automatic Updates
bsnodgrass (he/him) We have confirmed this is an MVP item, and I question if it would be next phase. I think we need to be careful with perception of the appropriate use would be for Project Browser.Listening to @tedbow talk about automatic updates. It's fine for a one off updates on sites, but there is a big gap getting it to a "best practice" with sites that are supported with version control let alone a CI/CD process.
tim Long thread yesterday on how to do autoupdates in PB. Some things I didn't think about. What happens when u want to uninstall? Or u can not install because of conflict, but you don't know that at first.https://drupal.slack.com/archives/C7QJNEY3E/p1635873584110900?thread_ts=1635873584.110900&cid=C7QJNEY3E
bsnodgrass (he/him) Thanks for sharing that @tim (edited)
tedbow just FYI @phenaproxima are refactoring package_manager now.  moving code out of automatic_updates  into package_manager. after the refactor it should be easier to use package_manager as it will take care of more stuff for you. for example validating you have the correct version of composer installed and that your composer.lock file didn’t unexpectedly  change in the middle of an install(to prevent someone from doing conflicting composer changes from the command line at the same time)
timplunkett (he/him) Also, Ted and co. are planning to sprint on this as well, November 15-19th
tedbow so hopefully by the 15th package_manager major changes should be done so we just have to worry about how project_browser  will call it. but of course this may point out some weakness in the package_manager API. which is good to figure out now
tim Lets plan to run some test cases through (edited)
tim I will volunteer for that
bsnodgrass (he/him) It will be great stuff, but folding into managing active client projects and supporting them long term will be a challenge. Coming up with best recommended practice around tools is both exciting and a bit scary!

Participants:

chrisfromredfin, gaurav.kapoor, mandclu, grasmash, Ron Northcutt, irinaz, timplunkett (he/him), leslieg, bsnodgrass (he/him), tim, tedbow

Comments

chrisfromredfin created an issue. See original summary.

chrisfromredfin credited bsnodgrass.

chrisfromredfin credited gaurav.kapoor.

chrisfromredfin credited grasmash.

chrisfromredfin credited irinaz.

chrisfromredfin credited leslieg.

chrisfromredfin credited lets4.

chrisfromredfin credited mandclu.

chrisfromredfin credited rlnorthcutt.

chrisfromredfin credited tedbow.

chrisfromredfin credited tim.plunkett.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.