Closed (fixed)
Project:
Image Effects
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Oct 2021 at 11:13 UTC
Updated:
20 Nov 2021 at 16:54 UTC
Jump to comment: Most recent
Problem/Motivation
Image rotate features in core have some long-term unresolved issues, see #3240390: [policy, no patch] Move image rotation code from core into contrib.
Proposed resolution
Introduce 'Rotate' effect and operations for GD and Imagemagick in Image Effects, alternative to core's. Solve most of the open core issues in doing that. Plus, allow alpha channel in background color, and fallback color when full transparent background is not supported by the image format (e.g. JPEG).
Remaining tasks
limit pseudorandom rotationvalidate background color RGBAfallback opaque color for transparent, also gdadd tests- add a drush command to convert core's 'Rotate' effect in image styles to Image Effects' one
add test for random rotationadd test for pseudorandom rotation
User interface changes
API changes
Data model changes
Issue fork image_effects-3246867
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
mondrakeComment #4
mondrakeComment #5
mondrakeComment #6
mondrakeComment #7
mondrakeComment #8
mondrakeThis addresses some long time standing issues from Drupal's core queue:
I will leave to a follow-up development of a drush command to convert core's Rotate effects in image styles to the effect provided here.
I am thinking of deprecating the rotate toolkit operation in the ImageMagick module in favor of the one here. Whether core will follow, it's a matter of #3240390: [policy, no patch] Move image rotation code from core into contrib.
Comment #10
mondrakeCommitted.