Problem/Motivation

Image rotation code is, AFAICS, not used in any default setup in core, it's definitely a burden to maintain there, and has very little focus by contributors and maintainers.

This includes the GD Toolkit rotate operation class, the ImageEffect, the component Rectangle class, maybe other?

Along time a number of issues, mostly still open, were filed:

Proposed resolution

Deprecate the code for removal, and move it to contrib, where we can fix all the above more quickly. The Image Effects module could be a good candidate for that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#17 3240390-nr-bot.txt4.58 KBneeds-review-queue-bot
#3 deprecate_rotate.patch2.46 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new deprecate_rotate.patch2.46 KB

BTW, this patch shows that the image rotation GD toolkit operation is not even tested in HEAD, currently (ToolkitGdTest passes, it shouldn't when the toolkit operation is set to trigger a deprecation error).

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@mondrake we can't claim that this is not used in core. We have no idea of the number of sites that have configured the image rotate operation - right?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes

#5 yes, right... I probably meant it's not used by any default setup in core, updated IS. Obviously we would have to take time and phases to do this,

  1. add the relevant code to contrib, and tools to update image styles using the core rotate effect to the contrib one
  2. warn users that core will drop the rotate effect, thrugh status report
  3. deprecate code in core, change the warning to an error
  4. remove code from core

... or something like that.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#2918570: Drupal\KernelTests\Core\Image\ToolkitGdTest fails on PHP 7.1.x-dev and 7.0.x-dev following a PHP bugfix, +#2921123: Adjust Rectangle class to calculate rotated image dimensions according to libgd 2.2.2+, +#1551686: Image rotate dimensions callback can calculate new dimensions for every angle, +#2420789: Make RotateImageEffect's random rotation deterministic, so ::transformDimensions() can return the actual dimensions, +#2576639: "Regression": accept floats for degrees in rotate effect, +#2215369: Various bugs with PHP 5.5 imagerotate(), including when incorrect color indices are passed in, +#2464023: Move GD-specific code from Rotate::validateArguments() to Rotate::execute(), +#2796369: [PP-1] Cleanup gd/Rotate::execute() arguments array overloading
mondrake’s picture

mondrake
Location 🇮🇹
commented

Filed #3246867: Introduce 'Rotate' effect and operations, alternative to Drupal core's in Image Effects for #6.1.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mondrake’s picture

mondrake
Location 🇮🇹
commented

In Image Effects, #3248030: Add a drush command to convert core's 'Rotate' effect in image styles to Image Effects' one gives now the possibility to convert Rotate effects from those provided by core to those provided by the Image Effects module and viceversa. This will be included in the next minor 8.x-3.2.

#6.1 is fully done.

Re. #6.2, the Imagemagick module has deprecated in 8.x-3.3 its toolkit rotate operation in favour of the one provided by Image Effects, and in a future minor 8.x-3.4 will warn users to use the Image Effects' rotate effect.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review

I just wont fixed #2420789: Make RotateImageEffect's random rotation deterministic, so ::transformDimensions() can return the actual dimensions after 7 years without input.

smustgrave’s picture

smustgrave commented
Category: Feature request » Plan

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mondrake’s picture

mondrake
Location 🇮🇹
commented

There's no traction here. Won't fix?

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3240390-nr-bot.txt4.58 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Closed (won't fix)

Also the bots are against :), let's close this.

quietone’s picture

quietone commented
Version: 11.x-dev » 10.2.x-dev

Changing to latest version when this was closed.