Problem/Motivation

Per #3158395: Avoid similar-sounding links with different purposes (D8) it is recommended to change the "title" attribute on links to "aria-label".

Proposed resolution

Change all "title" attributes to "aria-label".

Remaining tasks

Make the changes.

User interface changes

All "title" attributes will change to "aria-label".

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#4 3243775-4.patch3.6 KBmohit.bansal623

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3243694: Avoid similar-sounding links with different purposes (D7) »
Related issues: +#3243694: Avoid similar-sounding links with different purposes (D7)
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3203686: Plan for Metatag 8.x-1.17
mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review
StatusFileSize
new 3243775-4.patch3.6 KB

Please review. Updated all title attributes to aria-label.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3203686: Plan for Metatag 8.x-1.17 » #3223325: Plan for Metatag 7.x-1.29
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3243776: Replace all title= attributes with aria-label= (D8)
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cboyden’s picture

cboyden commented

This patch introduces new accessibility violations, including WCAG 2.5.3 Label in Name. The aria-label attribute is not a drop-in replacement for the title attribute on links. Adding an aria-label completely replaces the visible text of the link, which is pretty much never going to be the desired outcome.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thanks for noticing that. Would you mind opening a new issue and we'll look into it?