Use warning icon for obsolete and deprecated modules on admin/modules

There is some CSS in system module too, so it may just work in claro, unless it swaps out that library

I have added a warning icon to highlight the deprecated modules same as seven theme. please review

Issue summary appears to be incomplete.

After Merge Request !7753

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

"I have reviewed this deprecated text, and it highlights much better now. It's fine to consider any user's perspective."
So finally We Move to RTBC.
Thanks.

#3215043: Indicate the non-stable statuses in admin/modules page seems to be removing this exact CSS from a number of places, so I'm a bit confused. Is this issue even still necessary? Why doesn't the original solution work in Claro? Can we re-test to confirm that HEAD is missing it?

In #16 I was looking at the patch. Hiding that. Question still stands as to why this is necessary/whether this is the correct approach though.

I reviewed this issue, that is a follow-up on #3215043: Indicate the non-stable statuses in admin/modules page.

This MR adds an existing icon from the theme in front of the link with text "(Deprecated)". This icon used is the correct one and helps user to identify that using a deprecated module carries some risk. Icon is added as a background image and does not have effect on Voiceover screenreader.

The confirmation message does not need the additional icon as the whole message is styled as a warning that has it's own icon.

@simohell:

• Manual testing is required to prove that the bug still exists. The "followup" you mention was committed years ago and therefore may have already resolved this.
• My questions in #16 also need to be addressed
• Either a Claro maintainer or (preferably) a frontend framework manager needs to validate the approach.

@xjm You mean the main issue is, that 11.x does not include /modules/system/css/system.admin.css on admin pages on Claro (or Olivero for that matter) even if it should? And it is also not certain wether it should or not?

(Edit: assume this is due to choise of CSS framework, but I'll ask)

Including /core/modules/system/css/system.admin.css would break some of the styling in Claro, so it makes sense that same icon is added to Claro in it's own CSS. Attached a screenshot of what would happend if the system CSS file would be used. #12 shows the expected result.

Claro with system.admin.css applied:

Claro 11.x:

What I'm looking for is Claro tested from the current 11.x or 10.3.x HEAD, without any fix applied. Thanks!

Here is before patch screenshot, without any fix applied on 11.x

Sorry. I had both but comment had 11.x HEAD only as attachement, not inline.

From #20 the task "Either a Claro maintainer or (preferably) a frontend framework manager needs to validate the approach." I think falls under the definition of "review" so I'll tag this back to "needs review".

I think this needs review from a Claro maintainer - there's some overlap with FEFMs anyway.

First, thanks all for working on this and finding a place that needs improvement. I agree with you all on this being one of those places.

We have restored the warning icon before the deprecated text on deprecated modules, just like in the Seven theme.

Even if this existed in Seven, it doesn't mean it'll visually work in Claro: it results in a really packed, confusing and un-structured group of elements. The solution proposed here is not the right one on a design/UI perspective. The title/heading is designed to hold the title, not title + parenthesis and its text + icons. We can't add info and elements to places that are not designed for that when there are no designs.

The goal of this issue is to make more obvious that a module is obsolete. +1 to that. The next step here is to find the right UI solution for Claro (applies to any UI), and that needs a designer designing that new part of the UI that don't exists (even if that existed in Seven, that solution doesn't work here). When that design is aproved, then let's jump into the implementation. This is the best workflow to be sure we end up with digestible UIs. :)

Edit: Thanks for tagging this as Needs subsystem maintainer review!

Adding to the meta about the install/uninstall pages.

@ckrina, how to get the design work asked for in this issue? Who can do that?

I'm going to move this to the admin theme, we still want to do this and claro is leaving.