Footer element don't have role in page.html.twig file. In HTML5 Footer have Aria role="contentinfo", so we can add this to our file.

CommentFileSizeAuthor
#11 after--patch--pic--3226894.png5.76 KBvikashsoni
#11 before--patch--pic--3226894.png31.14 KBvikashsoni
#8 Screenshot 2021-10-04 After Patch.png176.83 KBsagarchauhan
#8 Screenshot 2021-10-04 Before Patch.png157.26 KBsagarchauhan
#6 After Patch 3226894.png502.85 KBchetanbharambe
#6 Before Patch 3226894.png501.91 KBchetanbharambe
#5 3226894-after_patch.png52.09 KBabhijith s
#5 3226894-before_patch.png84.89 KBabhijith s
#2 3226894-2.patch585 bytesgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3226894-2.patch585 bytes

I have provided a patch with aria role added to footer element. Please review.

Ref document for Aria roles in HTML5 https://dequeuniversity.com/assets/html/jquery-summit/html5/slides/landm...

admin@azhark.com’s picture

admin@azhark.com commented
Status: Needs review » Reviewed & tested by the community

The patch looks good to me.

The only thing is, ref link is incorrect.
While inserting link kindly use the Insert/Edit Link button.

Aria Role HTML 5 Ref

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs review

Are we sure that reference isn't outdated, do screenreaders understand HTML5 now?

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3226894-before_patch.png84.89 KB
new 3226894-after_patch.png52.09 KB

Applied patch #2 and it adds the role in footer. Adding screenshots below.

Before patch:
before

After patch:
after

RTBC +1

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch 3226894.png501.91 KB
new After Patch 3226894.png502.85 KB

Verified and tested patch #2.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Appearance -> Apply Bartik Theme
# Goto Homepage
# Goto Footer Section -> Inspect the element -> check class="site-footer"

Expected Results:
# After applying the patch, role="contentinfo" should appear infront of class="site-footer"

Actual Results:
# Currently, role="contentinfo" is not rendering.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3226894-2.patch, failed testing. View results

sagarchauhan’s picture

sagarchauhan commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new Screenshot 2021-10-04 Before Patch.png157.26 KB
new Screenshot 2021-10-04 After Patch.png176.83 KB

This patch is still working. I have added the screenshot for reference. The tests failed due to random error.

Also here is the Ref document for Aria roles in HTML5: Aria Role HTML5

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Feedback from #4 hasn't been addressed.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Status: Needs review » Closed (won't fix)
Related issues: +#3226862: Olivero: Add role for footer element

This change is redundant.

See reasoning in #3226862: Olivero: Add role for footer element.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new before--patch--pic--3226894.png31.14 KB
new after--patch--pic--3226894.png5.76 KB

Applied patch #2 working fine and applied successfully
Thanks for the patch
for ref sharing screenshot ....

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

@vikashsoni re #11 there's no benefit in adding screenshots to an issue marked Closed (won't fix)