Footer element don't have role in page.html.twig file. In HTML5 Footer have Aria role="contentinfo", so we can add this to our file.

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

Status: Active » Needs review
StatusFileSize
new521 bytes

I have provided a patch with aria role added to footer element. Please review.

Ref document for Aria roles in HTML5 https://dequeuniversity.com/assets/html/jquery-summit/html5/slides/landm...

vikashsoni’s picture

StatusFileSize
new48.04 KB

@Gauravmahlawat thanks for the patch
successfully added Add role for footer element
for ref sharing screenshot

bnjmnm’s picture

@vikashsoni there is no benefit in showing the diff between a patch and HEAD, particularly as that is how the patch is generated to begin with. It's is essentially just taking a screenshot of the patch (not the results of the patch, literally this patch) in #2. Removing credit as per How is credit granted for Drupal core issues.

radheymkumar’s picture

StatusFileSize
new48.04 KB

@Gauravmahlawat thanks for the patch

bnjmnm’s picture

Issue summary: View changes
StatusFileSize
new170.01 KB

Re #5 @radheymkumar
I noticed you posted a diff of the patch. In the previous comment I'd just said such a comment provides no benefit nor will it earn issue credit.

I ALSO have to point out it is the exact same image as the (not useful )screenshot provided in #3, with a different filename.

MD5 doesn't lie 🙂

mherchel’s picture

@radheymkumar I would love you hear your explanation for #6

mherchel’s picture

Category: Support request » Bug report
Issue tags: +Needs accessibility review

I'd love to get an accessibility maintainer's thoughts on this. I know the "first rule of aria" is not to use aria, so I'm not going to OK this unless we have a real reason to do so.

larowlan’s picture

Agree, this feels superfluous

bnjmnm’s picture

I got so distracted by the dupe screenshot I neglected to help with accessibility.
This is currently needed, but not for long 🤔. This is needed by Safari 12, which is still supported as part of Drupal's supported browsers policy, where Safari is among the browsers Drupal supports "The latest release of each of the latest two supported major versions of". Safari 12 will not longer be supported by Apple as of November 30, 2021, however. Seems excessive, but may be worth accompanying this change with a @todo,

Or if the issue gets bikeshedded for ~3 months you can just close it as outdated 🤓☠️.

mherchel’s picture

Status: Needs review » Closed (won't fix)

Yeah, the next release isn't coming out until December, so my thought is that there's no point in making this change.