Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
other
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
2 Jun 2021 at 15:29 UTC
Updated:
21 Jan 2022 at 10:16 UTC
Jump to comment: Most recent
Assorted todo lists carried over from #3207851: [meta] Priorities for 2021-06-02 release of Drupal 7.
These are not necessarily in priority order.
Almost all of these fixes are viewed by some people to be important and may be included in their drush make or composer.json files.
Issues which have had recent activity, and are RTBC.
Simple Fixes: These may only take a few minutes each to review and commit.
Important Fixes:
Unsorted Fixes:
Comments
Comment #2
izmeez commentedNot to detract from all the work and effort that have gone into the commits for the Drupal 7.81 release, however, I wonder if the maintainers are willing to consider an earlier date (than December 1, 2021) for the next release as there are still a number of issues that are important and reflect the effort and patience of the community. Thank you.
Comment #3
sgdev commented@MustangGB, thanks for taking the time to document all of this. There are a number of patches listed that we have been using with production sites for multiple years, and would be great to finally get them committed into core.
Comment #4
ressaThanks for sharing that some patches have been used in production for many years @ron_s. Should we tag relevant issues to easier prioritize next release, something like this?
Comment #5
izmeez commentedUpdated issue summary, extended note on #2994212: SqlContentEntityStorage::loadFromDedicatedTables() does use an unnecessary sort in the DB leading to a filesort as the D7 patch still appears good to go while the D9 patch needs work.
Some of the other issues need to be RTBC and some need tests in preparation for commit.
How best to prioritize them is still difficult as almost all of them are useful and may be used in production somewhere.
Are there other core issue patches that have been overlooked that are important? This curated list does provide a place for others to see what patches they might wish to add to their own drush make or composer files.
Comment #6
izmeez commentedMinor cleanup of text.
Comment #7
beakerboyComment #8
roderikJust adding some issues to the "Simple fixes" category (found while browsing RTBC issues)...
Comment #9
izmeez commented@roderik Thanks. Added the extra patches to drush make file and they all apply along with other patches without issue.
Wonder if this might help nudge forward the idea of an earlier release possibly in September or October?
Comment #10
mcdruid commentedComment #11
joelpittetComment #12
roderikComment #13
mcdruid commentedAdded the announce project (to the IS), which has the goal of being included in core.
Comment #14
beakerboyWhat else does it take to get RTBC simple fixes merged?
Comment #15
mustanggb commentedThis is D7, why even consider adding a new module, especially one that is only for D8+, doesn't have any releases, doesn't have any documentation, it can live in contrib.
Comment #16
andypostComment #17
mcdruid commentedAdding a http headers issue which came up via seckit.
Also, I'll leave the announce project alone in the IS for now, but the suggestion (from the DA) is that we might want to add a backport to D7 to ensure that e.g. sites which carry on using D7 after EOL can receive significant notifications. This is not the place to discuss that in detail, but I don't think there's a specific backport issue for the project yet. No decisions have been made about adding that to D7 core but that's the proposal. I'll ask for a backport issue to be created and link to it from here.
Comment #18
mcdruid commentedComment #19
mustanggb commented@mcdruid Thanks for the information, is there anywhere where more details about this announce module is, for example where is this proposal/discussion you mentioned documented?
I couldn't find it on: https://www.drupal.org/project/ideas
Or trawling through: https://www.drupal.org/about/core
Comment #20
mcdruid commented@MustangGB I believe it was suggested to me in drupal slack, most likely by @hestenet I think.
I've asked whether there's a D7 backport issue already, and for one to be started if not.
Here's a link to one relevant thread in slack if that's any use to anyone in the meantime:
https://drupal.slack.com/archives/C02AFHAUNET/p1635976045028600?thread_t...
Comment #21
mustanggb commentedThanks for that, found what I was looking for:
https://www.drupal.org/project/ideas/issues/2940739
https://www.drupal.org/project/drupal/issues/3206643
Was pretty disturbed by this abhorrent attitude mentioned in the above issue though:
There had better be a way to ensure this is disableable.
Comment #22
mcdruid commentedAdded announce project D7 backport issue to IS, as discussed.
Comment #23
mcdruid commentedComment #24
mcdruid commentedComment #25
mcdruid commentedremoving a duplicate
Comment #26
damienmckennaAdded #3209417 to the "for consideration" list.
Comment #27
mcdruid commentedMoved several issues to Done.
Comment #28
mustanggb commentedYay, lovely to see some movement in the issue queue, much appreciated!
Comment #29
mcdruid commentedComment #30
mcdruid commentedComment #31
mcdruid commentedPer #3224299: [META] Make Drupal 7 core compatible with PHP 8.1 D7 now passes tests in PHP 8.1 with both MySQL and SQLite; added 6x issues to a PHP 8.1 section under "done".
Comment #32
izmeez commentedUpdated reference to #1951408: Core Update manager doesn't correctly handle "status" UPDATE_NOT_CHECKED
Comment #33
mcdruid commentedA few more added to the "Done" list :)
Comment #34
mcdruid commented..missed another that's now Fixed.
Comment #35
mcdruid commentedAdding a permissions / ACL issue that I think I was pinged about...
Comment #36
mustanggb commentedWhilst juices are flowing I'd like to throw another request forward in the form of #691932: Add hook_field_schema_alter().
Comment #37
damienmckennaAdded #3063048 as it seems relatively minor and has been RTBC for two years.
Comment #38
damienmckennaAdded #2907409 for an innocuous typo, #1768622 for a language name mistake, #3026560 for a long-running Drush problem.
Comment #39
izmeez commentedUpdated the issue references in comments #37 & #38 to titles and links in this comment for those who want to take a quick look:
#3063048: Error 500 when hitting any folders inside en/sites/default/files/styles/
#2907409: Fix the typo in hook_node_validate() documentation
#1768622: Dzongkha language is missing (wrongly labeled as "Bhutani")
#3026560: After upgrade to 7.63, 8.5.10, 8.6.7, 9.4.0 get TYPO3 phar error for drush
Comment #40
poker10 commentedWow, it seems like that there was a lot of work done. Thanks to all!
I am just a bit curious if someone have considered to include in the upcoming D7 December release this issue: #1705618: Double click prevention on form submission? I don't think there will be many maintenance releases until D7 EOL, so it will be worth to push it the sooner the better. I know, that this issue is mentioned here in "Important fixes", but it is not committed yet. I think that this is a very important fix which will greatly improve D7 UX.
Comment #41
mustanggb commentedLots more got done.
Comment #42
mustanggb commentedComment #43
mustanggb commentedComment #44
mcdruid commentedI don't plan to commit anything else for the release on 2021-12-01 other than the CHANGELOG.txt entry etc..
There are a couple of issues which nearly got in but not quite; these should be close to the top of the list for the next release.
Comment #45
strelkov.avThank you so much for the new release, the fixes and the work done! If it works, it would be great to add this fix https://www.drupal.org/project/drupal/issues/3176634 to the next release after that.
Comment #47
mcdruid commentedhttps://www.drupal.org/project/drupal/releases/7.83 released.
Thank you everyone that contributed!
Comment #48
ressaThanks for this early Christmas present @mcdruid, @MustangGB, @izmeez, @DamienMcKenna, and everyone else here and in the issues who helped make it happen! It's so great to see that Drupal 7 now doesn't set any cookies out of the box, after #229825: backport "$_COOKIE['has_js'] must die" patch to 7.x got committed, along with all the other improvements.
Comment #49
izmeez commentedThanks for all the work that went into this release.
Added #2550519: Crypt::randomBytes()/drupal_random_bytes() doesn't actually return cryptographically secure random bytes to the list before it is moved to a new issue for the next release.
Comment #50
izmeez commentedAgain, a huge thank you to the maintainers on the recent release and hotfix.
In anticipation that this issue will be used to create a new issue of priorities for the next release in 2022 a couple of items have been reordered from unsorted fixes to important fixes and one more has been added to the unsorted fixes:
#498752: Partial word search for Drupal 7 Includes working patch from 5 yrs ago. Was closed as won't fix feature request. Now that a similar feature is proposed for D9 core #103548: Partial Search in Drupal Core maybe it's worth considering.
Comment #51
izmeez commentedRemoved duplicate item.
Comment #52
izmeez commentedAdding another issue to the summary prior to rollover to new issue of priorities for next release:
#3255713: [D7] Login fails and no warning is issued if cookies are not enabled This is a D7 backport of #2946: Login fails and no warning is issued if cookies are not enabled, an 18 year old issue that was marked as major and committed to drupal 9.3.x in June 2021.
Comment #53
izmeez commentedAdding another potentially simple fix although there is a suggestion for improvement.
#3182785: PHP 7.4 notice for /modules/system/system.admin.inc A simple fix that could possibly be improved.
Comment #55
izmeez commentedSince this issue has not yet been rolled over into a new issue of priorities for the next release adding one more issue for consideration.
#822128: "Textarea + summary" widget broken when field allows multiple values (followup) and associated JavaScript uses fragile selectors Has been committed to Drupal 8 and 9. Includes patch for D7 in #26 that was RTBC.
Comment #56
izmeez commentedAdded another issue for consideration.
#2539478: [D7] Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only) Adds svg to allowed extensions for image fields.
Comment #57
poker10 commentedThanks for all the work with the last release!
Is there any ETA for the next maintenance release of D7? It seems like that we have here a lot of important issues, some of them would be good to push sooner the better, as they will greatly improve some parts of D7.
I hope that there would not be only one last release shortly before EOL.
Comment #58
izmeez commentedComment #59
mcdruid commentedhttps://www.drupal.org/about/core/policies/core-release-cycles/drupal-7-...
I've not yet had a chance to update that and create a new meta issue for the next maintenance release, which is scheduled for 2022-06-01.
Comment #60
mcdruid commented#3259739: [meta] Priorities for 2022-06-01 release of Drupal 7