Body overflow when link text too long. Adding screenshot for reference.

CommentFileSizeAuthor
#24 Screenshot (74).png65.11 KBnupur badola
#17 3204020--seven--before--patch--pic.png64.42 KBvikashsoni
#17 3204020--bartik--before--patch--pic.png41.43 KBvikashsoni
#15 Screen Shot 2021-04-19 at 11.51.19 PM.png119.51 KBdjsagar
#15 Screen Shot 2021-04-19 at 11.51.12 PM.png82.17 KBdjsagar
#15 Screen Shot 2021-04-19 at 11.50.58 PM.png77.81 KBdjsagar
#13 View-after-patch.png408.51 KBsakthivel m
#13 content-after-patch.png406.67 KBsakthivel m
#13 view-Before-patch.png408.51 KBsakthivel m
#13 content-before-patch.png350.33 KBsakthivel m
#12 View-Before-patch.png101.47 KBdjsagar
#12 View-After-patch.png98.67 KBdjsagar
#12 Node-Before-patch.png94.59 KBdjsagar
#12 Node-After-patch.png124.4 KBdjsagar
#12 content-Before-patch.png97.67 KBdjsagar
#12 content-After-patch.png86.27 KBdjsagar
#11 before.png29.68 KBsulfikar_s
#11 after.png40.01 KBsulfikar_s
#10 3204020.10.patch359 bytessakthivel m
#9 3204020.9.patch362 bytessakthivel m
#6 website_after-3204020-6.png65.47 KBkleiton_rodrigues
#6 website_before-3204020-6.png35.81 KBkleiton_rodrigues
#5 3204020_after.png347.28 KBhinal05
#5 3204020_before.png336.78 KBhinal05
#4 3204020-after.png30.29 KBabhijith s
#4 3204020-before.png25.87 KBabhijith s
Overflow-resolved.patch385 bytesmeghasharma
After_patch.png249.51 KBmeghasharma
Before_patch.png201.8 KBmeghasharma

Issue fork bartik-3204020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

meghasharma created an issue. See original summary.

meghasharma’s picture

meghasharma commented
Assigned: meghasharma » Unassigned
meghasharma’s picture

meghasharma commented
Status: Active » Needs review
abhijith s’s picture

abhijith s commented
StatusFileSize
new 3204020-before.png25.87 KB
new 3204020-after.png30.29 KB

Applied Overflow-resolved.patch patch and it fixes the issue

Before patch;
before

After patch:
after

RTBC +1

hinal05’s picture

hinal05 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3204020_before.png336.78 KB
new 3204020_after.png347.28 KB

Applied patch Overflow-resolved and it's resolving the issue.

kleiton_rodrigues’s picture

kleiton_rodrigues commented
StatusFileSize
new website_before-3204020-6.png35.81 KB
new website_after-3204020-6.png65.47 KB

patch Overflow-resolved.patch applied on the website looks good!
RTBC + 1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

I think we should be using word-wrap: anywhere; as per discussions on #3177475: Olivero: Ensure long words break properly when zoomed in to provide proper reflow - plus the patch has never completed a test run because it fail stylelinting checks. See https://www.drupal.org/pift-ci-job/2004736

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@hinal05 and @kleiton_rodrigues - @Abhijith S already posted before and after screenshots - posting the same screenshots is not necessary. This is the same as coming to an issue an posting exactly the same patch as an earlier contributor. So, I've removed the issue credit for these screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you!

See the issue credit guidelines for more information.

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Needs review
StatusFileSize
new 3204020.9.patch362 bytes

Hi
#9 I have provided the patch please verify if it is working or not

sakthivel m’s picture

sakthivel m commented
StatusFileSize
new 3204020.10.patch359 bytes

#9 Patch Custom Commands Failed,

Re created patch #10

sulfikar_s’s picture

sulfikar_s commented
StatusFileSize
new after.png40.01 KB
new before.png29.68 KB

Hi, I've tested the #10 patch, and is working fine. The custom commands failure is also fixed!

Hereby attaching the before and after screenshots,

Before,
before.png

After,
after.png

So RTBC+1.

djsagar’s picture

djsagar commented
Status: Needs review » Needs work
StatusFileSize
new content-After-patch.png86.27 KB
new content-Before-patch.png97.67 KB
new Node-After-patch.png124.4 KB
new Node-Before-patch.png94.59 KB
new View-After-patch.png98.67 KB
new View-Before-patch.png101.47 KB

Hi all,

This issue is not only for one place this is replicated three pleases, Answer should be globally.

Please review the all attachment where i found that issue.

Thanks!

sakthivel m’s picture

sakthivel m commented
StatusFileSize
new content-before-patch.png350.33 KB
new view-Before-patch.png408.51 KB
new content-after-patch.png406.67 KB
new View-after-patch.png408.51 KB

Hi @djsagar

Can you please verify your administrator theme as Bartik theme.

I have tested the #10 patch, and is working fine.

Before

Before

Before

After

After

After

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Needs review
djsagar’s picture

djsagar commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2021-04-19 at 11.50.58 PM.png77.81 KB
new Screen Shot 2021-04-19 at 11.51.12 PM.png82.17 KB
new Screen Shot 2021-04-19 at 11.51.19 PM.png119.51 KB

@Sakthivel M,

Yes after apply Bartik as administrator theme issue is resolved all the pages but i think issue must be resolved on other theme as well.

thanks!

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented
StatusFileSize
new 3204020--bartik--before--patch--pic.png41.43 KB
new 3204020--seven--before--patch--pic.png64.42 KB

There is no issue like this
I am sharing screenshot for before patch ....

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pameeela’s picture

pameeela commented
Project: Drupal core » Bartik
Version: 10.1.x-dev » 1.0.2
Component: Bartik theme » Look and Feel
Issue tags: +Bug Smash Initiative

Moving to contrib since Bartik was removed from core in D10.

djsagar opened merge request !7

djsagar’s picture

djsagar commented
Status: Needs work » Needs review

Kindly review MR.

nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot (74).png65.11 KB

This is working fine now for me.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Bartik's body text will overflow when link text too long. » Prevent overflow of body text when link text is too long
Version: 1.0.2 » 1.0.x-dev

  • liam morland committed 498efcc2 on 1.0.x authored by djsagar 
    [#3204020] fix: Prevent overflow of body text when link text is too long
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.