Add delay to queue suspend

1. +++ b/core/lib/Drupal/Core/Cron.php
   @@ -166,55 +179,115 @@ class Cron implements CronInterface {
   +    $maxWait = $this->settings->get('queue_suspend_maximum_wait', 30.0);
   +    assert(is_float($maxWait));
   ...
   +      return isset($queueInfo['cron']);
   ...
   +    $queues = array_map(function (array $queue_info) {
   

   nit: mixed variable naming styles here

2. +++ b/core/lib/Drupal/Core/Cron.php
   @@ -166,55 +179,115 @@ class Cron implements CronInterface {
   +    $queues = array_values($this->queueManager->getDefinitions());
   +    $queues = array_filter($queues, function (array $queueInfo) {
   

   any reason not to do this in one line?

3. +++ b/core/lib/Drupal/Core/Cron.php
   @@ -166,55 +179,115 @@ class Cron implements CronInterface {
   +        'queue' => $queue,
   +        'worker' => $worker,
   +        'process_from' => $process_from,
   

   note to self, php7.1+ syntax, so fine for 9.2+

4. +++ b/core/lib/Drupal/Core/Queue/SuspendQueueException.php
   @@ -12,4 +12,54 @@ namespace Drupal\Core\Queue;
   +  public function __construct(?float $delay = NULL, string $message = '', int $code = 0, \Throwable $previous = NULL) {
   +    parent::__construct($message, $code, $previous);
   

   this is a BC change right? previously the first argument was a string, now its a float

   should we put the delay as the fourth argument to maintain BC?

5. I think we're missing test coverage for the sort-ordering of the different process_from values

Nice work, the execution approach makes sense to me

Re-roll of #7

Can MR be updated for 10.1.x please.

Also see there was failure for 9.4.x that may need to be addressed.

The code looks good. Not sure about the commits afters #23? Were the tests not passing before?

Moving to NW for a change record, which I assume is needed for a change to default.setting file.

Removing credit for the users who rebased the issue (including myself)

Reroll against 9.5.x

Missed the new tests.

Draft a CR https://www.drupal.org/node/3343288

Feel free to reword however you see fit, I'm not great at this stuff.

Latest run is green.

Seems to be 2 open threads if those could be answered

All threads appear to be resolved
Change records is added
Think this is good.

Committed 2d0782d and pushed to 10.1.x. Thanks!

This unfortunately broke the Feeds module. Running queues using a derivative no longer works after this change.

This is how the definition of a Feeds queue can look like:

'feeds_feed_refresh:article' => array (6) [
        'title' => Drupal\Core\StringTranslation\TranslatableMarkup (5) (
            protected 'string' -> string (30) "Feed refresh: @feed_type_label"
            protected 'arguments' -> array (1) [
                '@feed_type_label' => string (7) "Article"
            ]
            protected 'translatedMarkup' -> null
            protected 'options' -> array (0) []
            protected 'stringTranslation' -> null
        )
        'id' => string (18) "feeds_feed_refresh"
        'cron' => array (1) [
            'time' => integer 60
        ]
        'deriver' => string (46) "Drupal\feeds\Plugin\Derivative\FeedQueueWorker"
        'class' => string (43) "Drupal\feeds\Plugin\QueueWorker\FeedRefresh"
        'provider' => string (5) "feeds"
    ]

Note that the key is different from the 'id'. The id is the base plugin ID and the key is the derivative plugin ID.

For the issue mentioned in the comment above I created a new issue: #3348832: Running cron queues that use a derivative is broken