Drupal 9 cannot use "db_or", "db_like" [#3185256]

Problem/Motivation

The upgrade process is generating an error because it can't locate some function called db_or. If the module is in the wrong place for the upgrade to find it, please let me know.

Thanks for any help.

Steps to reproduce

Start with a clean version of Drupal 9.0.8 built with composer. Running php7.4.
Install DMU: composer require 'drupal/drupalmoduleupgrader:^1.5'
Install drush composer require drush/drush
Place module in question in web/modules/contrib/. In this case, this means the Annotation module from here:
https://www.drupal.org/project/annotation

Run dmu-analyze. Get an empty report:

 vendor/drush/drush/drush dmu-analyze annotation
Indexing...
done.

And then run dmu-upgrade and get the error:

 vendor/drush/drush/drush dmu-upgrade annotation
Indexing...
done.
 [warning] annotation does not implement hook_hook_entity_info.
 [error]  Error: Call to undefined function Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\db_or() in Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\HookFormAlter->convert() (line 25 of /var/www/html/ann3/web/modules/contrib/drupalmoduleupgrader/src/Plugin/DMU/Converter/HookFormAlter.php) #0 /var/www/html/ann3/web/modules/contrib/drupalmoduleupgrader/src/Commands/DrupalmoduleupgraderCommands.php(188): Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\HookFormAlter->convert()
#1 [internal function]: Drupal\drupalmoduleupgrader\Commands\DrupalmoduleupgraderCommands->upgrade()
#2 /var/www/html/ann3/vendor/consolidation/annotated-command/src/CommandProcessor.php(257): call_user_func_array()
#3 /var/www/html/ann3/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#4 /var/www/html/ann3/vendor/consolidation/annotated-command/src/CommandProcessor.php(176): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#5 /var/www/html/ann3/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(311): Consolidation\AnnotatedCommand\CommandProcessor->process()
#6 /var/www/html/ann3/vendor/symfony/console/Command/Command.php(255): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#7 /var/www/html/ann3/vendor/symfony/console/Application.php(1018): Symfony\Component\Console\Command\Command->run()
#8 /var/www/html/ann3/vendor/symfony/console/Application.php(271): Symfony\Component\Console\Application->doRunCommand()
#9 /var/www/html/ann3/vendor/symfony/console/Application.php(147): Symfony\Component\Console\Application->doRun()
#10 /var/www/html/ann3/vendor/drush/drush/src/Runtime/Runtime.php(118): Symfony\Component\Console\Application->run()
#11 /var/www/html/ann3/vendor/drush/drush/src/Runtime/Runtime.php(49): Drush\Runtime\Runtime->doRun()
#12 /var/www/html/ann3/vendor/drush/drush/drush.php(72): Drush\Runtime\Runtime->run()
#13 /var/www/html/ann3/vendor/drush/drush/drush(4): require('/var/www/html/a...')
#14 {main}. 
Error: Call to undefined function Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\db_or() in /var/www/html/ann3/web/modules/contrib/drupalmoduleupgrader/src/Plugin/DMU/Converter/HookFormAlter.php on line 25 #0 /var/www/html/ann3/web/modules/contrib/drupalmoduleupgrader/src/Commands/DrupalmoduleupgraderCommands.php(188): Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\HookFormAlter->convert()
#1 [internal function]: Drupal\drupalmoduleupgrader\Commands\DrupalmoduleupgraderCommands->upgrade()
#2 /var/www/html/ann3/vendor/consolidation/annotated-command/src/CommandProcessor.php(257): call_user_func_array()
#3 /var/www/html/ann3/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#4 /var/www/html/ann3/vendor/consolidation/annotated-command/src/CommandProcessor.php(176): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#5 /var/www/html/ann3/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(311): Consolidation\AnnotatedCommand\CommandProcessor->process()
#6 /var/www/html/ann3/vendor/symfony/console/Command/Command.php(255): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#7 /var/www/html/ann3/vendor/symfony/console/Application.php(1018): Symfony\Component\Console\Command\Command->run()
#8 /var/www/html/ann3/vendor/symfony/console/Application.php(271): Symfony\Component\Console\Application->doRunCommand()
#9 /var/www/html/ann3/vendor/symfony/console/Application.php(147): Symfony\Component\Console\Application->doRun()
#10 /var/www/html/ann3/vendor/drush/drush/src/Runtime/Runtime.php(118): Symfony\Component\Console\Application->run()
#11 /var/www/html/ann3/vendor/drush/drush/src/Runtime/Runtime.php(49): Drush\Runtime\Runtime->doRun()
#12 /var/www/html/ann3/vendor/drush/drush/drush.php(72): Drush\Runtime\Runtime->run()
#13 /var/www/html/ann3/vendor/drush/drush/drush(4): require('/var/www/html/a...')
#14 {main}
Error: Call to undefined function Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\db_or() in Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\HookFormAlter->convert() (line 25 of /var/www/html/ann3/web/modules/contrib/drupalmoduleupgrader/src/Plugin/DMU/Converter/HookFormAlter.php).
 [warning] Drush command terminated abnormally.

Comment	File	Size	Author
#12	interdiff.txt	420 bytes	solideogloria
#10	drupalmoduleupgrader-db-or-like-3185256-10.patch	2.29 KB	solideogloria
#4	drupalmoduleupgrader-db-or-like-3185256-4.patch	2.07 KB	solideogloria

Issue fork drupalmoduleupgrader-3185256

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3185256-drupal-9-cannot compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 November 2020 at 19:06

bogdog400 created an issue. See original summary.

Comment #2

bogdog400 commented 2 December 2020 at 13:12

I downgraded from the dev version to 1.5 and got the same error.

Comment #3

solideogloria commented 5 February 2021 at 19:21

If you look at the code:

    // @FIXME This is not working (returns empty result set)...don't know why.
    $alter_hooks = $indexer
      ->getQuery()
      ->condition(db_or()
        ->condition('id', $target->id() . '_form_alter')
        ->condition('id', db_like($target->id() . '_form_%_alter'), 'LIKE')
      )
      ->execute();

So maybe this is why.

db_or() and db_like() are both deprecated in 8.0.0 and removed in 9.0.0.

Comment #4

solideogloria commented 5 February 2021 at 20:37

Status:

Active

» Needs review

Status	File	Size
new	drupalmoduleupgrader-db-or-like-3185256-4.patch	2.07 KB

Though this was a bit tricky to find the right way to do the OR-ing, I figured it out.

The patch replaces the instances of db_or and db_like. I tested it on the module you mentioned, and it works now.

ALSO, I noticed that the LIKE's weren't escaped properly, because underscores are wildcards in SQL, so I fixed that, too.

Comment #5

solideogloria commented 5 February 2021 at 20:23

Title:

Upgrade fails on missing function "db_or"

» Drupal 9 cannot use "db_or", "db_like"

Comment #6

solideogloria commented 5 February 2021 at 20:35

Parent issue:

» #3184120: Drupal 9 readiness

Comment #7

9 February 2021 at 08:36

tyler36 made their first commit to this issue’s fork.

Comment #8

tyler36 commented 9 February 2021 at 08:42

@solideogloria , almost there.

Patch changes error to
Error: Class 'Drupal\corefake\Driver\Database\corefakeWithAllCustomClasses\Condition' not found in Drupal\drupalmoduleupgrader\Plugin\DMU\Converter\HookFormAlter->convert()

I think you forgot to import the class
use Drupal\Core\Database\Query\Condition;

(sorry ... not sure how to create patches yet)

Comment #9

solideogloria commented 12 February 2021 at 17:41

@tyler36 You should read this page: Making a patch | Using Git to Contribute to Drupal.

Comment #10

solideogloria commented 12 February 2021 at 17:45

Status	File	Size
new	drupalmoduleupgrader-db-or-like-3185256-10.patch	2.29 KB

I added the import. Please review again. Thanks.

Also, for reference, change the issue status to "Needs Work" if you find something like that in the future.

Comment #11

jcnventura

English

commented 14 February 2021 at 18:16

And interdiffs :)

Would be good to have either @bogdog400 or @tyler36 test and review this. Once you do, please set the status to 'Reviewed and tested by community' if @solideogloria's patch fixed the issue.

Comment #12

solideogloria commented 15 February 2021 at 14:52

Status	File	Size
new	interdiff.txt	420 bytes

Comment #13

tyler36 commented 17 February 2021 at 07:23

Status:

Needs review

» Reviewed & tested by the community

Confirmed.

- Reproduced error on Drupal 9.0.3.
- Applied #10 patch
- Run `drush dmu-upgrade annotation`
- Recieved new message

Indexing...
done.
 [warning] annotation does not implement hook_hook_entity_info.

- Code appears to have been updated as expected

PS. @solideogloria, thanks for your patience and guidance

Comment #14

21 February 2021 at 17:43

jcnventura committed 54d63db on 8.x-1.x authored by solideogloria

Issue #3185256 by solideogloria, tyler36: Drupal 9 cannot use "db_or", "...

Comment #15

jcnventura

English

commented 21 February 2021 at 17:44

Status:

Reviewed & tested by the community

» Fixed

Thanks for the work and review, @solideogloria and @tyler36

Comment #16

7 March 2021 at 17:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 cannot use "db_or", "db_like"

Problem/Motivation

Steps to reproduce

Issue fork drupalmoduleupgrader-3185256

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Parent issue

News items

Our community

Documentation

Drupal code base

Governance of community