We need to determine if there's anything preventing us from adding the
core_version_requirement: ^8 || ^9
line to the .info.yml of this module.

Currently this is preventing the tests from running on Drupal 9.

Comments

jcnventura created an issue. See original summary.

  • jcnventura committed 417ea93 on 8.x-1.x
    Issue #3184120 by jcnventura: Drupal 9 readiness
    
jcnventura’s picture

Status: Active » Needs work

The tests are not even running due to the use of a deprecated Drupal\Tests\PhpunitCompatibilityTrait in tests/src/Unit/TestBase.php.

However in the hope that others can contribute to this effort, I'm leaving the change in the module so that the D9 tests can at least be executed. This change needs to be reverted if it is decided to create a new release while the D9 tests still fail.

cyb_tachyon’s picture

SafeMarkup methods also need to be cleaned up. See https://www.drupal.org/node/2549395

We likely want to use \Drupal\Core\StringTranslation\TranslatableMarkup.

solideogloria’s picture

damienmckenna’s picture

See #3211835 for a working patch for the SafeMarkup usage.

joseph.olstad’s picture

gábor hojtsy’s picture

Status: Needs work » Closed (outdated)

I now made a 2.x branch which is now Drupal 10 and 11 compatible. Will not do more for Drupal 9 at this point. See https://www.drupal.org/project/drupalmoduleupgrader/releases/2.0.0-alpha2

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.