Ran drupal-check and found 6 errors:

15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------- 
  Line   event_log_track_auth/event_log_track_auth.module                                        
 ------ ---------------------------------------------------------------------------------------- 
  38     Call to deprecated method getUsername() of class Drupal\Core\Session\AccountInterface:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                       
         Use \Drupal\Core\Session\AccountInterface::getAccountName() or                          
         \Drupal\user\UserInterface::getDisplayName() instead.                                   
  42     Call to deprecated method getUsername() of class Drupal\Core\Session\AccountInterface:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                       
         Use \Drupal\Core\Session\AccountInterface::getAccountName() or                          
         \Drupal\user\UserInterface::getDisplayName() instead.                                   
 ------ ---------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------- 
  Line   src/EventLogStorage.php                                                  
 ------ ------------------------------------------------------------------------- 
  51     Call to deprecated function db_like():                                   
         in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,               
         get a database connection injected into your service from the container  
         and call escapeLike() on it. For example,                                
  54     Call to deprecated function db_like():                                   
         in drupal:8.0.0 and is removed from drupal:9.0.0. Instead,               
         get a database connection injected into your service from the container  
         and call escapeLike() on it. For example,                                
 ------ ------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   src/OverviewForm.php                                                       
 ------ --------------------------------------------------------------------------- 
  137    Call to deprecated method getUsername() of class Drupal\user\Entity\User:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                          
         Use \Drupal\Core\Session\AccountInterface::getAccountName() or             
         \Drupal\user\UserInterface::getDisplayName() instead.                      
  137    Call to deprecated method l() of class Drupal\Core\Form\FormBase:          
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                      
         \Drupal\Core\Link::fromTextAndUrl() instead.                               
 ------ --------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 6 errors
CommentFileSizeAuthor
#7 D9-3139060-5.patch5.23 KBdahousecat
#6 D9-3139060-4.patch5.08 KBtatovic
#3 D9-3139060-3.patch5.93 KBmanish_tapadar
#2 D9-3139060-2.patch2.41 KBdishabhadra

Issue fork events_log_track-3139060

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
Status: Active » Needs review
StatusFileSize
new D9-3139060-2.patch2.41 KB

Created the patch.

Checked using Upgrade status and drupal-check no errors found.

15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors
manish_tapadar’s picture

manish_tapadar commented
StatusFileSize
new D9-3139060-3.patch5.93 KB

here is the complete patch

sharique’s picture

sharique commented
Status: Needs review » Needs work

Thanks for the patch, please also add "core_version_requirement: ^8.8 || ^9" to info fine and composer.json as well.

sharique’s picture

sharique commented
Related issues: +#3139064: Drupal 9 readiness, +#3140447: Automated Drupal 9 compatibility fixes
tatovic’s picture

tatovic commented
StatusFileSize
new D9-3139060-4.patch5.08 KB

I was unable to apply #3 so here's an updated version, I'd appreciate any reviews/tests.

dahousecat’s picture

dahousecat commented
StatusFileSize
new D9-3139060-5.patch5.23 KB

I was unable to apply #4 so here's another updated version.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
redzeuf’s picture

redzeuf
he/him
Primary language French
Location Geneva
commented
Status: Needs review » Needs work

The report forgot few depreacated functions. For exemple in file event_log_track.module, line 75 and 79 in function event_log_track_auth_user_logout()

smustgrave’s picture

smustgrave commented
Version: 8.x-1.1 » 3.0.x-dev
Status: Needs work » Fixed

Ran against 3.0.x branch

14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Thanks for using drupal-check!

Consider sponsoring the development of the maintainers which make drupal-check possible:

- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman

smustgrave’s picture

smustgrave commented
Status: Fixed » Closed (fixed)