Drupal 9 Readiness

i found some deprecation code in module:

web/modules/contrib/backup_migrate_aws_s3/backup_migrate_aws_s3.module	line 14	Instantiation of deprecated class Symfony\Component\ClassLoader\Psr4ClassLoader: since version 3.3, to be removed in 4.0.

please ignore this patch

some extra spaces errors has fixed..

Patch #10 Works fine for me, Adding a after patch screenshot for reference.
RTBC +1

Any chance we can get this patch committed and maybe even get a new release cut?

+1 for getting patch #10 committed.

This patch incorporates #10 and makes other updates that, for me, make this module truly functional with Drupal 9.1x. Namely:

• Replaces use of deprecated Symfony class loader with Composer class loader.
• Updates namespaces in references to Backup and Migrate classes.
• Adds helper methods to comply with parent abstract class in AmazonS3Destination.php. (This could probably be done better.)

With `core_version_requirement: ^8 || ^9` still missing from the info file, the module still has to be downloaded and installed manually, instead of properly via Composer, before this patch can even be applied. So chicken-and-egg.

One more patch: The #15 patch left some parse errors behind. This patch clears those errors by having the abstract methods AmazonS3Destination::saveFileMetadataArray() and AmazonS3Destination::loadFileMetadataArray() return empty arrays. I trusted the existing code comments and didn't reverse-engineer deeply enough to know if this is the best solution, but the module works and no obvious harm is caused.

#16 seems to patch fine and work for me on D9.2. +1 for getting this committed

Dependency for this is defined as drupal/backup_migrate 4.1
Where as, backup_migrate is D9 ready from 5.0
Would like this dependency to be changed. Can someone guide me what is the best way to go about it?

When you update to B&M 5.0.x you'll discover that the custom class namespace doesn't work anymore, you'll have to move the custom classes into the main module directory structure and make them PSR-4 compatible. You'll then be able to remove the autoloader logic from the module file.

Dependency is defined to be backup_migrate:4.1 which is not D9 ready.
Should modify the dependency to be backup_migrate:5.0

Also created a merge request
https://git.drupalcode.org/issue/backup_migrate_aws_s3-3136520/-/merge_r...

@DamienMcKenna
Sorry missed your comment. Will look into that too. Thanks

Please see latest branch.