Improve Email field validation error message to improve accessibility

One problem with this is that email addresses can be more complex than that.

For instance, you can have 'user+suffix@example.com'.

Applied patch #2 on 8.9.x and it works fine.

Before patch:

After patch:

RTBC +1

Patch #2, works fine to me. Moving to RTBC.

+++ b/core/lib/Drupal/Core/Render/Element/Email.php
@@ -76,7 +76,7 @@ public static function validateEmail(&$element, FormStateInterface $form_state,
 
     if ($value !== '' && !\Drupal::service('email.validator')->isValid($value)) {
-      $form_state->setError($element, t('The email address %mail is not valid.', ['%mail' => $value]));
+      $form_state->setError($element, t('The email address %mail is not valid. It should look like example@domain.com.', ['%mail' => $value]));
     }
   }

Instead of 'it should look like example@domain.com' could we use something like 'use the format user@example.com'.

Also normally with examples we use example.com which is reserved. domain.com is an actual valid domain that points to a website - so we shouldn't use that.

Hi Team,

I have created patch for the above problem motivation. Need review

Applied patch #2 on 9.4.3 and it works fine.

Before Patch Apply

After Patch Apply

patch #10 successfully applied on drupal 10.1.0-dev and 9.4.x Which I showed by screenshot.

Thanks and Regards .

#10 Patch Applied on 10.1.x-dev and it works fine for me.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Even though this is a task think it could use test coverage for the change.

Added tests, please review

Tests look good

This could use an issue summary though for what the message was updated to and why. Current IS mentions accessibility issue but how does this now pass?

This is ok to add, but minor indeed. No need for an explicit usability review & signoff. Go for it!

In that case the change looks good and appears correctly.

+++ b/core/modules/field/tests/src/Functional/Email/EmailFieldTest.php
@@ -112,6 +112,15 @@ public function testEmailField() {
+    $value = 'abc.@in';

I'd rather this use 'foo' instead of 'abc' but it has not thrown any spelling errors.

Thanks everyone! Our UI is a wee bit better.