Pre-installed "Archive" view crashes to white screen if invalid date format in context filter

The view should have argument validation added

Unable to reproduce the error.

I'll work on it.

Unassigning the task

I'll look into that.

I found the bug and created the patch to fix it.

Now returns a 404 page.

I just realize that I made a mistake, I will keep working on the bug.

Rectified the following errors,

217 | ERROR | [x] Trailing punctuation for @see references is not
| | allowed.
283 | ERROR | [x] Trailing punctuation for @see references is not
| | allowed.

After tests, I realized that the error happens in file core/modules/views/src/Plugin/views/argument/YearMonthDate.php in title() function:

  public function title() {
    return $this->dateFormatter->format(strtotime($this->argument . "15" . " 00:00:00 UTC"), 'custom', $this->format, 'UTC');
  }

When the title receives a value that is not a valid date, this patch fixes it, but I am not sure if is the correct way.

The previous patch should be removed.

I'll be reviewing.

So, #21 patch worked, no more "white screen of death". I just changed the message to something more understandable.

Hi!

I applied patch in #23 for 9.5.x-dev and works fine, instead of the "white screen of death" I saw a much more elegant "No results" page.

I'm attaching a suggestion to improve code readability. Please, review this.

I'll be doing the review.

Everything is working and now the code is easier to understand.

Would be nice to have this fixed, thanks for getting this closer to commit.

This is changing the user insterface, adding usability tag. The display message needs to be reviewed and the text agreed to.

A before and after screenshot would be helpful, both in the Issue summary, not a comment. The before one should be /archive, not the error message.

There are several steps, or gates, that an issue must pass before it is marked RTBC. For most issues following step 10 in the Review a patch or merge request task of the Contributor guide is sufficient. The complete list of core gates has more topics.

I'll work on this one.

I applied the patch #25 and works fine, the whit screen error is not appearing anymore as you can see on the screenshots above.

And i also changed the error message to "No records found", what do you think?

I added the after and before screenshots in the issue summary.

I'll do the review

I tested the last patch and it stopped the error message to show when trying to access a archive view that doesn't exist. Testing with other view it didn't cause any bug.

I think the message "No records found" is good and simple to understand.

After applying the patch #31 now showing message "No records found"

Shouldn't this error message be translatable? But, as also pointed out in #21, I'm not sure this is the right solution. Shouldn't we fix the root cause of this and fix the offending title() method?

Also, this needs a test.

Maybe we can validate the date format before using strtotime inside the title() method?

We could use a regex like /^[0-9]{4}(0[1-9]|1[0-2])$/, it would returns true for '202209' and false for '20191201', '202013' or 'foo'.

I am wondering: Does that happens only with the Archive view, or does it happen with all the views using that argument handler (which should not accepts values like foobar)?
In the first case, we should check what causes this issue with the Archive view. In the latter case, it's clearly the argument handler that needs to be fixed.

In both the cases, validating the value in title() would be too late, and it won't fix other issues.

I take that the argument handler for the Archive view is the YearMonthDate class, which uses the following code in YearMonthDate::title().

  return $this->dateFormatter->format(strtotime($this->argument . "15" . " 00:00:00 UTC"), 'custom', $this->format, 'UTC');

Effectively, that code expects $this->argument to contain the correct value, but it's not its task to check the received argument is valid, since argument handlers have a validateArgument().

This is the code used by ArgumentPluginBase::validateArgument().

  // By using % in URLs, arguments could be validated twice; this eases
  // that pain.
  if (isset($this->argument_validated)) {
    return $this->argument_validated;
  }
  if ($this->isException($arg)) {
    return $this->argument_validated = TRUE;
  }
  $plugin = $this->getPlugin('argument_validator');
  return $this->argument_validated = $plugin->validateArgument($arg);
}

None of the argument plugins extends that method.

Either the argument_validator plugin set for the date_year_month argument handler is wrong or it is too permissive on the allowed values.

The issue summary needs to be updated, since it doesn't show the effective error that is causing the WSOD.

I thought it would be strtotime() that throws an exception or a warning when it receives a wrong argument, but that doesn't happen with echo strtotime("foobar15 00:00:00 UTC");.
The output is only different for PHP 4.3.0-4.3.11, 4.4.0-4.4.9, and 5.0.0-5.0.5, which show -1 instead of an empty string.