The D9 release plan for Backup and Migrate is:
- Wait until core 8.8.0 is released.
- Start fixing 9.x compatibility bugs in sub-issues, not in this one.
- Aim to have a release of B&M that is fully compatible with 8.x and 9.x the day that 9.0 is released.
This seems generic because the upgrade from D8 to D9 will be pretty generic for the vast majority of modules.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | Upgrade Status Check.png | 269.46 KB | siramsay |
Comments
Comment #2
damienmckennaComment #3
damienmckennaComment #4
damienmckennaComment #5
amateichuk commented[ERROR] Found 42 errors
Comment #6
amateichuk commentedComment #7
damienmckennaPer the issue summary:
Please collaborate in #3051092: Drupal 9 Deprecated Code Report. Thank you.
Comment #8
amateichuk commentedComment #9
damienmckennaPlease leave this issue open as the parent meta issue for all the D9 code issues.
Comment #10
damienmckennaI've committed a few D9 patches, let's continue in #3051092.
Comment #11
douggreen commentedPsr4ClassLoader is deprecated, with the comment to use composer loader instead. Can we remove the lib directory from the project and just include it with composer?
Comment #12
damienmckennaThe problem is that I don't want to require Composer to install this module, I want people to install it by just downloading the release zip/tgz files without any extra dependencies. So I think it's just going to require renaming & moving the library files.
At this point we're not tied to the library being kept separate (which was the original goal), so we're completely a-ok with shuffling the files around.
Comment #13
douggreen commentedI can certainly move the files in my composer install But I also need to remove the Psr4ClassLoader. If it is removed, will people who don't install with composer be able to load the files? What's your plan for that?
Comment #14
damienmckennaThe plan is to do a new branch and merge all of the BackupMigrate code into the main src directory and shuffle them around; more details in the other issue.
Comment #15
solideogloria commentedIf there's a new branch, is the new standard to drop the "8.x-" in front, since branches can be compatible with more than one version of Drupal Core? That would make the new branch 5.0.0. See Search API Solr for an example.
Comment #16
damienmckenna@solideogloria: Correct, that's my intention.
Comment #17
damienmckennaI've committed the main issue, and have created a 5.0.x-dev snapshot, all that's left is a 5.0.0 release.
Comment #18
mrpauldriver commentedFiltering the issue queue with the 'Drupal 9 compatibility' tag does not return many sub-issues.
It would be helpful know what the sub-issues are, so as to make it easier monitor progress.
Comment #19
damienmckennaAt this point the 5.0.x codebase should be compatible, all focus should be on the 5.0.0 release. On Monday I have a little more fiddling to do on the coding standards fixes, then I'll do an rc.
Comment #20
mrpauldriver commentedThanks Damien. Upgraded, no errors. Great
Comment #21
siramsay commentedThanks Damien, I upgraded with no errors. I have tested download and save to private directory.
One warning I got using Upgrade status was HttpClientInterface. I am unsure how this is used and doesn't seem to affect the project with the above-mentioned tests. I have added the screen capture.
notes:
HttpClientInterfacetoHTTPClientInterfaceand the error was gone. I can provide the patch if this is infact a problem.On a site that is served from a sub-directory but not redirected, the warning was not present. Everything else the same.
As I said I don't know how this interface is used so unsure if it should be fixed.
Let me know if you need any more info or if I could test some functionality related to this.
Comment #22
damienmckennaPlease open new issues for any problems you run into. Thank you.
Comment #23
damienmckennaFYI I released 5.0.0-rc1 today, which I manually testing against D9.
Comment #24
solideogloria commentedComment #25
siramsay commentedDamien, okay can do but unsure is this is an issue worth reporting as I don't know if the interface is used and/or how it is used.
Comment #26
damienmckenna@siramsay: This issue is done, any further discussions need to be in a separate issue, if there isn't already one that mentions the problem you've found.