The D9 release plan for Backup and Migrate is:

  • Wait until core 8.8.0 is released.
  • Start fixing 9.x compatibility bugs in sub-issues, not in this one.
  • Aim to have a release of B&M that is fully compatible with 8.x and 9.x the day that 9.0 is released.

This seems generic because the upgrade from D8 to D9 will be pretty generic for the vast majority of modules.

CommentFileSizeAuthor
#21 Upgrade Status Check.png269.46 KBsiramsay
#6 backup_migrate-3092547-6.patch18.47 KBamateichuk

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Drupal 9 compatibility
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Drupal 9 release plan for Backup Migrate » Drupal 9 release plan for Backup and Migrate
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
amateichuk’s picture

amateichuk commented

[ERROR] Found 42 errors

amateichuk’s picture

amateichuk commented
StatusFileSize
new backup_migrate-3092547-6.patch18.47 KB
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Per the issue summary:

Start fixing 9.x compatibility bugs in sub-issues, not in this one.

Please collaborate in #3051092: Drupal 9 Deprecated Code Report. Thank you.

amateichuk’s picture

amateichuk commented
Status: Active » Closed (duplicate)
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Closed (duplicate) » Active

Please leave this issue open as the parent meta issue for all the D9 code issues.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've committed a few D9 patches, let's continue in #3051092.

douggreen’s picture

douggreen commented

Psr4ClassLoader is deprecated, with the comment to use composer loader instead. Can we remove the lib directory from the project and just include it with composer?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The problem is that I don't want to require Composer to install this module, I want people to install it by just downloading the release zip/tgz files without any extra dependencies. So I think it's just going to require renaming & moving the library files.

At this point we're not tied to the library being kept separate (which was the original goal), so we're completely a-ok with shuffling the files around.

douggreen’s picture

douggreen commented

I can certainly move the files in my composer install But I also need to remove the Psr4ClassLoader. If it is removed, will people who don't install with composer be able to load the files? What's your plan for that?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The plan is to do a new branch and merge all of the BackupMigrate code into the main src directory and shuffle them around; more details in the other issue.

solideogloria’s picture

solideogloria commented

If there's a new branch, is the new standard to drop the "8.x-" in front, since branches can be compatible with more than one version of Drupal Core? That would make the new branch 5.0.0. See Search API Solr for an example.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@solideogloria: Correct, that's my intention.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've committed the main issue, and have created a 5.0.x-dev snapshot, all that's left is a 5.0.0 release.

mrpauldriver’s picture

mrpauldriver commented

Filtering the issue queue with the 'Drupal 9 compatibility' tag does not return many sub-issues.

It would be helpful know what the sub-issues are, so as to make it easier monitor progress.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Fixed
Parent issue: » #3143649: Plan for Backup and Migrate 5.0.0

At this point the 5.0.x codebase should be compatible, all focus should be on the 5.0.0 release. On Monday I have a little more fiddling to do on the coding standards fixes, then I'll do an rc.

mrpauldriver’s picture

mrpauldriver commented

Thanks Damien. Upgraded, no errors. Great

siramsay’s picture

siramsay commented
StatusFileSize
new Upgrade Status Check.png269.46 KB

Thanks Damien, I upgraded with no errors. I have tested download and save to private directory.

One warning I got using Upgrade status was HttpClientInterface. I am unsure how this is used and doesn't seem to affect the project with the above-mentioned tests. I have added the screen capture.

notes:

  • this only happened on an install that I am serving from a subdirectory using .htaccess to remotve the directory and serve the site from the top-level domain name. (unsure if this should matter though)
  • I patched the interface name HttpClientInterface to HTTPClientInterface and the error was gone. I can provide the patch if this is infact a problem.

On a site that is served from a sub-directory but not redirected, the warning was not present. Everything else the same.

As I said I don't know how this interface is used so unsure if it should be fixed.

Let me know if you need any more info or if I could test some functionality related to this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Please open new issues for any problems you run into. Thank you.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

FYI I released 5.0.0-rc1 today, which I manually testing against D9.

solideogloria’s picture

solideogloria commented
Version: 8.x-4.x-dev » 5.0.x-dev
siramsay’s picture

siramsay commented

Damien, okay can do but unsure is this is an issue worth reporting as I don't know if the interface is used and/or how it is used.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@siramsay: This issue is done, any further discussions need to be in a separate issue, if there isn't already one that mentions the problem you've found.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.