Add capability to create recurrences by set amount of time

I will patch development version: 8.x-1.x-dev updated 18 Oct 2019 at 22:23 UTC

I'll list my findings in separate posts to this issue.

BUG/FEATURE: On my first test I overlooked the duration default setting (in seconds) and ended up with an Internal Server Error after 1801 x 1 second consecutive instances had been created. I'm guessing this is a hard limit, a memory thing or a timeout. Whatever it was, wasn't helpful as it resulted in WSOD.

With the potential for unlimited recurrences in a series, all of which have to be generated, this will likely cause problems. So how about capping the number of consecutive instances with a hard limit?

Assuming the most likely use case of event bookings.
- 1440 (1 minute slots in a day) But why would anybody want this?
- 1024 (hinting at a technical limitation)
- 100 (small round number)
- 1000 (big round number)
- 288 (5 minute slots in a day) But why?
- 168 (hours in a week) But why?

Alternatively, generate a fixed number and then add to this incrementally via a batch process. But this sounds like over-engineered development for the sake of it

I like the round number idea. It is clear and unambiguous.

Until that is, until someone comes along, thinking this would make a neat appointments system linked to office hours. But that's another issue.

UI: Event buffer should have a default value of zero. It is easy to ignore if a buffer is not required and causes a form validation error if not completed.

TASK: The form validation message "This value should be of the correct primitive type." is somewhat cryptic. This needs humanizing.

DISCUSS: Further to #9. Unless we are saying that a recurring event is something other than a thing that people would observe, attend or participate in. I'm not sure that having event durations in seconds is a good idea. What might be the use case for this?

What is the smallest granularity for an event for which people might want to register for? For my use case (school parent evening) this would be five minutes or more.

Others might have different ideas. A one minute speed date perhaps?

BUG: Consecutive and Daily date settings are not preserved when editing a series.

Steps to reproduce.
1. Create a series
2. Edit the series
3. The date inputs are blank
4. Attempting to re-save results in WSOD

BUG: An invalid form validation error occurs (for the consecutive recur type) when saving an event using a different recur type.

I am guessing the consecutive event form inputs are not disabled when a different recur type is selected

Steps to reproduce.
1. Enable Consecutive Event Recur Field Types and at least one other
2. Create an event using one of the other recur types
3. Save the event
4. Form validation occurs, but not for the currently selected recur type
5. The error belongs to the unselected consecutive event recur type

Screenshots attached. Please note, my UI is customised with field groups and tabs.

Overall this looks very promising. Thank you for working on this Owen.

Applied patch and got this error on page /events/add

The website encountered an unexpected error. Please try again later.</br></br><em class="placeholder">Drupal\Component\Plugin\Exception\PluginNotFoundException</em>: The &quot;eventseries&quot; entity type does not exist. in <em class="placeholder">Drupal\Core\Entity\EntityTypeManager-&gt;getDefinition()</em> (line <em class="placeholder">150</em> of <em class="placeholder">core/lib/Drupal/Core/Entity/EntityTypeManager.php</em>). <pre class="backtrace">Drupal\Core\Entity\EntityTypeManager-&gt;getHandler(&#039;eventseries&#039;, &#039;access&#039;) (Line: 264)
Drupal\Core\Entity\EntityTypeManager-&gt;getAccessControlHandler(&#039;eventseries&#039;) (Line: 82)
Drupal\Core\Entity\EntityCreateAccessCheck-&gt;access(Object, Object, Object)
call_user_func_array(Array, Array) (Line: 159)
Drupal\Core\Access\AccessManager-&gt;performCheck(&#039;access_check.entity_create&#039;, Object) (Line: 135)
Drupal\Core\Access\AccessManager-&gt;check(Object, Object, Object, 1) (Line: 112)
Drupal\Core\Access\AccessManager-&gt;checkRequest(Object, Object, 1) (Line: 109)
Drupal\Core\Routing\AccessAwareRouter-&gt;checkAccess(Object) (Line: 94)
Drupal\Core\Routing\AccessAwareRouter-&gt;matchRequest(Object) (Line: 113)
Symfony\Component\HttpKernel\EventListener\RouterListener-&gt;onKernelRequest(Object, &#039;kernel.request&#039;, Object)
call_user_func(Array, Object, &#039;kernel.request&#039;, Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher-&gt;dispatch(&#039;kernel.request&#039;, Object) (Line: 127)
Symfony\Component\HttpKernel\HttpKernel-&gt;handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel-&gt;handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle-&gt;handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache-&gt;pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache-&gt;handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware-&gt;handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware-&gt;handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel-&gt;handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel-&gt;handle(Object) (Line: 19)
</pre>

Ref #16. Ah. No I hadn't updated. Silly of me.

After doing so, problem at #13 is solved.

Problem at #14 persists and I have narrowed this down to consecutive event recur types's duration and buffer not being populated. This probably should not happen, but I expect default values for these two inputs would negate it.

I'll move on the the next patch now.

BTW. I'm not up to speed with interfdiffs and having read the help page, I'm not sure whether I can apply this on top on the existing patch or whether to remove the old one and apply the new. In the meantime I'll experiment, but it would help me if you could clarify this gap in my understanding. Actually this just one of many gaps in my understanding;-)

----
Edit: I just re-read the help page again and the passage below clarifies the correct usage.

What am I supposed to do with another user's interdiff?
Nothing, other than read it. Interdiffs are for developers and reviewers working on a patch, not for sitebuilders using the patches. They help to easily see the differences between two versions of a patch.

@the_glitch The second patch applied cleanly for me. I did remove the first patch beforehand.

Default settings for duration and buffer work well and fix the bug mention at #14.

The event threshold works nicely, but I found it slightly confusing. I got the impression that I could have a warning with the option to continue, but this was not the case and it me proceed without seeing a warning. Server error follows. Is this a bug or working as designed?

Threshold Prevent Save checkbox works well. Would this be better if enabled by default?

Body field is still mandatory.

@MrPaulDriver I hadn't applied either of the first 2 patches before. Patch #17 is the only one I've tried.

I've installed patch 24 and confirm that the message is displayed when editing an existing series, but I'm still not seeing this for new event series. Nothing coming in via ajax is observed. Screenshots attached.

When this is working, I think visibility of the message might remain be a problem. In the case of an existing series, I think the message should be duplicated along with the dialogue to confirm date changes, because this is where the the site editor's eye will be drawn

<h2>Confirm Date Changes</h2>
<p>Recurrence configuration has been changed, as a result all instances will be removed and recreated. This action cannot be undone.</p>
<p><strong>Saving this series will create up to 1547 event instances. This could result in memory exhaustion or site instability.</strong><p>

Just reviewing my last post and wondering what would happen to pre-existing registrations in the event of;

Recurrence configuration has been changed, as a result all instances will be removed and recreated. This action cannot be undone.

@owen yes i realised composer had deleted the module again so I ran require again then got a different error on /events/add
This error also happens with patch #24.

The website encountered an unexpected error. Please try again later.
TypeError: Argument 5 passed to Drupal\recurring_events\EventCreationService::__construct() must be an instance of Drupal\Core\Field\FieldTypePluginManager, instance of Drupal\Core\Datetime\DateFormatter given, called in /Users/darrenmoves/Sites/My Suite/core/lib/Drupal/Component/DependencyInjection/Container.php on line 285 in Drupal\recurring_events\EventCreationService->__construct() (line 79 of modules/contrib/recurring_events/src/EventCreationService.php).
Drupal\recurring_events\EventCreationService->__construct(Object, Object, Object, Object, Object) (Line: 285)
Drupal\Component\DependencyInjection\Container->createService(Array, 'recurring_events.event_creation_service') (Line: 173)
Drupal\Component\DependencyInjection\Container->get('recurring_events.event_creation_service') (Line: 77)
Drupal\recurring_events\Form\EventSeriesForm::create(Object) (Line: 28)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition('Drupal\recurring_events\Form\EventSeriesForm') (Line: 226)
Drupal\Core\Entity\EntityTypeManager->getFormObject('eventseries', 'add') (Line: 82)
Drupal\Core\Entity\HtmlEntityFormController->getFormObject(Object, 'eventseries.add.default') (Line: 78)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I flushed caches and the error is fixed but now the 'Recur Type' field has disappeared.

I ran drush updb then drush cr and it's still the same. No 'Recur Type' field.
Terminal is saying: Drupal\Component\Plugin\Exception\PluginNotFoundException: The "weekly" plugin does not exist. Valid [error]

Patch #24 applied after having to delete the all series nodes that were causing a 'Weekly' plugin error when drush updb.

Now 'Inline Entity Form - Complex' fields in Event Series don't work.

Patch #24 applied after having to delete the all series nodes that were causing a 'Weekly" plugin error when drush updb.

All 'Recur Types' are now in the form and functioning but has now created a bug with 'Inline Entity Form - Complex' fields in Event Series causing the IEF-Complex 'Add Existing Node' and 'Add New Node' buttons to not work due to what seems to be an AJAX error each time those buttons are clicked that all says this:

"An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /events/add?ajax_form=1
StatusText: 500 Service unavailable (with message)
ResponseText: The website encountered an unexpected error. Please try again later.InvalidArgumentException: The date cannot be created from a format. in Drupal\Component\Datetime\DateTimePlus::createFromFormat() (line 248 of core/lib/Drupal/Component/Datetime/DateTimePlus.php). Drupal\recurring_events\Plugin\Field\FieldType\ConsecutiveRecurringDate::convertFormConfigToArray(Object) (Line: 188)
Drupal\recurring_events\Plugin\Field\FieldWidget\ConsecutiveRecurringDateWidget->checkDuration(Object) (Line: 110)
Drupal\recurring_events\Plugin\Field\FieldWidget\ConsecutiveRecurringDateWidget->formElement(Object, 0, Array, Array, Object) (Line: 335)
Drupal\Core\Field\WidgetBase->formSingleElement(Object, 0, Array, Array, Object) (Line: 202)
Drupal\Core\Field\WidgetBase->formMultipleElements(Object, Array, Object) (Line: 104)
Drupal\Core\Field\WidgetBase->form(Object, Array, Object) (Line: 177)
Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object, Array, Object) (Line: 125)
Drupal\Core\Entity\ContentEntityForm->form(Array, Object) (Line: 117)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object) (Line: 119)
Drupal\recurring_events\Form\EventSeriesForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 519)
Drupal\Core\Form\FormBuilder->retrieveForm('eventseries_add_form', Object) (Line: 369)
Drupal\Core\Form\FormBuilder->rebuildForm('eventseries_add_form', Object, Array) (Line: 626)
Drupal\Core\Form\FormBuilder->processForm('eventseries_add_form', Array, Object) (Line: 319)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 93)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
"

Ref #27. Cache cleared but still not seeing the ajax warning.

do you have any inline_entity_form fields in Series? If not, install the inline_entity_form module and add an entity reference field and in Manage Form Display use the 'Inline Entity Form - Complex' widget and you'll probably get the same issue.

Yeh I wasn't sure if to raise a separate issue or not because the problem only started after applying the patch in this issue.

Tested and working with IEF. Thank you

With patch #39 . Still not seeing ajax warning when 'Event Instance Threshold Prevent Save' is not checked.

I did have some field groups on the node form and had similar thoughts myself. After getting rid of them I still don't see the ajax warning. I have also uninstalled, reinstalled.

Please could you post a screenshot of what I should be seeing? Bartik theme.

Sorry, it's not present. Nor is it seen for a completely fresh installation on simplytest.me See screenshot attached

Patched with https://www.drupal.org/files/issues/2019-10-30/recurring_events-daily_co...

I now see a warning in the date range area when first creating an extended series, and also in the confirmation area when extending an existing series.

Looks good to me.

One small inconsistency. The form order is different for consecutive events with the radios appearing below the date range. With other recurrence types the radios appear above.

Please see screenshots.

Sorry, Dreditor embeds screenshot in opening post. Must figure out how to avoid that

Tested on my patched local, but also seen on simplytest.me

#56 Fixed. Big job, done well. Marking RTBC.

I am now left wondering whether consecutive slots can be plugged into to the other recurrence types? For example; recurring 30min slots, between 9am and 5pm, Monday-Friday. #appointment_system

I don't think I will be needing the extra functionality, but would not be surprised if others did and I agree it should be another issue.