Page not found when a node is deleted via contextual filter

'destination' parameter comes from function initContextual() in file core/modules/contextual/js/contextual.js

    var destination = 'destination=' + Drupal.encodePath(Drupal.url(drupalSettings.path.currentPath));
    $contextual.find('.contextual-links a').each(function () {
      var url = this.getAttribute('href');
      var glue = url.indexOf('?') === -1 ? '?' : '&';
      this.setAttribute('href', url + glue + destination);
    });

my approach to solve this problem is by skipping the 'destination' parameter for links with pattern 'node/%/delete'

Patch works for me.

Re-rolled #4 for 9.4

#11 working for me on local 9.4.Tested and Verified.refer Screenshot.

I can confirm this issue still exists in 10.1

This will need some tests to make sure it's fixed.

Rerolled for 10.1.x.
But the issue on #15 still needs to be addressed.

+++ b/core/modules/node/tests/src/FunctionalJavascript/ContextualLinksTest.php
@@ -106,6 +106,10 @@ public function testRevisionContextualLinks() {
+    // Confirm that the "Delete" contextual link doesn't contain
+    // the destination parameter.
+    $this->assertStringNotContainsString('?destination=', $links[1]->getAttribute('href'));

I think we can use built in PHP APIs to be a bit more precise here.

Something like this

$query = parse_url($links[1]->getAttribute('href'), PHP_URL_QUERY);
parse_str($query, $parsed_query);
$this->assertArrayNotHasKey('destination', $parsed_query);

+++ b/core/modules/contextual/js/contextual.js
@@ -104,7 +104,12 @@
+      if (url.match(/(node\/\d+\/delete$|node\/\d+\/delete\?.+$)/g) === null) {
+        this.setAttribute('href', url + glue + destination);
+      } else {
+        this.setAttribute('href', url);
+      }

Unfortunately, we can't hardcode node specific logic in contextual module.

What happens if another module has a delete contextual link (e.g. media) and we want similar logic.

So I think we need to go back to the drawing board here.

We need an API to allow an individual link to override its destination.

Firstly, I think we replace the string based concatenation of URL params in contextual.js with UrlSearchParams which is now available in D10 because we don't support IE anymore.

Then I think we should check if the destination is already set before we blindly add it.

Then I think the node contextual link should declare 'options' for the delete plugin, which would be ['query' => ['destination' => '/']]

Something like that anyway. We might take a few iterations to get to a workable API

These seem related.