Contextual delete link results in a 404 due to destination query param

I am working on this issue.

Try with the given patch. It should work now.

Tested patch #3 on 9.1, its working fine
Able to delete contextual link without 404

Applied patch #3 and it works fine. The 'page not found' error is showing after deleting content is gone.
Adding recordings

before patch:

after patch:

Reroll the patch for 9.2.

Moving this to needs review, since that was a random test failure. Again ran the test cases and it was passed.

Added test. Please have a look and let me know if there are any issues.

diff --git a/core/modules/contextual/js/contextual.es6.js b/core/modules/contextual/js/contextual.es6.js
index 12f1405a80..77aa210d02 100644
--- a/core/modules/contextual/js/contextual.es6.js
+++ b/core/modules/contextual/js/contextual.es6.js
@@ -98,11 +98,14 @@
       .prepend(Drupal.theme('contextualTrigger'));
 
     // Set the destination parameter on each of the contextual links.
-    const destination = `destination=${Drupal.encodePath(
-      Drupal.url(drupalSettings.path.currentPath),
-    )}`;
     $contextual.find('.contextual-links a').each(function () {
       const url = this.getAttribute('href');
+      if (url.indexOf("delete") >= 0 && url.indexOf("node" ) >= 0){
+        const destination = 'destination=' + Drupal.encodePath(drupalSettings.path.baseUrl);
+      }
+      else {
+        const destination = 'destination=' + Drupal.encodePath(Drupal.url(drupalSettings.path.currentPath));
+      }
       const glue = url.indexOf('?') === -1 ? '?' : '&';
       this.setAttribute('href', url + glue + destination);
     });

This patch only will work with Node entities, but we have the problem with Group entities. Must it be more generic?

The correct way may be always to send to the base path in 'Delete' links?

Replacing:

if (url.indexOf("delete") >= 0 && url.indexOf("node" ) >= 0){
  const destination = 'destination=' + Drupal.encodePath(drupalSettings.path.baseUrl);
}
else {
  const destination = 'destination=' + Drupal.encodePath(Drupal.url(drupalSettings.path.currentPath));
}

With:

if (url.indexOf("delete") >= 0){
  const destination = 'destination=' + Drupal.encodePath(drupalSettings.path.baseUrl);
}

Updated CS and indentation issues.

Hmm, hardcoding the 'delete' is a brittle kitten-killer. We might instead look for, say, a "no-destination" query parameter in the link.

I don't think it's the right approach to simply change the destination parameter of all contextual links with "node" and "delete" in the URL. It might be better to remove the destination for delete links if the current route matches any of the link templates for the entity in context. The destination parameter should remain if the entity is embedded on another page. It's also worth considering what happens with the cancel button on the confirm form, it points to the destination parameter with a fallback to the entity's canonical route.

An alternative approach would be to leave the destination parameter in place and move this logic to the submit handler of the confirm form. If the destination will result in a 404 due to the entity being deleted then the destination should be removed.

Agree with what @mstrelan said in #22, those seem like approaches worth exploring