When garbage collection successfully deleted a temporary file, It should log a message for the admin to aware of.
Also sort the query by "changed" field in DESC (Descending order), this will help to eliminate a situation when a large amount of files to delete and the delete process can't process the newest temporary files. This change will start the delete process from the newest temporary file.

CommentFileSizeAuthor
#15 3061640-15.patch524 bytesranjith_kumar_k_u
#14 3061640-nr-bot.txt144 bytesneeds-review-queue-bot
#11 interdiff-10_11.txt537 bytesgauravvvv
#11 3061640-11.patch503 bytesgauravvvv
#10 3061640-9.patch506 bytesranjith_kumar_k_u
#2 3061640-1-add-log-message-to-deleted-file.patch985 bytesfinaukaufusi

Comments

finaukaufusi created an issue. See original summary.

finaukaufusi’s picture

finaukaufusi
Primary language English
Location Sydney
commented
Issue summary: View changes
StatusFileSize
new 3061640-1-add-log-message-to-deleted-file.patch985 bytes
cilefen’s picture

cilefen commented
Version: 8.4.x-dev » 8.8.x-dev
Status: Active » Needs review

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented

.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 3061640-9.patch506 bytes

Re-rolled #2 for 9.4. The log message code is already there, I just added the sort condition.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3061640-11.patch503 bytes
new interdiff-10_11.txt537 bytes

Fixed phpcs issue, Attached interdiff for same. Please review.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3061640-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 3061640-15.patch524 bytes

Re-rolled #11

error: patch failed: core/modules/file/file.module:650
error: core/modules/file/file.module: patch does not apply

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests, +Needs issue summary update

Even though this is a task it seems like it will need test coverage.

gauravvvv’s picture

gauravvvv commented

Updating attributions

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.