Unable to update Drupal 8.6 to Drupal 8.7 -- error in webform_views [#3052056]

ubuntu@www-example-com /var/www/www-example-com $ composer update --with-dependencies
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 4 installs, 2 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing pear/pear_exception (v1.0.0): Downloading (100%)
- Installing pear/console_getopt (v1.4.2): Downloading (100%)
- Installing pear/pear-core-minimal (v1.10.9): Downloading (100%)
- Installing pear/archive_tar (1.4.7): Downloading (100%)
- Updating egulias/email-validator (1.2.15 => 2.1.7): Downloading (100%)
- Updating drupal/core (8.6.15 => 8.7.0): Downloading (100%)
- Applying patches for drupal/core
https://www.drupal.org/files/issues/fetch_user_id_from_route_for_all-290... (Fetch User ID from route context views contextual filter for any entity)

pear/archive_tar suggests installing ext-bz2 (Bz2 compression support.)
pear/archive_tar suggests installing ext-xz (Lzma2 compression support.)
Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.
Writing lock file
Generating autoload files
- .csslintrc (https://git.drupalcode.org/project/drupal/raw/8.7.0/.csslintrc): Downloading (100%)
- .editorconfig (https://git.drupalcode.org/project/drupal/raw/8.7.0/.editorconfig): Downloading (100%)
- .eslintignore (https://git.drupalcode.org/project/drupal/raw/8.7.0/.eslintignore): Downloading (100%)
- .eslintrc.json (https://git.drupalcode.org/project/drupal/raw/8.7.0/.eslintrc.json): Downloading (100%)
- .gitattributes (https://git.drupalcode.org/project/drupal/raw/8.7.0/.gitattributes): Downloading (100%)
- .ht.router.php (https://git.drupalcode.org/project/drupal/raw/8.7.0/.ht.router.php): Downloading (100%)
- .htaccess (https://git.drupalcode.org/project/drupal/raw/8.7.0/.htaccess): Downloading (100%)
- index.php (https://git.drupalcode.org/project/drupal/raw/8.7.0/index.php): Downloading (100%)
- robots.txt (https://git.drupalcode.org/project/drupal/raw/8.7.0/robots.txt): Downloading (100%)
- sites/default/default.services.yml (https://git.drupalcode.org/project/drupal/raw/8.7.0/sites/default/defaul...): DownloadingDownloading (100%)
- sites/default/default.settings.php (https://git.drupalcode.org/project/drupal/raw/8.7.0/sites/default/defaul...): DownloadingDownloading (100%)
- sites/development.services.yml (https://git.drupalcode.org/project/drupal/raw/8.7.0/sites/development.se...): Downloading (connecDownloading (100%)
- sites/example.settings.local.php (https://git.drupalcode.org/project/drupal/raw/8.7.0/sites/example.settin...): Downloading (coDownloading (100%)
- sites/example.sites.php (https://git.drupalcode.org/project/drupal/raw/8.7.0/sites/example.sites.php): Downloading (100%)
- update.php (https://git.drupalcode.org/project/drupal/raw/8.7.0/update.php): Downloading (100%)
- web.config (https://git.drupalcode.org/project/drupal/raw/8.7.0/web.config): Downloading (100%)
> DrupalProject\composer\ScriptHandler::createRequiredFiles
ubuntu@www-example-com /var/www/www-example-com $ composer update --with-dependencies
Gathering patches for root package.
> DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
> DrupalProject\composer\ScriptHandler::createRequiredFiles
ubuntu@www-example-com /var/www/www-example-com $ drush updatedb
-------------------- ----------------- --------------- -----------------------
Module Update ID Type Description
-------------------- ----------------- --------------- -----------------------
system 8701 hook_update_n Remove the unused
'system.theme.data'
from state.
system 8702 hook_update_n Add the
'revision_translation
_affected' entity
key.
comment 8700 hook_update_n Set the 'owner'
entity key and update
the field.
comment 8701 hook_update_n Make the
'entity_type' and
'field_name' comment
fields required.
content_moderation 8700 hook_update_n Set the 'owner'
entity key and update
the field.
file 8700 hook_update_n Set the 'owner'
entity key and update
the field.
media 8700 hook_update_n Set the 'owner'
entity key and update
the field.
node 8700 hook_update_n Set the 'owner'
entity key and update
the field.
taxonomy 8701 hook_update_n Add an index on the
'taxonomy_term__paren
t' field table.
comment add_ip_address_ post-update Add comment settings.
setting
content_moderation entity_display_ post-update Update the
dependencies dependencies of
entity displays to
include associated
workflow.
content_moderation set_default_mod post-update Set the default
eration_state moderation state for
new content to
'draft'.
content_moderation set_views_filte post-update Set the filter on the
r_latest_transl moderation view to be
ation_affected_ the latest
revision translation affected.
media enable_standalo post-update Keep media items
ne_url viewable at
media{id}.
menu_link_content make_menu_link_ post-update Update custom menu
content_revisio links to be
nable revisionable.
system add_expand_all_ post-update Initialize
items_key_in_sy 'expand_all_items'
stem_menu_block values to
system_menu_block.
system clear_menu_cach post-update Clear the menu cache.
e @see
https:www.drupal.orgp
rojectdrupalissues304
4364
taxonomy make_taxonomy_t post-update Update taxonomy terms
erm_revisionabl to be revisionable.
e
taxonomy remove_hierarch post-update Remove the
y_from_vocabula 'hierarchy' property
ries from vocabularies.
views exposed_filter_ post-update Update exposed filter
blocks_label_di blocks label display
splay to be disabled.
views make_placeholde post-update Rebuild cache to
rs_translatable allow placeholder
texts to be
translatable.
-------------------- ----------------- --------------- -----------------------

Do you wish to run the specified pending updates? (yes/no) [yes]:
>

> [notice] Update started: system_update_8701
> [notice] Update completed: system_update_8701
> [notice] Update started: comment_update_8700
> [notice] Update completed: comment_update_8700
> [notice] Update started: system_update_8702
> [notice] Update completed: system_update_8702
> [notice] Update started: comment_update_8701
> [notice] Update completed: comment_update_8701
> [notice] Update started: content_moderation_update_8700
> [notice] Update completed: content_moderation_update_8700
> [notice] Update started: file_update_8700
> [notice] Update completed: file_update_8700
> [notice] Update started: media_update_8700
> [notice] Update completed: media_update_8700
> [notice] Update started: node_update_8700
> [notice] Update completed: node_update_8700
> [notice] Update started: taxonomy_update_8701
> [notice] Update completed: taxonomy_update_8701
> [notice] Update started: comment_post_update_add_ip_address_setting
> [notice] Update completed: comment_post_update_add_ip_address_setting
> [notice] Update started: content_moderation_post_update_entity_display_dependencies
> [notice] Update completed: content_moderation_post_update_entity_display_dependencies
> [notice] Update started: content_moderation_post_update_entity_display_dependencies
> [notice] Update completed: content_moderation_post_update_entity_display_dependencies
> [notice] Update started: content_moderation_post_update_entity_display_dependencies
> [notice] Update completed: content_moderation_post_update_entity_display_dependencies
> [notice] Update started: content_moderation_post_update_set_default_moderation_state
> [notice] Update completed: content_moderation_post_update_set_default_moderation_state
> [notice] Update started: content_moderation_post_update_set_views_filter_latest_translation_affected_revision
> [notice] Update completed: content_moderation_post_update_set_views_filter_latest_translation_affected_revision
> [notice] Update started: media_post_update_enable_standalone_url
> [notice] Update completed: media_post_update_enable_standalone_url
> [notice] Update started: menu_link_content_post_update_make_menu_link_content_revisionable
> ArgumentCountError: Too few arguments to function Drupal\views\Plugin\views\filter\StringFilter::__construct(), 3 passed in /var/www/www-example-com/web/modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionWebformCategory.php on line 36 and exactly 4 expected in /var/www/www-example-com/web/core/modules/views/src/Plugin/views/filter/StringFilter.php on line 47 #0 /var/www/www-example-com/web/modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionWebformCategory.php(36): Drupal\views\Plugin\views\filter\StringFilter->__construct(Array, 'webform_views_w...', Array)
> #1 /var/www/www-example-com/web/modules/contrib/webform_views/src/Plugin/views/filter/WebformSubmissionWebformCategory.php(49): Drupal\webform_views\Plugin\views\filter\WebformSubmissionWebformCategory->__construct(Array, 'webform_views_w...', Array, Object(Drupal\Core\Entity\EntityTypeManager))
> #2 /var/www/www-example-com/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php(21): Drupal\webform_views\Plugin\views\filter\WebformSubmissionWebformCategory::create(Object(Drupal\Core\DependencyInjection\ContainerBuilder), Array, 'webform_views_w...', Array)
> #3 /var/www/www-example-com/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php(76): Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('webform_views_w...', Array)
> #4 /var/www/www-example-com/web/core/modules/views/src/Plugin/ViewsHandlerManager.php(121): Drupal\Component\Plugin\PluginManagerBase->createInstance('webform_views_w...', Array)
> #5 /var/www/www-example-com/web/core/modules/views/src/Plugin/ViewsHandlerManager.php(106): Drupal\views\Plugin\ViewsHandlerManager->createInstance('webform_views_w...', Array)
> #6 /var/www/www-example-com/web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(889): Drupal\views\Plugin\ViewsHandlerManager->getHandler(Array, NULL)
> #7 /var/www/www-example-com/web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(923): Drupal\views\Plugin\views\display\DisplayPluginBase->getHandlers('filter')
> #8 /var/www/www-example-com/web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(959): Drupal\views\Plugin\views\display\DisplayPluginBase->getAllHandlers(true)
> #9 /var/www/www-example-com/web/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php(75): Drupal\views\Plugin\views\display\DisplayPluginBase->calculateDependencies()
> #10 /var/www/www-example-com/web/core/lib/Drupal/Core/Plugin/PluginDependencyTrait.php(93): Drupal\Core\Config\Entity\ConfigEntityBase->getPluginDependencies(Object(Drupal\views\Plugin\views\display\DefaultDisplay))
> #11 /var/www/www-example-com/web/core/modules/views/src/Entity/View.php(290): Drupal\Core\Config\Entity\ConfigEntityBase->calculatePluginDependencies(Object(Drupal\views\Plugin\views\display\DefaultDisplay))
> #12 /var/www/www-example-com/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(319): Drupal\views\Entity\View->calculateDependencies()
> #13 /var/www/www-example-com/web/core/modules/views/src/Entity/View.php(300): Drupal\Core\Config\Entity\ConfigEntityBase->preSave(Object(Drupal\Core\Config\Entity\ConfigEntityStorage))
> #14 /var/www/www-example-com/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(490): Drupal\views\Entity\View->preSave(Object(Drupal\Core\Config\Entity\ConfigEntityStorage))
> #15 /var/www/www-example-com/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(445): Drupal\Core\Entity\EntityStorageBase->doPreSave(Object(Drupal\views\Entity\View))
> #16 /var/www/www-example-com/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php(263): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\views\Entity\View))
> #17 /var/www/www-example-com/web/core/lib/Drupal/Core/Entity/EntityBase.php(394): Drupal\Core\Config\Entity\ConfigEntityStorage->save(Object(Drupal\views\Entity\View))
> #18 /var/www/www-example-com/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(613): Drupal\Core\Entity\EntityBase->save()
> #19 /var/www/www-example-com/web/core/modules/views/src/EventSubscriber/ViewsEntitySchemaSubscriber.php(202): Drupal\Core\Config\Entity\ConfigEntityBase->save()
> #20 /var/www/www-example-com/web/core/lib/Drupal/Core/Entity/EntityTypeEventSubscriberTrait.php(47): Drupal\views\EventSubscriber\ViewsEntitySchemaSubscriber->onEntityTypeUpdate(Object(Drupal\Core\Entity\ContentEntityType), Object(Drupal\Core\Entity\ContentEntityType))
> #21 [internal function]: Drupal\views\EventSubscriber\ViewsEntitySchemaSubscriber->onEntityTypeEvent(Object(Drupal\Core\Entity\EntityTypeEvent), 'entity_type.def...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
> #22 /var/www/www-example-com/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Drupal\Core\Entity\EntityTypeEvent), 'entity_type.def...', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
> #23 /var/www/www-example-com/web/core/lib/Drupal/Core/Entity/EntityTypeListener.php(138): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('entity_type.def...', Object(Drupal\Core\Entity\EntityTypeEvent))
> #24 /var/www/www-example-com/web/core/lib/Drupal/Core/Entity/EntityDefinitionUpdateManager.php(229): Drupal\Core\Entity\EntityTypeListener->onFieldableEntityTypeUpdate(Object(Drupal\Core\Entity\ContentEntityType), Object(Drupal\Core\Entity\ContentEntityType), Array, Array, Array)
> #25 /var/www/www-example-com/web/core/modules/menu_link_content/menu_link_content.post_update.php(100): Drupal\Core\Entity\EntityDefinitionUpdateManager->updateFieldableEntityType(Object(Drupal\Core\Entity\ContentEntityType), Array, Array)
> #26 /var/www/www-example-com/vendor/drush/drush/src/Commands/core/UpdateDBCommands.php(289): menu_link_content_post_update_make_menu_link_content_revisionable(Array)
> #27 /var/www/www-example-com/vendor/drush/drush/includes/batch.inc(251): Drush\Commands\core\UpdateDBCommands::updateDoOnePostUpdate('menu_link_conte...', Object(DrushBatchContext))
> #28 /var/www/www-example-com/vendor/drush/drush/includes/batch.inc(196): _drush_batch_worker()
> #29 /var/www/www-example-com/vendor/drush/drush/includes/batch.inc(99): _drush_batch_command('16103')
> #30 /var/www/www-example-com/vendor/drush/drush/src/Commands/core/UpdateDBCommands.php(155): drush_batch_command('16103')
> #31 [internal function]: Drush\Commands\core\UpdateDBCommands->process('16103', Array)
> #32 /var/www/www-example-com/vendor/consolidation/annotated-command/src/CommandProcessor.php(257): call_user_func_array(Array, Array)
> #33 /var/www/www-example-com/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object(Consolidation\AnnotatedCommand\CommandData))
> #34 /var/www/www-example-com/vendor/consolidation/annotated-command/src/CommandProcessor.php(176): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
> #35 /var/www/www-example-com/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(302): Consolidation\AnnotatedCommand\CommandProcessor->process(Object(Symfony\Component\Console\Output\ConsoleOutput), Array, Array, Object(Consolidation\AnnotatedCommand\CommandData))
> #36 /var/www/www-example-com/vendor/symfony/console/Command/Command.php(255): Consolidation\AnnotatedCommand\AnnotatedCommand->execute(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> #37 /var/www/www-example-com/vendor/symfony/console/Application.php(978): Symfony\Component\Console\Command\Command->run(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> #38 /var/www/www-example-com/vendor/symfony/console/Application.php(255): Symfony\Component\Console\Application->doRunCommand(Object(Consolidation\AnnotatedCommand\AnnotatedCommand), Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> #39 /var/www/www-example-com/vendor/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Drush\Symfony\DrushArgvInput), Object(Symfo> ny\Component\Console\Output\ConsoleOutput))
> #40 /var/www/www-example-com/vendor/drush/drush/src/Runtime/Runtime.php(118): Symfony\Component\Console\Application->run(Object(Drush\Symfony\DrushArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
> #41 /var/www/www-example-com/vendor/drush/drush/src/Runtime/Runtime.php(49): Drush\Runtime\Runtime->doRun(Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
> #42 /var/www/www-example-com/vendor/drush/drush/drush.php(72): Drush\Runtime\Runtime->run(Array)
> #43 /var/www/www-example-com/vendor/drush/drush/includes/preflight.inc(18): require('/var/www/www-s1...')
> #44 phar:///usr/local/bin/drush/bin/drush.php(141): drush_main()
> #45 /usr/local/bin/drush(10): require('phar:///usr/loc...')
> #46 {main}
> [warning] Drush command terminated abnormally. Check for an exit() in your Drupal site.

In ProcessBase.php line 184:

Unable to decode output into JSON.

ubuntu@www-example-com /var/www/www-example-com $ drush updatedb
------------------- ----------------- ------------- --------------------------
Module Update ID Type Description
------------------- ----------------- ------------- --------------------------
menu_link_content make_menu_link_ post-update Update custom menu links
content_revisio to be revisionable.
nable
system add_expand_all_ post-update Initialize
items_key_in_sy 'expand_all_items'
stem_menu_block values to
system_menu_block.
system clear_menu_cach post-update Clear the menu cache.
e @see
https:www.drupal.orgproj
ectdrupalissues3044364
taxonomy make_taxonomy_t post-update Update taxonomy terms to
erm_revisionabl be revisionable.
e
taxonomy remove_hierarch post-update Remove the 'hierarchy'
y_from_vocabula property from
ries vocabularies.
views exposed_filter_ post-update Update exposed filter
blocks_label_di blocks label display to
splay be disabled.
views make_placeholde post-update Rebuild cache to allow
rs_translatable placeholder texts to be
translatable.
------------------- ----------------- ------------- --------------------------

Do you wish to run the specified pending updates? (yes/no) [yes]:
>

> [notice] Update started: menu_link_content_post_update_make_menu_link_content_revisionable
> [error] Exception thrown while performing a schema update. Impossible de renommer tmp_8d8440menu_link_content_revision en menu_link_content_revision : la table menu_link_content_revision existe déjà.
> [error] Update failed: menu_link_content_post_update_make_menu_link_content_revisionable
[error] Update aborted by: menu_link_content_post_update_make_menu_link_content_revisionable
[error] Finished performing updates.

Comment	File	Size	Author
#25	3052056-d-8-7-0-25.patch	4.88 KB	bucefal91
#15	core-8.7-update-webform_views-3052056-15.patch	1.69 KB	mikemadison

Comments

Comment #1

1 May 2019 at 23:28

zenimagine created an issue. See original summary.

Comment #2

xjm

she/her

English

commented 2 May 2019 at 00:19

Version:	8.7.0	» 8.7.x-dev
Category:	Support request	» Bug report
Priority:	Normal	» Critical
Issue tags:		+8.7.0 update

Comment #3

xjm

she/her

English

commented 2 May 2019 at 00:24

Title:

Unable to update Drupal 8.6 to Drupal 8.7

» Unable to update Drupal 8.6 to Drupal 8.7; menu_link_content_revision table already exists

Comment #4

larowlan

🇦🇺🏝.au GMT+10

commented 2 May 2019 at 00:28

Priority:	Critical	» Major
Status:	Active	» Postponed (maintainer needs more info)

This is a change in core's string filters that webform will need to mirror.

i.e plugin constructor changes are not part of the API, so dropping to major

Can you confirm you're running the latest version of webform?

I didn't get this in my local testing (4 sites on beta2 all with webform).

If so, you will need to restore your backup after updating webform and try again.

Comment #5

cilefen commented 2 May 2019 at 00:28

The exception has something to do with the webform_views module creating a StringFilter object. StringFilter had a constructor added in #2850037: Replace all calls to db_like(), which is deprecated. Particular plugins are not considered API if I understand it correctly. Neither are constructors considered API.

Comment #6

cilefen commented 2 May 2019 at 00:30

I vote to move this to webform_views queue as a postponed (more info) bug.

Comment #7

xjm

she/her

English

commented 2 May 2019 at 00:33

Title:

Unable to update Drupal 8.6 to Drupal 8.7; menu_link_content_revision table already exists

» Unable to update Drupal 8.6 to Drupal 8.7 -- error in webform_views

Comment #8

zenimagine commented 2 May 2019 at 00:50

I have the latest stable version of Webform Views Integration

Comment #9

larowlan

🇦🇺🏝.au GMT+10

commented 2 May 2019 at 00:59

Project:	Drupal core	» Webform Views
Version:	8.7.x-dev	»
Component:	database update system	» Code
Status:	Postponed (maintainer needs more info)	» Active

Ok, then this issue lies in that module.

One suggested approach to avoid these issues https://www.previousnext.com.au/blog/safely-extending-drupal-8-plugin-cl...

Comment #10

larowlan

🇦🇺🏝.au GMT+10

commented 2 May 2019 at 01:00

Project:	Webform Views	» Webform Views Integration
Version:		» 8.x-5.x-dev

Comment #11

cilefen commented 2 May 2019 at 01:08

@larowlan Incidentally I have to applaud that excellent article as I've foolishly extended a webform core plugin in another module and maintaining it against constructor changes has been a nightmare. I haven't actually done anything yet, but the answers are in the article.

Comment #12

larowlan

🇦🇺🏝.au GMT+10

commented 2 May 2019 at 01:11

All credit to Thomas as I borrowed that technique from search_api

Comment #13

zenimagine commented 2 May 2019 at 10:52

I do not know the development well. The problem is in Drupal Core or in Webform Views Integration ?

Comment #14

cilefen commented 2 May 2019 at 12:43

It is in Webform Views, which is where we have placed the issue.

Comment #15

mikemadison commented 2 May 2019 at 15:09

Status:

Active

» Needs review

Status	File	Size
new	core-8.7-update-webform_views-3052056-15.patch	1.69 KB

I'm hitting this issue as well.

Here's a quick patch that let me move beyond it, just added the missing Connection argument to the constructor. Not sure this is really the "right" solution but it should unblock some people.

Comment #16

xmacinfo

he/him

French

Canada

commented 3 May 2019 at 03:23

I have the same issue when doing a drush updb:

[error]  Placeholders must have a trailing [] if they are to be expanded with an array of values.
[error]  Update failed: menu_link_content_post_update_make_menu_link_content_revisionable

I do not have Webform installed.

Drupal\Core\Database\DatabaseExceptionWrapper : SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AS expression FROM mlfr INNER JOIN mlr ON mlfr. = mlr. AND mlr. = 0 INNER JO' at line 1: SELECT mlfr.id AS id, MAX(mlfr.) AS expression FROM {} mlfr INNER JOIN {} mlr ON mlfr. = mlr. AND mlr. = 0 INNER JOIN (SELECT t.id AS id, t.langcode AS langcode, MAX(t.) AS expression FROM {} t WHERE t. = :db_condition_placeholder_0 GROUP BY t.id, t.langcode) mr ON mlfr. = mr. AND mlfr.langcode = mr.langcode GROUP BY mlfr.id; Array ( [:db_condition_placeholder_0] => 1 ) dans Drupal\menu_link_content\MenuLinkContentStorage->getMenuLinkIdsWithPendingRevisions() (line 41 of /Sites/local.xmacinfo.com/web/core/modules/menu_link_content/src/MenuLinkContentStorage.php).

Using MySQL 5.7.25.

Comment #17

xmacinfo

he/him

French

Canada

commented 3 May 2019 at 03:21

BTW, I think we should change back this issue to Drupal Core.

Comment #18

larowlan

🇦🇺🏝.au GMT+10

commented 3 May 2019 at 03:42

@xmacinfo that sounds like a different issue, can you open a new issue against Drupal core?

Comment #19

larowlan

🇦🇺🏝.au GMT+10

commented 3 May 2019 at 03:43

@xmacinfo or it might be #3052318: Update from 8.6 to 8.7 fails due to corrupt menu_link_content or taxonomy_term entity data

Comment #20

xmacinfo

he/him

French

Canada

commented 3 May 2019 at 03:49

Not sure if I need to open a new Drupal core issue, but here is how I manage to complete the update.

1. Disable Database logging.
2. Run updb (to run the remaining updates, including the one that failed).

$ drush updb
 ------------------- ----------------- ------------- --------------------------
  Module              Update ID         Type          Description
 ------------------- ----------------- ------------- --------------------------
  menu_link_content   make_menu_link_   post-update   Update custom menu links
                      content_revisio                 to be revisionable.
                      nable
  system              add_expand_all_   post-update   Initialize
                      items_key_in_sy                 'expand_all_items'
                      stem_menu_block                 values to
                                                      system_menu_block.
...and 5 others...

Cue taken from:
https://www.drupal.org/project/drupal/issues/2999869#comment-13091480

Comment #21

xmacinfo

he/him

French

Canada

commented 3 May 2019 at 03:55

I did not have the same error as #3052318: Update from 8.6 to 8.7 fails due to corrupt menu_link_content or taxonomy_term entity data. Just the Placeholders must have a trailing [] if they are to be expanded with an array of values error.

Now, why would Database logging prevent that hook_update to complete?

Comment #22

larowlan

🇦🇺🏝.au GMT+10

commented 3 May 2019 at 04:58

Ok thanks xmacinfo, dblog isn't recommend for production environments anyway (due to the performance issue), but glad you sorted it.

There would be an error that the logger is masking, ie. the actual error would be something else

Comment #23

mikemadison commented 3 May 2019 at 14:14

FYI if the patch in #15 gets merged, this module will stop being compatible with Drupal Core < 8.7. So I would suggest that either the module be split into a new version that is for Drupal 8.7+ OR it be updated as recommended in #9 to be less dependent on the specific parent constructor function.

My patch in #15 should be viewed as a stopgap for projects trying to do the 8.7 upgrade now, to give the maintainer time to address the deeper underlying issue(s).

Comment #24

xmacinfo

he/him

French

Canada

commented 3 May 2019 at 14:17

Of course not. I enable Database logging on my development environment, not in production (exept for small sites).

Once I update other Drupal sites to 8.7, I will try to get the error stack and find the actual error (if any).

Comment #25

bucefal91 commented 6 May 2019 at 04:53

Status	File	Size
new	3052056-d-8-7-0-25.patch	4.88 KB

Hey, guys!

I am the maintainer of Webform Views. I definitely agree with the point #23. By the way, I wasn't aware that views plugins may mutate their constructor's signature.

I have put up a patch that follows the idea from #9. Locally I've tested it against 8.6.x and against 8.7.0 - works. I also went through all other Webform Views handlers and found 1 more plugin that was broken in D8.7 - it is taken proper care of in this patch too.

Feel free to test, once I hear at least one or two positive feedbacks, I will commit and will tag a new release.

Comment #26

tip-ok commented 6 May 2019 at 15:55

Hi!

I have applied patch #25 and it seems to work.

Thanks!

Comment #27

amateescu commented 7 May 2019 at 11:17

Status:

Needs review

» Reviewed & tested by the community

The patch looks good to me! It would be nice to get a new release out for compatibility with Drupal 8.7.0 :)

Comment #28

8 May 2019 at 03:55

bucefal91 committed 84c3fa9 on 8.x-5.x

Issue #3052056 by mikemadison, bucefal91: Introducing compatibility with...

Comment #29

bucefal91 commented 8 May 2019 at 03:55

Status:

Reviewed & tested by the community

» Fixed

Sweet, this is committed. Releasing a new version now.

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Unable to update Drupal 8.6 to Drupal 8.7 -- error in webform_views

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

Comment #29

Comment #30

Comment #31

Comment #32

Comment #33

News items

Our community

Documentation

Drupal code base

Governance of community