Upgrade path for Multiupload Filefield Widget and Multiupload Imagefield Widget

Same problem here:

The "file_mfw" plugin does not exist. Valid plugin IDs for Drupal\Core\Field\WidgetPluginManager are: comment_default, datetime_default, datetime_datelist, entity_reference_revisions_autocomplete, field_collection_embed, file_generic, image_image, link_default, oembed_textfield, metatag_firehose, panelizer, path, redirect_source, text_textarea_with_summary, text_textarea, text_textfield, entity_reference_paragraphs, paragraphs, datetime_timestamp, uri, number, boolean_checkbox, email_default, language_select, string_textarea, entity_reference_autocomplete_tags, options_buttons, string_textfield, entity_reference_autocomplete, options_select (/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php:53)

I have the same problem trying to upgrade to Drupal 9.0.7. is there any solution ?

Maybe something like this.

This will need tests and it would help greatly if someone uploaded a file with a database row for each plugin from field_config and field_config_instance. That would be 4 rows in total, then I can write the tests.

Starting over. This adds the field plugin, adds the fields to the d7 fixture and add tests.

Forgot to add the field data tables to the fixture.

is this patch only for D9.2 ?

@nojj, yes, it is. Bugs are fixed on the latest development version and then considered for backporting to earlier versions.

This is actually a task as are all the migrations for legacy functionality that is now in Drupal 8 core. And adding to the relevant Meta.

Woah, nice catch!

This patch looks great to me.

+++ b/core/modules/migrate_drupal/tests/src/Kernel/d7/FieldDiscoveryTest.php
@@ -215,6 +215,14 @@ public function addAllFieldProcessesAltersData() {
                   'entityreference_entity_view' => 'entity_reference_entity_view',
                 ],
+                'file' => [
+                  'default' => 'file_default',
+                  'url_plain' => 'file_url_plain',
+                  'path_plain' => 'file_url_plain',
+                  'image_plain' => 'image',
+                  'image_nodelink' => 'image',
+                  'image_imagelink' => 'image',
+                ],
                 'email' => [
                   'email_formatter_default' => 'email_mailto',
                   'email_formatter_contact' => 'basic_string',
@@ -231,14 +239,6 @@ public function addAllFieldProcessesAltersData() {

@@ -231,14 +239,6 @@ public function addAllFieldProcessesAltersData() {
                 'datetime' => [
                   'date_default' => 'datetime_default',
                 ],
-                'file' => [
-                  'default' => 'file_default',
-                  'url_plain' => 'file_url_plain',
-                  'path_plain' => 'file_url_plain',
-                  'image_plain' => 'image',
-                  'image_nodelink' => 'image',
-                  'image_imagelink' => 'image',
-                ],
               ],
             ],
           ],
@@ -253,16 +253,16 @@ public function addAllFieldProcessesAltersData() {

@@ -253,16 +253,16 @@ public function addAllFieldProcessesAltersData() {
                 'd7_text' => 'd7_text_default',
                 'number_default' => 'number_default_default',
                 'taxonomy_term_reference' => 'taxonomy_term_reference_default',
-                'image' => 'image_default',
+                'image_miw' => 'image_image',
                 'link_field' => 'link_default',
                 'entityreference' => 'entityreference_default',
                 'list' => 'list_default',
+                'file_mfw' => 'file_generic',
                 'email_textfield' => 'email_default',
                 'phone' => 'phone_default',
                 'date' => 'datetime_default',
                 'datetime' => 'datetime_default',
                 'datestamp' => 'datetime_timestamp',
-                'filefield_widget' => 'file_generic',
               ],
             ],
           ],

🤔 These changes I don't quite understand. I do understand the image_miw and file_miw additions. I do not understand any of the other changes.

15.1 I have not investigated but the order of the fields as tested in FieldDiscoveryTest changes when field plugins are added.

Yes, I mucked up the widget maps. This should be better.

edit: s/investigate/investigated

That looks better! 👍

P.S.: Would appreciate your guidance on #3188284: [PP-3] Migration support 😊

Retesting

how can I solve this problem in Drupal 9.1.2 ?

@nojj, Use the patch in #16, it applies to 9.1.2.

Needed a reroll

Yet another reroll.

@quietone asked me to review this issue as a review swap, so here we go:
1) I had D7 project running so it took me a relatively short time to install those two modules and configure field widgets for Image and File fields;
2) I exported a database dump and ran the Upgrade (provide by Migrate Drupal UI) and hit the same issues reported in the issue summary;
3) After applying the patch, these errors were gone and the migrated fields had Image and File widgets 🙌

I have to mention that in both cases (before and after the patch), the Upgrade summary page displayed the following warnings:

Should we add some records to migrate_drupal.migrate_drupal.yml file about the migration status?

@Matroskeen, thank you for the review.

Great news to know that the patch passed manual testing!

Good point, yes, I completely forgot the review page tests. This patch adds entries in the source fixture to enable the two multiupload modules and then adjusts the tests as needed.

Oops, missed a spelling error. Added a cSpell disable/enable to prevent the errors. I suppose 'Multiupload' could be added to the dictionary but this is the only occurrence, so the disable/enable seems like the right thing to do.

More fixes for spelling. Seems I haven't properly ingrained running commit-code-check.

I tested again with the last patch and confirm it's working properly: widget settings are migrated and there are no warnings on the review page.
The patch looks good to me and the testbot is happy.

Thanks!

@Matroskeen, Thanks!

Committed/pushed to 9.2.x.

This doesn't apply to 9.1.x - I'm marking fixed, but if someone wants to backport the patch, please re-open with the backport.

Great! This is the last issue in the Meta #2456259: [META] Drupal 7 to Drupal 8 Migration path.

Woah, congrats, @quietone! 👏

WHAT AN ACHIEVEMENT!!!!!!!! 🥳🥳🥳🥳🙏🙏🙏

Wow, I somehow missed this fact! AMAZING!!! 🥳

Updating tags per Issue tags field and Issue tags -- special tags for issue #3565085: Drupal core issue tag cleanup.