Problem/Motivation

Since testbot only tests issues with the vendor versions in the composer lock file, we need a way to test against older vendor versions that are permitted in our composer.json in order to avoid committing code that may not work with an earlier dependency.

Proposed resolution

Keep an RTBC issue with a patch to run composer update --prefer-lowest against the codebase prior to running the test suite.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

Status: Active » Reviewed & tested by the community
StatusFileSize
new559 bytes
mikelutz’s picture

Status: Reviewed & tested by the community » Needs work
mikelutz’s picture

Category: Plan » Support request
mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.06 KB

Remove explicitly drupal/coder + Composer minimum is 1.9.0 now for Drupal 8.8.x.

Status: Needs review » Needs work

The last submitted patch, 6: 3044175-6.patch, failed testing. View results

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new2.74 KB
new1.67 KB

Symfony has changed the wording of the ApcClassLoader deprecation message in the course of the version 3 lifecycle.

mikelutz’s picture

Yes, but we need to commit that fix to core, not include it in this patch. The patch in this thread should just run the tests against our minimal supported dependencies and report so that we can either fix the errors or update our declared minimum versions to versions that work.

mondrake’s picture

#9 sure. Let's see what else we need to get this green, and then spin-off the non-drupalci changes to a separate issue.

Status: Needs review » Needs work

The last submitted patch, 8: 3044175-8.patch, failed testing. View results

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new740 bytes
new3.46 KB
  • guzzlehttp/guzzle needs to be at least at 6.3 where CookieJar::getCookieByName was introduced
  • pear/archive_tar needs to be at least at 1.4.5 to be compliant with SA-CORE-2019-001 (and not calling deprecated code)

Status: Needs review » Needs work

The last submitted patch, 12: 3044175-10.patch, failed testing. View results

mondrake’s picture

I do not know how to fix the rest. Gut feeling says all this can be telated to Mink but I will leave it to someone in the knows.

xjm’s picture

Issue tags: +mwds2019

 

mondrake’s picture

Status: Needs work » Needs review
StatusFileSize
new2.99 KB
new487 bytes

Composer to ^1.9 as per #6 is not necessary here, in case it would be managed in #3075785: Update composer/composer to ^1.9.1.

Status: Needs review » Needs work

The last submitted patch, 16: 3044175-16.patch, failed testing. View results

mondrake’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new4.02 KB
new1.03 KB

This should be green, now.

-        "behat/mink-goutte-driver": "^1.2",
+        "behat/mink-goutte-driver": "^1.2.1",
+        "behat/mink-browserkit-driver": "^1.3.3",
...
+        "instaclick/php-webdriver": "^1.4.5",
...
-        "jcalderonzumba/mink-phantomjs-driver": "^0.3.1",
+        "jcalderonzumba/mink-phantomjs-driver": "^0.3.2",

fix the mink drivers to at least the version currently installed in lock, and

+        "symfony/dom-crawler":"^3.4.0",
+        "symfony/browser-kit":"^3.4.0",

prevent these two Symfony components to be downgraded to 2.x versions.

This patch is not for commit - todos:
1 - agree this is the final set of lowest dependencies constraints. If so, then
2 - file a separate issue with the patch here without the drupalci.yml changes, for commit, and
3 - keep the patch with the drupalci.yml changes only here, in RTBC to keep testing daily

mondrake’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

needs reroll

mondrake’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new4.09 KB

Rerolled.

mondrake’s picture

Status: Needs review » Reviewed & tested by the community
mile23’s picture

Do we have an issue for at least pear/archive_tar from #12? That seems like an easy gain since it's a security concern. I could only find #3039611: Update core PHP dependencies for 8.8.x

mondrake’s picture

mondrake’s picture

StatusFileSize
new4.05 KB
mondrake’s picture

mondrake’s picture

mondrake’s picture

StatusFileSize
new3.73 KB
mondrake’s picture

StatusFileSize
new2.26 KB

A test only patch just to see where we'd stand without the lower constraints set.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 29: 3044175-29-TEST-ONLY.patch, failed testing. View results

mile23’s picture

Looks like #3086796: Explicitly require pear/archive_tar ^1.4.5 will help us with the fails in #29, since pear/archive_tar will bump up our requirement for pear/pear-core-minimal.

mondrake’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new3.73 KB
new2.26 KB

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 32: 3044175-32-UNCONSTRAINED.patch, failed testing. View results

mondrake’s picture

Status: Needs work » Reviewed & tested by the community

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 32: 3044175-32-UNCONSTRAINED.patch, failed testing. View results

mondrake’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new3.73 KB

Reuploading patch in #32

mondrake’s picture

StatusFileSize
new2.26 KB
new3.32 KB

Rerolls.

The last submitted patch, 38: 3044175-38-UNCONSTRAINED.patch, failed testing. View results

mondrake’s picture

Status: Reviewed & tested by the community » Needs work

Needs reroll.

mondrake’s picture

Status: Needs work » Reviewed & tested by the community
Related issues: +#3088442: Update composer constraints for mikey179/vfsstream and egulias/email-validator
StatusFileSize
new3.33 KB
mondrake’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
sokru’s picture

Issue tags: -Needs reroll
StatusFileSize
new3.31 KB

Re-roll.

mile23’s picture

mile23’s picture

Status: Needs work » Reviewed & tested by the community
mondrake’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
rpayanm’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new3.31 KB
mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 48: 3044175-48.patch, failed testing. View results

mile23’s picture

Issue tags: +Needs reroll

Patch no longer applies.

sashi.kiran’s picture

I have tested applying path #48 and its getting applied without any conflicts.
Yet to fix the failed Unit Test error.

sashi.kiran’s picture

Issue tags: -Needs reroll +need review

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

Title: PHP7.1 vendor min Testing issue - DO NOT COMMIT » Vendor minimum testing issue - DO NOT COMMIT
Status: Needs work » Needs review
Issue tags: -
StatusFileSize
new424 bytes

Let's revive this for 9.3.x and see whether our composer.json minimums are correct.

longwave’s picture

StatusFileSize
new680 bytes
longwave’s picture

Version: 9.3.x-dev » 9.2.x-dev
StatusFileSize
new1.12 KB

We need at least Coder 8.3.10 for Drupal.Classes.UseGlobalClass.

longwave’s picture

StatusFileSize
new4.06 KB

We need minimums of :

  • PHPUnit 8.5.14 for PhpUnitWarningsTest to pass.
  • Prophecy 1.11 to avoid three fatal errors in DateTimeNormalizerTest and friends.
  • doctrine/annotations 1.12 to avoid a failure in DocParserTest.
  • MinkBrowserKitDriver 1.4 to avoid Symfony deprecations.

The last submitted patch, 59: 3044175-59.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 60: 3044175-60.patch, failed testing. View results

longwave’s picture

Status: Needs work » Needs review
StatusFileSize
new3.97 KB

We also need:

  • fabpot/goutte 3.3 to run GoutteDriverTest
  • instaclick/php-webdriver 1.4.1 to upload files in Selenium tests
  • Prophecy 1.12 to run OptimizedPhpArrayDumperTest
longwave’s picture

Status: Needs review » Reviewed & tested by the community

Marking RTBC so this gets auto retested.

Opened #3215280: Bump minimum dependencies required for tests to pass - if that gets committed we can remove the changes here and leave only the drupalci.yml change.

longwave’s picture

Version: 9.2.x-dev » 9.3.x-dev
StatusFileSize
new424 bytes

#3215280: Bump minimum dependencies required for tests to pass landed so hopefully this should stay green for a while.

longwave’s picture

Oh so it looks like our minimum dependencies differ based on PHP version, somehow :(

catch’s picture

Title: Vendor minimum testing issue - DO NOT COMMIT » [DO NOT COMMIT] Vendor minimum testing issue

Just helping my eyes when they scan the RTBC queue...

xjm’s picture

@catch It's a support request so you could make your bookmark exclude those. (That's what I've done.)

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

Status: Reviewed & tested by the community » Needs work

Two releases behind now.

spokje’s picture

StatusFileSize
new468 bytes
spokje’s picture

StatusFileSize
new406 bytes
spokje’s picture

StatusFileSize
new897 bytes

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

xjm’s picture

Status: Needs work » Closed (outdated)

I think we no longer need this, since we have proper DrupalCI environments now?