Problem/Motivation
Since testbot only tests issues with the vendor versions in the composer lock file, we need a way to test against older vendor versions that are permitted in our composer.json in order to avoid committing code that may not work with an earlier dependency.
Proposed resolution
Keep an RTBC issue with a patch to run composer update --prefer-lowest against the codebase prior to running the test suite.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #74 | prefer-lowest+coder-version-increase.patch | 897 bytes | spokje |
| #73 | prefer-lowest.patch | 406 bytes | spokje |
Comments
Comment #2
mikelutzComment #3
mikelutzComment #5
mikelutzComment #6
mondrakeRemove explicitly drupal/coder + Composer minimum is 1.9.0 now for Drupal 8.8.x.
Comment #8
mondrakeSymfony has changed the wording of the ApcClassLoader deprecation message in the course of the version 3 lifecycle.
Comment #9
mikelutzYes, but we need to commit that fix to core, not include it in this patch. The patch in this thread should just run the tests against our minimal supported dependencies and report so that we can either fix the errors or update our declared minimum versions to versions that work.
Comment #10
mondrake#9 sure. Let's see what else we need to get this green, and then spin-off the non-drupalci changes to a separate issue.
Comment #12
mondrakeguzzlehttp/guzzleneeds to be at least at 6.3 whereCookieJar::getCookieByNamewas introducedpear/archive_tarneeds to be at least at 1.4.5 to be compliant with SA-CORE-2019-001 (and not calling deprecated code)Comment #14
mondrakeI do not know how to fix the rest. Gut feeling says all this can be telated to Mink but I will leave it to someone in the knows.
Comment #15
xjmComment #16
mondrakeComposer to ^1.9 as per #6 is not necessary here, in case it would be managed in #3075785: Update composer/composer to ^1.9.1.
Comment #18
mondrakeThis should be green, now.
fix the mink drivers to at least the version currently installed in lock, and
prevent these two Symfony components to be downgraded to 2.x versions.
This patch is not for commit - todos:
1 - agree this is the final set of lowest dependencies constraints. If so, then
2 - file a separate issue with the patch here without the
drupalci.ymlchanges, for commit, and3 - keep the patch with the
drupalci.ymlchanges only here, in RTBC to keep testing dailyComment #19
mondrakeneeds reroll
Comment #20
mondrakeRerolled.
Comment #21
mondrakeComment #22
mile23Do we have an issue for at least pear/archive_tar from #12? That seems like an easy gain since it's a security concern. I could only find #3039611: Update core PHP dependencies for 8.8.x
Comment #23
mondrakeThere's a #3086332: Explicitly require-dev symfony/browser-kit: 3.4.0 too, now.
Comment #24
mondrakeComment #25
mondrakeReroll after commit of #3086332: Explicitly require-dev symfony/browser-kit: 3.4.0
Comment #26
mondrake@Mile23 re #22: filed #3086796: Explicitly require pear/archive_tar ^1.4.5
Comment #27
mondrakeFiled #3086811: Explicitly require guzzlehttp/guzzle ^6.3
Comment #28
mondrakeReroll after commit of #3086811: Explicitly require guzzlehttp/guzzle ^6.3.
Comment #29
mondrakeA test only patch just to see where we'd stand without the lower constraints set.
Comment #31
mile23Looks like #3086796: Explicitly require pear/archive_tar ^1.4.5 will help us with the fails in #29, since pear/archive_tar will bump up our requirement for pear/pear-core-minimal.
Comment #32
mondrakeComment #34
mondrakeComment #37
mondrakeReuploading patch in #32
Comment #38
mondrakeRerolls.
Comment #40
mondrakeFiled #3087678: Explicitly require-dev symfony/dom-crawler ^3.4.0
Comment #41
mondrakeNeeds reroll.
Comment #42
mondrakeComment #43
mondrakeComment #44
sokru commentedRe-roll.
Comment #45
mile23Added similar issue for D9: #3104474: D9, PHP 7.2 vendor min Testing issue - DO NOT COMMIT
Comment #46
mile23Comment #47
mondrakeComment #48
rpayanmComment #49
mondrakeComment #51
mile23Patch no longer applies.
Comment #52
sashi.kiran commentedI have tested applying path #48 and its getting applied without any conflicts.
Yet to fix the failed Unit Test error.
Comment #53
sashi.kiran commentedComment #57
longwaveLet's revive this for 9.3.x and see whether our composer.json minimums are correct.
Comment #58
longwaveComment #59
longwaveWe need at least Coder 8.3.10 for Drupal.Classes.UseGlobalClass.
Comment #60
longwaveWe need minimums of :
Comment #63
longwaveWe also need:
Comment #64
longwaveMarking RTBC so this gets auto retested.
Opened #3215280: Bump minimum dependencies required for tests to pass - if that gets committed we can remove the changes here and leave only the drupalci.yml change.
Comment #65
longwave#3215280: Bump minimum dependencies required for tests to pass landed so hopefully this should stay green for a while.
Comment #66
longwaveOh so it looks like our minimum dependencies differ based on PHP version, somehow :(
Comment #67
catchJust helping my eyes when they scan the RTBC queue...
Comment #68
xjm@catch It's a support request so you could make your bookmark exclude those. (That's what I've done.)
Comment #71
catchTwo releases behind now.
Comment #72
spokjeComment #73
spokjeComment #74
spokjeComment #76
xjmI think we no longer need this, since we have proper DrupalCI environments now?