Problem/Motivation

In #2912387: Stop using wikimedia/composer-merge-plugin we are enforcing Composer 1.9.0 as minimum version for development but, weirdly, we are still allowing ^1.8 in composer.json require-dev, and are actually locked at 1.8.5.

Proposed resolution

Update composer.json and composer.lock with expectations.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

mondrake created an issue. See original summary.

greg.1.anderson’s picture

Composer 1.9 is only required for Drupal core development. If you are using a drupal-composer/drupal-project based site, then older versions of Composer still work.

Mixologic’s picture

Also we require composer 1.9 to be installed as your global tool when working with the git clone of drupal as a core developer, *however* when we require composer/composer as a dev dependency that is so that we can use it for testing the composer plugins that are written into core, and as such it acts like a library and not a tool in that case.

It probably wouldnt hurt to bump it to 1.9, but its not totally necessary.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

mondrake’s picture

Title: Update composer/composer to ^1.9 » Update composer/composer to a PHP 7.4 compatibile release
Priority: Normal » Critical
Status: Active » Postponed
Issue tags: +PHP 7.4

This is becoming critical in the path to get Drupal 8.8 tests pass with PHP 7.4.

Relaeas 1.9.0 upstream is not yet 7.4 compatible, so marking postponed.

mondrake’s picture

Title: Update composer/composer to a PHP 7.4 compatibile release » Update composer/composer to ^1.9.1
Status: Postponed » Active

composer/composer 1.9.1 was released, it includes PHP 7.4 compatibility fixes.

andypost’s picture

Status: Active » Needs review
StatusFileSize
new3.81 KB

Here's attempt

andypost’s picture

StatusFileSize
new3.46 KB

the one for 8.9.x

alexpott’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new3.46 KB
new3.46 KB
new3.46 KB

So in order to generate this patch you need to:
1. Update composer.json
2. Run composer update composer/composer
3. Run composer update --lock (to remove the composer bin entry from the lock file)

That last step is not fun.

This patch is only a reroll of the last patch...

  • catch committed 435f4d1 on 9.0.x
    Issue #3075785 by alexpott, andypost, mondrake, Mixologic, greg.1....

  • catch committed cfb052f on 8.9.x
    Issue #3075785 by alexpott, andypost, mondrake, Mixologic, greg.1....

  • catch committed 1f02b07 on 8.8.x
    Issue #3075785 by alexpott, andypost, mondrake, Mixologic, greg.1....

alexpott credited catch.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Mixologic’s picture

(to remove the composer bin entry from the lock file)

Im very much unsure why this is happening, or why it keeps coming back.

xjm’s picture

Version: 8.9.x-dev » 8.8.x-dev
Issue tags: +8.8.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.