Problem/Motivation
From #3031379-258: Add a new test type to do real update testing:
As long as we are following up, this appears to introduce a dependency on symfony/browser-kit, but does not declare the dependency. It's currently only installed becuase it's required y behat/mink-browser-kit-driver.
It's also getting installed at version 4.3 on php 7.1 with a composer update, but that adds string typehinting to the request method which we aren't compatible with pre-php 7.2
Can we explicitly require-dev symfony/browser-kit: ^3.4.0 (and we should be fine with type-hinting when we update to 4.3 on Drupal 9 with a minimum php version of 7.2)
Proposed resolution
require-dev symfony/browser-kit:~3.4.0, based on #3.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#7 | 3086332.patch | 2.5 KB | heddn |
Comments
Comment #2
heddnComment #3
MixologicShouldnt this be ~3.4.0 ?
I dont think we should add bin files for composer here.. is there a reason this is here?
Comment #4
heddnAs an aside (and I'm not arguing w/ the IS about version 4.3 adding string type hinting) but that seems like something that should also be resolved upstream in the symfony project. https://github.com/symfony/symfony/blob/4.4/composer.json currently lists PHP 7.1 as the required version.
Re #3: I noticed
bin/composer
added too. It is being added by composer to"name": "composer/composer"
. I'm not sure if it is my version of composer (1.9.0) or what is the cause. I can't _not_ introduce that change.Comment #5
heddnComment #6
Mile23^ vs ~: We currently use ^ for other dev dependencies, and probably should here, too, for widest latitude: https://git.drupalcode.org/project/drupal/blob/8.8.x/composer.json#L22
In fact, we have two issues to let us run the
DrupalMinkClient
tests against browser-kit ^4.2: #3086557: Make DrupalMinkClient::request() compatible with max dependencies and #3086005: Make DrupalMinkClientTest::followMetaRefresh() compatible with max dependenciesSo I'd RTBC #2.
Comment #7
heddnRe-uploading #2 so it is last.
Comment #8
heddnComment #9
MixologicAh. I was just basing it off the other dev deps we put in here:
https://git.drupalcode.org/project/drupal/blob/8.8.x/composer.json#L26-28
https://symfony.com/roadmap does inform us that it really doesnt matter whether we use ^ or ~, simply due to the fact that there wont ever be a 3.5 of any of these dependencies.
So, #2/#4/#6 are essentially identical in impact.
RTBC Both and let the committer decide?
Comment #11
catchCommitted cae168a and pushed to 8.8.x. Thanks!