Problem/Motivation

Since testbot only tests issues with the vendor versions in the composer lock file, we need a way to test against recent vendor updates in order to catch issues like #3039408: Updating twig/twig to v1.38.0 or v1.38.1 causes fatal error and #3039584: The "Symfony\Bridge\PsrHttpMessage\Factory\DiactorosFactory" class is deprecated since symfony/psr-http-message-bridge 1.2, use PsrHttpFactory instead. and #3045349: Lazy started sessions with session data are not saved with symfony/http-foundation 3.4.24. If we enable Symfony 4 support in 8.8, we will need a way to test against that as well

Proposed resolution

Keep an RTBC issue with a patch to run composer update against the codebase prior to running the test suite.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#29 3044155-11.no-commit.patch573 bytesmondrake
#18 3044155-11.no-commit.patch573 bytesmikelutz
#11 3044155-11.no-commit.patch573 bytesalexpott
#2 3044155-2.drupal.PHP71-vendor-max-Testing-issue--DO-NOT-COMMIT.patch543 bytesmikelutz

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new 3044155-2.drupal.PHP71-vendor-max-Testing-issue--DO-NOT-COMMIT.patch543 bytes
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Related issues: +#3044175: [DO NOT COMMIT] Vendor minimum testing issue
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Category: Plan » Support request

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3044155-2.drupal.PHP71-vendor-max-Testing-issue--DO-NOT-COMMIT.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Let's close this so it's not in the RTEBC queue. :) Thanks!

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

I'm happy to respect your decision, but I want to point out that the reason this was set to RTBC was to have the tests run daily, and email the followers if they failed. This allowed us to catch #3045349: Lazy started sessions with session data are not saved with symfony/http-foundation 3.4.24 almost a full day before anyone was really complaining about it. Gabor had suggested and I had hoped that putting it in the support request category would have removed it from your RTBC queue view. I certainly understand having the issue in RTBC might be annoying for the committers, but I wanted to make sure you were aware of why it was set to RTBC.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Closed (duplicate) » Reviewed & tested by the community

I agree that this is useful to have, our dependencies seem to break stuff frequently atm: #3051269: Updating Drupal 8.6.x to twig 1.40.0 causes twig exceptions

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 3044155-11.no-commit.patch573 bytes

Dealing with coder and composer :)

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3044155-11.no-commit.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community

Testbot hiccup..

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3044155-11.no-commit.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3044155-11.no-commit.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3044155-11.no-commit.patch573 bytes

re-uploading the patch from #11, just to clean up the failures.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +mwds2019

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 3044155-11.no-commit.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 3044155-11.no-commit.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 3044155-11.no-commit.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Fix for latest fail - #3086005: Make DrupalMinkClientTest::followMetaRefresh() compatible with max dependencies

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community

Fix in, re-queuing

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 3044155-11.no-commit.patch, failed testing. View results

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Child issue addressing fail in #27: #3086557: Make DrupalMinkClient::request() compatible with max dependencies

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3044155-11.no-commit.patch573 bytes

Reuploading patch #11 to cleanup from failed tests. #3086332: Explicitly require-dev symfony/browser-kit: 3.4.0 is in so this should be green now since symfony/browser-toolkit is now constrained to ^3.4 and won't upgrade to ^4

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 29: 3044155-11.no-commit.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 29: 3044155-11.no-commit.patch, failed testing. View results

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

cilefen’s picture

cilefen commented
Status: Needs work » Closed (outdated)