Problem/Motivation

drupal-check results on the 8.x-1.x-dev version updated 14 Apr 2020 at 15:57 UTC

./vendor/bin/drupal-check web/modules/contrib/conditional_fields/
 53/53 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------ 
  Line   src/ConditionalFieldsFormHelper.php                               
 ------ ------------------------------------------------------------------ 
  718    Call to deprecated function element_info_property():              
         in drupal:8.0.0 and is removed from drupal:9.0.0.                 
         Use \Drupal::service('element_info')->getInfoProperty() instead.  
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/conditional_fields/handler/extra_contrib/LinkAddressfield.php                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\conditional_fields\Plugin\conditional_fields\handler\LinkAddressfield was not found while trying to analyse it -  
         autoloading is probably not configured properly.                                                                               
         💡 Learn more at https://phpstan.org/user-guide/autoloading                                                                     
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#20 3042734_drupal_check.png8.06 KBhmendes
#18 conditional-fields.png127.33 KBgobinathm
#14 Patchappliedsuccessfully.png659.2 KBpriyanka.sahni
#13 3042734-13.patch1.64 KBnitesh624
#12 3042734-12.patch1.38 KBnitesh624
#11 3042734-7.patch1.38 KBnitesh624
#10 3042734-10.patch0 bytesnitesh624
#9 3042734-9.patch597 bytesnitesh624
#7 3042734-7.patch1.38 KBnitesh624
#2 drupal_9_deprecated_code-3042734-2.patch9.98 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042734-2.patch9.98 KB

Here is the patch, please review.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: Unassigned » nitesh624
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Status: Needs review » Needs work
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Issue summary: View changes
Issue tags: -midcamp2019
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Issue summary: View changes
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3042734-7.patch1.38 KB 
./vendor/bin/drupal-check web/modules/contrib/conditional_fields/
 53/53 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: nitesh624 » Unassigned
Status: Needs work » Needs review
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3042734-9.patch597 bytes
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3042734-10.patch0 bytes
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3042734-7.patch1.38 KB
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3042734-12.patch1.38 KB
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
StatusFileSize
new 3042734-13.patch1.64 KB

vendor/bin/drupal-check web/modules/contrib/conditional_fields/
53/53 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

test was failed in the last commit build also. please see the link https://www.drupal.org/pift-ci-job/1669105

priyanka.sahni’s picture

priyanka.sahni commented
Assigned: Unassigned » priyanka.sahni
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Patchappliedsuccessfully.png659.2 KB

I tried verifying the patch.Patch was applied successfully and the test was failing earlier , now working fine.

Patch#13

priyanka.sahni’s picture

priyanka.sahni commented
Assigned: priyanka.sahni » Unassigned
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Why do recent patches not contain everything in #2? Are these individual fixes that all need to be rolled together? If so, please do that. Do not provide them one at a time.

If you're posting new patches, please explain what's changed from the previously posted one and provide interdiffs. Without interdiffs, it's very difficult to review.

dbielke1986’s picture

dbielke1986 commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

I think the reason is that #2 was not a patch to the latest version of this module.
#13 seems to be fine for me.

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented
Issue summary: View changes
StatusFileSize
new conditional-fields.png127.33 KB

3042734-13.patch seems to be applying fine.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

It looks like you're applying the patch to the latest release, not HEAD, where the patch doesn't apply. Patches must apply to HEAD.

colan@snake[Wed 29 14:52]% patch -p1 < /tmp/3042734-13.patch                   
patching file src/ConditionalFieldsFormHelper.php
Hunk #1 FAILED at 8.
Hunk #2 FAILED at 715.
2 out of 2 hunks FAILED -- saving rejects to file src/ConditionalFieldsFormHelper.php.rej
patching file src/Plugin/conditional_fields/handler/extra_contrib/LinkAddressfield.php
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file src/Plugin/conditional_fields/handler/extra_contrib/LinkAddressfield.php.rej
hmendes’s picture

hmendes commented
Version: 8.x-1.x-dev » 4.x-dev
Status: Needs work » Closed (outdated)
Related issues: +#3134427: Remove needless module_load_include() from module file
StatusFileSize
new 3042734_drupal_check.png8.06 KB

Hello, running drupal-check on 4.x-dev version is not showing anything, so I'm closing this issues as outdated.

hmendes’s picture

hmendes commented
Related issues: +#3144474: Fix namespace in conditional_fields/src/Plugin/conditional_fields/handler/extra_contrib/LinkAddressfield.php, +#3151849: Make ConditionalFieldsFormHelper.php a service