Hello,

Such as in D8 version there is no more conditional_fields.api.inc file usage of module_load_include function can be removed from module file(line 335).

Best regards

CommentFileSizeAuthor
#4 NoFileSpecified.png26.94 KBpaulocs
#2 unused_module_load_include-3134427-2.patch653 bytesgrapefruitjuice

Issue fork conditional_fields-3134427

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

GrapefruitJuice created an issue. See original summary.

grapefruitjuice’s picture

grapefruitjuice commented
Assigned: grapefruitjuice » Unassigned
Status: Active » Needs review
StatusFileSize
new unused_module_load_include-3134427-2.patch653 bytes

There is a patch, please review it.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

I agree. I was working in the module and see this unnecessary module_load_include as well (I almost created a duplicated issue).

Just to make easier the review of the maintainers I did a little research and saw that conditional_fields.api.inc was removed in #2926132: OOify contents of conditional_fields.api.inc and then delete it.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Version: 8.x-1.x-dev » 4.x-dev
StatusFileSize
new NoFileSpecified.png26.94 KB

Attaching an image with the files from the current 4.x-dev branch and changing the issue version.

paulocs opened merge request !7

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

This make sense to me!
Thanks everyone!

  • thalles committed a5f766d on 4.x authored by paulocs 
    Issue #3134427 by paulocs, GrapefruitJuice, thalles: Remove needless...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.