Closed (fixed)
Project:
Login Destination
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Mar 2019 at 16:19 UTC
Updated:
16 Mar 2020 at 07:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gaddamsr commentedFixed the grammar in the description . This is my first commit. Thank you for working on this project .
Comment #3
mradcliffeThank you for the patch, @gaddamsr.
Remember to change the Status to "Needs Review" to send the patch to the test bot.
Comment #4
kwfinken commentedTested on simplytest.me worked well.
Comment #5
mradcliffeI think that the pattern following the Help text standards is to use "Customizes". "Customize" may make the description sound like an imperative or a command.
Comment #6
volkswagenchickI am unassigning myself. We used this issue as an example in a contribution workshop at MIDCamp 2019.
Comment #8
rsvelko commentedHi, I've used your patch.
I've made the module description even better with a 2nd commit. (forgot to mention the issue number in the commit message, so you won't see it here, but it's in the git log)
Very good that you're doing a workshop!
Indeed, we've forogtten to fix the wording for a long time, so we've just fixed it at last.
PS. In the commit message I've mentioned all issue commenters - I suppose most of them are workshop's students, so they deserve a hat tip.
Comment #9
kellyimagined commentedThis patch updates @gaddamsr original, and applies the changes from @mradcliffe. I am guessing it is similar to what @rsvelko tried to upload.
Comment #10
kellyimagined commentedComment #11
kellyimagined commentedTry 2 with underscores
Comment #12
Eitisha commentedHi @kellyimagined
I reviewed the patch and applied cleanly. The description looks clear.
Please see the screenshot for the applied patch.
Thanks
Comment #13
volkswagenchickI am not sure why this was opened again... Comment #7 commits the patch
Comment #14
baikho commented@volkswagenchick,
devhas indeed been committed, but could still have the suggestion from #5. patch in #9 & #11 tries to do so, but needs a re-roll.Comment #15
rsvelko commented4 minutes after the patch in #7, I've committed again to make "Customize" -> "Customizes" and add a full list of events when the module executes: added "logout/registration/one-time login" - besides the login event.
So the final text is:
description: Customizes the destination the user is redirected to after login/logout/registration/one-time login.
and that happened 4 minutes after 1st commit, I just forgot to tag the commit message with the issue number, so you won't see it in the comments.
Cheers!
Comment #17
chris matthews commented