Problem/Motivation

While evaluating the project, I noticed the grammar in the description on the Extend could be improved.

Patch to follow!

Comments

volkswagenchick created an issue. See original summary.

gaddamsr’s picture

StatusFileSize
new460 bytes

Fixed the grammar in the description . This is my first commit. Thank you for working on this project .

mradcliffe’s picture

Status: Active » Needs review

Thank you for the patch, @gaddamsr.

Remember to change the Status to "Needs Review" to send the patch to the test bot.

kwfinken’s picture

Status: Needs review » Reviewed & tested by the community

Tested on simplytest.me worked well.

mradcliffe’s picture

Status: Reviewed & tested by the community » Needs work
-description: Add possibility customize the destination that the user is redirected to after login.
+description: Customize the destination the user is redirected to after login.

I think that the pattern following the Help text standards is to use "Customizes". "Customize" may make the description sound like an imperative or a command.

volkswagenchick’s picture

Assigned: volkswagenchick » Unassigned

I am unassigning myself. We used this issue as an example in a contribution workshop at MIDCamp 2019.

  • rsvelko committed a337d3c on 8.x-1.x authored by gaddamsr
    Issue #3042576 by gaddamsr, volkswagenchick, mradcliffe, kwfinken:...
rsvelko’s picture

Hi, I've used your patch.

I've made the module description even better with a 2nd commit. (forgot to mention the issue number in the commit message, so you won't see it here, but it's in the git log)

Very good that you're doing a workshop!

Indeed, we've forogtten to fix the wording for a long time, so we've just fixed it at last.

PS. In the commit message I've mentioned all issue commenters - I suppose most of them are workshop's students, so they deserve a hat tip.

kellyimagined’s picture

This patch updates @gaddamsr original, and applies the changes from @mradcliffe. I am guessing it is similar to what @rsvelko tried to upload.

kellyimagined’s picture

Status: Needs work » Needs review
kellyimagined’s picture

Try 2 with underscores

Eitisha’s picture

Hi @kellyimagined

I reviewed the patch and applied cleanly. The description looks clear.

Please see the screenshot for the applied patch.

Thanks

volkswagenchick’s picture

I am not sure why this was opened again... Comment #7 commits the patch

baikho’s picture

Status: Needs review » Needs work

@volkswagenchick,

dev has indeed been committed, but could still have the suggestion from #5. patch in #9 & #11 tries to do so, but needs a re-roll.

rsvelko’s picture

Status: Needs work » Fixed

4 minutes after the patch in #7, I've committed again to make "Customize" -> "Customizes" and add a full list of events when the module executes: added "logout/registration/one-time login" - besides the login event.

So the final text is:
description: Customizes the destination the user is redirected to after login/logout/registration/one-time login.

and that happened 4 minutes after 1st commit, I just forgot to tag the commit message with the issue number, so you won't see it in the comments.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chris matthews’s picture