Closed (outdated)
Project:
Chaos Tool Suite (ctools)
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2019 at 12:21 UTC
Updated:
16 Nov 2022 at 19:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
thallesFollow the patch!
Comment #3
thallesComment #4
chris matthews commentedThe 2 year old patch in #3 needs a reroll.
Comment #5
shreyakaushik11 commentedI've rerolled the patch mentioned in #3.
Please review.
Comment #6
guilhermevp commentedRe-rolled patch looks good, most of patch #3 ended addressed in other issues.
Comment #7
joelpittetThe two lines being ignored need a git blame to figure out why they are commented out code to begin with, and better yet would be to uncomment them and see if they still break.
Comment #8
andregp commentedI found where this came from, I'll comment here the details. Just one sec.
Comment #9
andregp commentedThese two lines were commented out on commit c14a5eee from May 6th, 2016.
The commit message says:
commenting out two tests until #2671964 landsWith further research I found this:
https://git.drupalcode.org/project/ctools/-/commit/c14a5eee970c3d0aab02e...
and https://www.drupal.org/node/2671964 which was fixed so I think its okay to uncomment these lines.
Comment #10
victoria-marina commentedComment #11
victoria-marina commentedLooks good! It's a RTBC for me.
Comment #12
japerry