Problem/Motivation

FILE: ...trib/modules/ctools/tests/src/Kernel/RelationshipManagerTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 22 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: "foo"
 23 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: ]
 46 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
 46 | WARNING | [ ] There must be no blank line following an inline
    |         |     comment
 46 | ERROR   | [x] No space found before comment text; expected "//
    |         |     $this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
    |         |     but found
    |         |     "//$this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
 46 | ERROR   | [x] Inline comments must end in full-stops,
    |         |     exclamation marks, colons, question marks, or
    |         |     closing parentheses
 60 | ERROR   | [x] No space found before comment text; expected "//
    |         |     $this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
    |         |     but found
    |         |     "//$this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
 60 | ERROR   | [x] Inline comments must end in full-stops,
    |         |     exclamation marks, colons, question marks, or
    |         |     closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Comments

thalles created an issue. See original summary.

thalles’s picture

Status: Needs work » Needs review
StatusFileSize
new3.42 KB

Follow the patch!

thalles’s picture

chris matthews’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

The 2 year old patch in #3 needs a reroll.

shreyakaushik11’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new1.06 KB

I've rerolled the patch mentioned in #3.
Please review.

guilhermevp’s picture

Status: Needs review » Reviewed & tested by the community

Re-rolled patch looks good, most of patch #3 ended addressed in other issues.

joelpittet’s picture

Status: Reviewed & tested by the community » Needs work

The two lines being ignored need a git blame to figure out why they are commented out code to begin with, and better yet would be to uncomment them and see if they still break.

andregp’s picture

Assigned: Unassigned » andregp

I found where this came from, I'll comment here the details. Just one sec.

andregp’s picture

Assigned: andregp » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.25 KB

These two lines were commented out on commit c14a5eee from May 6th, 2016.
The commit message says: commenting out two tests until #2671964 lands
With further research I found this:
https://git.drupalcode.org/project/ctools/-/commit/c14a5eee970c3d0aab02e...
and https://www.drupal.org/node/2671964 which was fixed so I think its okay to uncomment these lines.

victoria-marina’s picture

Assigned: Unassigned » victoria-marina
victoria-marina’s picture

Assigned: victoria-marina » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good! It's a RTBC for me.

japerry’s picture

Status: Reviewed & tested by the community » Closed (outdated)