As mentioned in #3027808: Improve labels shorten the status label to just Status: Published. And as @berdir suggested I created this as a separate issue to commit this small change faster and leave the discussion about the author and date to the other issue.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arpad.rozsa created an issue. See original summary.

arpad.rozsa’s picture

Status: Active » Needs review
FileSize
751 bytes
Berdir’s picture

Status: Needs review » Needs work
+++ b/templates/moderation-sidebar-info.html.twig
@@ -17,8 +17,11 @@
 <div class="moderation-sidebar-info">
-  <p>{{ 'Currently viewing' | t }} <strong>{{ state }}</strong> {{ 'state'|t }}</p>
-  {% if revision_author_link %}
-    <p>{{ 'Authored by' | t }} {{ revision_author_link }} {{ revision_time_pretty }}</p>
-  {% endif %}
+  <p>
+    {{ 'Status:' | t }} <strong>{{ state }}</strong>
+    {% if revision_author_link %}
+      <br />
+      {{ 'Authored by' | t }} {{ revision_author_link }} {{ revision_time_pretty }}
+    {% endif %}
+  </p>
 </div>

looks like this was reformatted. Can we try to only change what is really necessary?

Note that translating things like that doesn't work. E.g. arabic is a left-to-right language (russian too I think), translatable things must always be combined, so lets use {% trans %} like node.html.twig and make the state a placeholder. That's still necessary when it's just State: @state, due to LTR languages.

Also interesting that this doesn't cause any test fails :)

arpad.rozsa’s picture

Status: Needs work » Needs review
FileSize
594 bytes
738 bytes

Made the changes only where it was necessary and used {% trans %} like you suggested.

Berdir’s picture

Thanks, not sure if it should be State or Status. https://english.stackexchange.com/questions/12958/status-vs-state, I'll never fully grasp that. State is closer to what it was before.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

  • arpad.rozsa authored e94babf on 8.x-1.x
    Issue #3030471 by arpad.rozsa, Berdir: Shorten the status label
    
samuel.mortenson’s picture

Status: Reviewed & tested by the community » Fixed

Looks good to me. @Berdir typically "Status" would be something different than the state label, for example "Status: In Draft" feels better to me than "Status: Draft", but we don't have that level of detail coming from Workflows. Committed as-is.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.