Closed (fixed)
Project:
Save & Edit
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Jan 2019 at 07:15 UTC
Updated:
10 Jul 2023 at 20:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
niyas commentedComment #3
pguillard commentedThis works for me, I suggest RTBC then..
Comment #4
pingevt commentedThis seems to be working for me as well. Thanks @Niyas
However, this doesn't look like it should be a final solution for this problem since it creates a dependency on Inline entity forms module.
Comment #5
antiorario commentedComment #6
arnaldopAttached patch resolving the dependency on Inline Entity Forms.
Comment #7
q__nt_n@arnaldop,
Your patch is wrong, you patched "bootstrap_site_alert" module ! :)
@Niyas Thanks for this patch, I'll review today or this week-end.
Comment #8
q__nt_nI upload a new patch : I check if inline entity form is enable
Comment #9
arnaldop@q__nt_n, I'm so sorry! I do not know what happened!
Quick question, though. According to this page,
system_get_inforequires atypeand the module name is optional.I haven't tested this patch, but to be consistent with the documentation, should we change the line to read as follows?
if (system_get_info('module', 'inline_entity_form'))Thanks!
Comment #10
q__nt_n@arnaldop
Yeah, sure ! I failed my patch :) I'll reupload in a few hours.
Thanks for your attention !
Comment #11
q__nt_nI re-upload patch.
I really need your feedback on this. I dont know if it's a good pratice to fix dependance between 2 modules like that.
Thanks !
Comment #12
Cecilina commentedAdd new patch to fix directly call inline_entity_form callback function, instead let this save_edit button to inherit all these callback existed for default submit button.
Comment #13
daveianoPatch from #12is working as desired and is looking good to me!
Comment #14
sluceroPatch #12 looks good to me and fixed the issue perfectly in my use case.
Comment #15
amneh.shawish commentedPatch #2 is working fine with me.
Comment #16
mastap commentedThanks for Patch #12
Comment #17
rviner commentedPatch #2 works for me but Patch #12 doesn't work as it doesn't unpublish the node when clicking on the save and edit button.
Comment #18
eahonet commentedPatch #12 let me finally save the inline_entity_form edits/adds.
I was able to swap between Draft and Published with #12 @rviner. But I think the workflow has had some tweaks and we're using other modules like content_lock with save_edit and inline_entity_form.
Comment #19
stefan.kornIt's true what rviner says, that the unpublish feature of save_edit is not working with patch #12. That is because the submit callbacks need to be provided in some order to work properly, especially the callback save_edit_form_submit_presave needs to be called before the ::save callback callback. Patch #12 attaches the two save_edit submit callbacks just at the end of the existing callbacks, thus to late for save_edit_form_submit_presave.
Providing a patch that should fix this. Maybe one could handle the two foreachs a bit more elegant, but should do it like this.
BTW: If you are using save_edit with Drupal 9 and want to use the unpublish feature you will need this patch first: https://www.drupal.org/project/save_edit/issues/3239440
Comment #20
bramdriesenI confirm that #19 fixes the issue for me.
Comment #21
daletrexelThanks to everyone who has been working on this issue! I've also implemented patch in #19 and it's working for me.
One caveat: I'm not using the unpublish functionality, so I can't speak to that working or not.
Comment #23
caesius commentedI happened to be experiencing this issue too and the patch fixed it.
Committed to dev.