Even for those of us experienced aegir users, having site nodes appear when a platform is verified without any notice or ability to intercept, can be jarring at best and can break things at worst.

I suggest we make this behavior optional. I think it should be "opt-in". If you are planning on importing existing sites, then you know you want to do that, so you should go trigger the setting.

In a follow up issue, perhaps we can build a UI to show sites available to import and add a button to do so.

CommentFileSizeAuthor
#3 3020317-optional-site-import.patch3.04 KBJon Pugh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jon Pugh created an issue. See original summary.

  • Jon Pugh committed e35ce5c on 3020317-optional-site-import 
    Issue #3020317: Make automatic site import on platform verify optional
Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh at DevShop Support commented
FileSize
3020317-optional-site-import.patch3.04 KB

Patch and branch adds a setting: 'Automatically import sites when verifying platforms'

For now this defaults the setting to TRUE which is current behavior.

Let's get this committed first then we can debate the default behavior.

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh at DevShop Support commented
Status: Active » Needs review
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Consensus Enterprises, Colan Schwartz Consulting commented
Status: Needs review » Reviewed & tested by the community

I didn't even know that this happened automatically. Traditionally, I would create the platform, create the site, and then move site assets into place and then import the DB.

What happens when you visit a site that's auto-created? Does it just take you to the standard Drupal site-install form, pick your language, etc.?

In any case, making this configurable is a good idea. Besides being able to turn it off, it also makes the feature visible.

I like that's it's left enabled by default, as this is how it's been working until now.

  • Jon Pugh committed e35ce5c on 7.x-3.x 
    Issue #3020317: Make automatic site import on platform verify optional
helmo’s picture

helmo CreditAttribution: helmo as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Consensus Enterprises, Colan Schwartz Consulting commented

Anyone?

What happens when you visit a site that's auto-created? Does it just take you to the standard Drupal site-install form, pick your language, etc.?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh at DevShop Support commented

The site node is what is "auto-created" via a drush @hostmaster hosting-import call.

Provision assumes if the sites/domain.com folder exists the site is already installed there and just uses the existing settings.php, I think. I believe the hosting-import tries to determine the sql info from the existing settings.php file but I'd have to inspect the command to be sure.