Every time I login using my GA code, I need to first put in the password. Then, the gacode field (that's the name of the field in the form) shows up, but I first have to click on it before I can type. This is very annoying, as it would be faster to just start typing right away after hitting the return key after putting in my password.

I wrote a patch, adding the autofocus attribute to the element, so it will get focus after appearing.

I would love it it this would make it officially into the module.

CommentFileSizeAuthor
#4 3001474-04.patch731 bytesjhedstrom
#2 ga_login_3001474.patch567 bytescolorfulCoder
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Emmezali created an issue. See original summary.

colorfulCoder’s picture

colorfulCoder CreditAttribution: colorfulCoder commented
FileSize
ga_login_3001474.patch567 bytes
colorfulCoder’s picture

colorfulCoder CreditAttribution: colorfulCoder commented
Issue summary: View changes
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Version: 7.x-1.7 » 8.x-1.x-dev
Status: Active » Needs review
FileSize
3001474-04.patch731 bytes

Here's a patch for the D8 version too.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Issue tags: +ux

Since this is run on drupal.org, this would also benefit all the users there who log in with TFA :)

Status: Needs review » Needs work

The last submitted patch, 4: 3001474-04.patch, failed testing. View results

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Needs work » Needs review

Test failed because the testbot tried to apply the 8.x patch to 7.x.

The last submitted patch, 2: ga_login_3001474.patch, failed testing. View results

  • nerdstein committed a3a7122 on 8.x-1.x authored by jhedstrom 
    Issue #3001474 by Emmezali, jhedstrom, nerdstein: Cursor focus not on...
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and at Hook 42 commented
Status: Needs review » Fixed

This is ready for the next release. Again, thank you both

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colorfulCoder’s picture

colorfulCoder CreditAttribution: colorfulCoder commented

Thank you for testing jhedstrom!
And thanks for including this in the next release so soon nerdstein!

This is the first issue I have every worked on to actually make it to a codebase! :D:D This makes me so happy!

colorfulCoder’s picture

colorfulCoder CreditAttribution: colorfulCoder as a volunteer commented
Version: 8.x-1.x-dev » 7.x-1.x-dev

Reopening this issue and moving the version back to 7.x to take into account the original goal of this issue.
Thanks to @jhedstrom for adding the D8 patch.
Will reroll a patch for 7.x later.