Problem/Motivation

While running an accessibility audit on pages with "dropdown" facets, the tool reports that the select boxes / form elements are missing their labels.

Proposed resolution

Add a label for each selectbox

Remaining tasks

  • print label in twig
  • hide label in css
  • set aria-labelledby attribute in js that generates dropdown

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Original report by [mikemadison]

(Text of the original report, for legacy issues whose initial post was not the issue summary. Use rarely.)

CommentFileSizeAuthor
#3 Facet Selectbox Accessibility - 2992379 - 3.patch2.29 KBmikemadison

Comments

mikemadison created an issue. See original summary.

mikemadison’s picture

mikemadison commented
Issue summary: View changes
mikemadison’s picture

mikemadison commented
StatusFileSize
new Facet Selectbox Accessibility - 2992379 - 3.patch2.29 KB
mikemadison’s picture

mikemadison commented
Status: Active » Needs review
mgifford’s picture

mgifford
he/him
Primary language English
commented

This looks like a good change by doing a quick review of the code. Thanks for submitting the patch.

Would be great to have someone review it.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Version: 8.x-1.1 » 8.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

From a quick review of the code, this does look like an improvement.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

  • borisson_ committed 3560dfb on 8.x-1.x authored by mikemadison 
    Issue #2992379 by mikemadison, mgifford, borisson_: Accessibility Issues...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

omnia.ibrahim’s picture

omnia.ibrahim commented

There is an issue, if the search result is empty and there is no dropdown fields, the labels are still there