Problem/Motivation

Just came across following issue when installing jsonapi 1.17 & jsonapi_extras 2.1

  • jsonapi requires "justinrainbow/json-schema": "^4.1"
  • jsonapi_extra requires "e0ipso/shaper": "^1" which requires "justinrainbow/json-schema": "^5.2"

This seems to lead to a dead-lock.

Proposed resolution

Can we use "justinrainbow/json-schema": "^5.2" for jsonapi too?
Checking https://github.com/justinrainbow/json-schema I can't really tell if there are any breaking changes between 4.x / 5.x.

Potential patch: https://github.com/drupalprojects/jsonapi/pull/1

Remaining tasks

Figure out if it's save to upgrade dependency.
Change composer.json
Be happy.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2973151--composer-sadness--4.patch390 bytese0ipso

Comments

das-peter created an issue. See original summary.

das-peter’s picture

das-peter commented
Issue summary: View changes

Created https://github.com/drupalprojects/jsonapi/pull/1 - needed a fork for proper testing / using as you can't patch composer.json on the fly.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » e0ipso

Thanks for reporting this!

Please post a patch, not a GitHub pull request. DrupalCI will tell whether this is an easy update or not.

Also, assigning to @e0ipso, because he understandably never likes jsonapi_extras to need to be kept in sync with jsonapi, but now apparently he did the opposite there? :P

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2973151--composer-sadness--4.patch390 bytes
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review

  • e0ipso committed 205157e on 8.x-1.x authored by das-peter 
    Issue #2973151 by e0ipso, das-peter, Wim Leers: Composer dependency...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Thanks everyone!

das-peter’s picture

das-peter commented
Assigned: e0ipso » Unassigned

Sorry, I forgot to attach the patch. Wanted to get it a test run first do see if I find any obvious issues. But then I got carried away with jsonapi / webform rest and the silly elements attribute.
And you folks are simply to responsive! ;) Thanks for fixing that in no-time!!

  • Wim Leers committed 20c2352 on 8.x-2.x authored by das-peter 
    Issue #2973151 by e0ipso, das-peter, Wim Leers: Composer dependency...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This was only pushed to 1.x, also pushed to 2.x now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.