Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Just came across following issue when installing jsonapi 1.17 & jsonapi_extras 2.1
- jsonapi requires "justinrainbow/json-schema": "^4.1"
- jsonapi_extra requires "e0ipso/shaper": "^1" which requires "justinrainbow/json-schema": "^5.2"
This seems to lead to a dead-lock.
Proposed resolution
Can we use "justinrainbow/json-schema": "^5.2" for jsonapi too?
Checking https://github.com/justinrainbow/json-schema I can't really tell if there are any breaking changes between 4.x / 5.x.
Potential patch: https://github.com/drupalprojects/jsonapi/pull/1
Remaining tasks
Figure out if it's save to upgrade dependency.
Change composer.json
Be happy.
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2973151--composer-sadness--4.patch | 390 bytes | e0ipso |
| |||
Comments
Comment #2
das-peter CreditAttribution: das-peter at Cando commentedCreated https://github.com/drupalprojects/jsonapi/pull/1 - needed a fork for proper testing / using as you can't patch composer.json on the fly.
Comment #3
Wim LeersThanks for reporting this!
Please post a patch, not a GitHub pull request. DrupalCI will tell whether this is an easy update or not.
Also, assigning to @e0ipso, because he understandably never likes
jsonapi_extrasto need to be kept in sync withjsonapi, but now apparently he did the opposite there? :PComment #4
e0ipsoComment #5
e0ipsoComment #7
e0ipsoThanks everyone!
Comment #8
das-peter CreditAttribution: das-peter at Cando commentedSorry, I forgot to attach the patch. Wanted to get it a test run first do see if I find any obvious issues. But then I got carried away with jsonapi / webform rest and the silly elements attribute.
And you folks are simply to responsive! ;) Thanks for fixing that in no-time!!
Comment #10
Wim LeersThis was only pushed to 1.x, also pushed to 2.x now.