Comments

oknate created an issue. See original summary.

oknate’s picture

cilefen’s picture

Status: Active » Needs review
borisson_’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

This issue needs tests.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dbielke1986’s picture

At the moment this patch is not supporting multilingual sites. I would add the possibility to get the lable in the current language...

+    $langcode = \Drupal::service('language_manager')->getCurrentLanguage()->getId();
+    if ($entity->hasTranslation($langcode)) {
+      $trans = $entity->getTranslation($langcode);
+      $default_text = $trans->label();
+    } else{
      $default_text = $entity->label();
+    }
    // Allow other modules to alter default text.
    \Drupal::moduleHandler()

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

veerasekar.r89’s picture

After analyzing, Below $attributes variables are always coming null even if using node url. $attributes["data-entity-uuid"] and $attributes["data-entity-type"] .

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

kasey_mk’s picture

Patch in #2 works for us (we don't have a multilingual site). It boggles my mind that this behavior still isn't part of core.

dbielke1986’s picture

Attached is the patch for #7 (multilingual sites).

dbielke1986’s picture

dbielke1986’s picture

Status: Needs work » Needs review

Don´t know why the test fails. Patch is working fine for me.

BR,
Daniel

dbielke1986’s picture

dbielke1986’s picture

last try...

dbielke1986’s picture

StatusFileSize
new3.17 KB

again

ranjith_kumar_k_u’s picture

StatusFileSize
new3.19 KB

Updated

borisson_’s picture

Status: Needs review » Needs work

cspell fails for this, let's fix that as well. Steps to reproduce this locally are in https://www.drupal.org/pift-ci-job/1991994

abhisekmazumdar’s picture

Status: Needs work » Needs review
StatusFileSize
new4.35 KB
new2.12 KB

Tried fixing the failed test case.
From core version 8.4.0 Drupal uses ES6 for JavaScript development.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dbielke1986’s picture

Would be nice if we can have this feature with the next release :-/
One of the last core modifications we have at the moment...

dbielke1986’s picture

Status: Needs review » Reviewed & tested by the community

Patch 2961554-19.patch is working fine on Drupal 9.2.2

jonathanshaw’s picture

Status: Reviewed & tested by the community » Needs work

Tests failing

gauravvvv’s picture

Status: Needs work » Needs review
StatusFileSize
new4.35 KB
new1.81 KB

Re-rolled patch #21, Fixed cs errors. Please review.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

klidifia’s picture

#26 Suddenly stopped working I guess with some Core updates - will try to figure out why

klidifia’s picture

Because CKEditor is moved to Contrib now I believe.

Have patched the same JS files here in new issue: https://www.drupal.org/project/ckeditor/issues/3340081

dbielke1986’s picture

StatusFileSize
new4.4 KB

Re-roll for Drupal 9.5.*

gauravvvv’s picture

Status: Needs work » Needs review
StatusFileSize
new4.39 KB

Re-rolled patch for 9.5.x

dbielke1986’s picture

StatusFileSize
new4.43 KB

Re-rolled patch for 9.5.x, based on #34 targeting the error "Missing parameter comment"

dbielke1986’s picture

StatusFileSize
new4.56 KB

Re-rolled patch for 9.5.x, based on #35 targeting the error "fatal: corrupt patch at line 122"

dbielke1986’s picture

StatusFileSize
new4.56 KB

Re-rolled patch for 9.5.x, based on #36 targeting the error "fatal: corrupt patch at line 121"

dbielke1986’s picture

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new85 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

rishabh vishwakarma’s picture

Status: Needs work » Needs review
StatusFileSize
new4.5 KB
new562 bytes

Fixed CCF from #34

jonathanshaw’s picture

Priority: Minor » Normal
Status: Needs review » Needs work

The fix looks on the right lines, but tests needed.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

klidifia’s picture

With D10/CKEditor5: I needed the existing functionality that this was achieving, but I decided to use Linkit module as it seemed to be the easiest to use to do this: #3388565: Populate displayedText with entity title when left blank

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.