Needs work
Project:
Drupal core
Version:
main
Component:
editor.module
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
16 Apr 2018 at 21:39 UTC
Updated:
21 May 2024 at 02:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
oknateComment #3
cilefen commentedComment #4
borisson_This issue needs tests.
Comment #7
dbielke1986 commentedAt the moment this patch is not supporting multilingual sites. I would add the possibility to get the lable in the current language...
Comment #9
veerasekar.r89 commentedAfter analyzing, Below $attributes variables are always coming null even if using node url.
$attributes["data-entity-uuid"]and$attributes["data-entity-type"].Comment #12
kasey_mk commentedPatch in #2 works for us (we don't have a multilingual site). It boggles my mind that this behavior still isn't part of core.
Comment #13
dbielke1986 commentedAttached is the patch for #7 (multilingual sites).
Comment #14
dbielke1986 commentedComment #15
dbielke1986 commentedDon´t know why the test fails. Patch is working fine for me.
BR,
Daniel
Comment #16
dbielke1986 commentedComment #17
dbielke1986 commentedlast try...
Comment #18
dbielke1986 commentedagain
Comment #19
ranjith_kumar_k_u commentedUpdated
Comment #20
borisson_cspell fails for this, let's fix that as well. Steps to reproduce this locally are in https://www.drupal.org/pift-ci-job/1991994
Comment #21
abhisekmazumdarTried fixing the failed test case.
From core version 8.4.0 Drupal uses ES6 for JavaScript development.
Comment #23
dbielke1986 commentedWould be nice if we can have this feature with the next release :-/
One of the last core modifications we have at the moment...
Comment #24
dbielke1986 commentedPatch 2961554-19.patch is working fine on Drupal 9.2.2
Comment #25
jonathanshawTests failing
Comment #26
gauravvvv commentedRe-rolled patch #21, Fixed cs errors. Please review.
Comment #30
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #31
klidifia commented#26 Suddenly stopped working I guess with some Core updates - will try to figure out why
Comment #32
klidifia commentedBecause CKEditor is moved to Contrib now I believe.
Have patched the same JS files here in new issue: https://www.drupal.org/project/ckeditor/issues/3340081
Comment #33
dbielke1986 commentedRe-roll for Drupal 9.5.*
Comment #34
gauravvvv commentedRe-rolled patch for 9.5.x
Comment #35
dbielke1986 commentedRe-rolled patch for 9.5.x, based on #34 targeting the error "Missing parameter comment"
Comment #36
dbielke1986 commentedRe-rolled patch for 9.5.x, based on #35 targeting the error "fatal: corrupt patch at line 122"
Comment #37
dbielke1986 commentedRe-rolled patch for 9.5.x, based on #36 targeting the error "fatal: corrupt patch at line 121"
Comment #38
dbielke1986 commentedComment #39
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #40
rishabh vishwakarma commentedFixed CCF from #34
Comment #41
jonathanshawThe fix looks on the right lines, but tests needed.
Comment #43
klidifia commentedWith D10/CKEditor5: I needed the existing functionality that this was achieving, but I decided to use Linkit module as it seemed to be the easiest to use to do this: #3388565: Populate displayedText with entity title when left blank