Rename the label of AddressField::ORGANIZATION from "Company" to "Organization"

Is "Company" the only field that should be re-nameable?

You can use User interface translation. I use it to change the label Company to Facility Name.

I've also explored the translation option. It might be too much overhead in many cases. You can just add the following to settings.php.

<?php
$settings['locale_custom_strings_en']['Address label'] = [
  'Company'      => 'Organization',
];
?>

Related:
https://www.drupal.org/project/address/issues/2851549

Since there is a pretty simple workaround, I am wondering if there is any point to working on this issue. I personally think it would be better have configurable labels but the maintainers may not.

I would not support configurable labels. Would rather document #6 in a prominent place.

That said, the underlying field is actually called "organization". It's labeled "Company" because that's what Addressfield did in D7, Google's original widget uses "Organization". So it's worth discussing whether "Organization" is actually a better/more common default.

+1 for 'Organization' over 'Company'. Company is just too restrictive.

It would be nice to be able to re-label these fields

Instead, I just hide them and open new text fields. Why can't we re-label through the form-UI or on the field edit screen?

configurable labels seems like the way to go to me.

+1 for 'Organization' over 'Company'.
Here is the patch for the dev version.

Hi,
I have tested your above #10 patch .It is working fine. Attaching screenshot for reference.

Another +1 for 'Organization' over 'Company'.

The patch and discussion has moved on from the originally proposed title. The new scope of this is simply renaming the (hard-coded) label on that field.

+1 to that. ;) It seems pretty weird to me that all the internal code refers to AddressField::ORGANIZATION but the human-readable label is "Company".

I'll give @bojanz a little while to reply if he's got any lingering concerns. If not, I'll commit this.

Thanks,
-Derek

Let's proceed with the rename and see who complains :)

Do we care about translations for this? Does this need to happen in another branch? :( Just flag it in the release notes for 8.x-1.8?

How do you decide whether to use "organization" or "organisation"?

Drupal uses US English as the default, so it's always a "z".

@bojanz: So, can I go ahead and commit this to 8.x-1.x and we flag it in the 8.x-1.8 release notes as a string change for translators?

Please advise.

Thanks!
-Derek

p.s. If we fix #2828128: Stop performing subdivision-level postal code validation as planned, that'd be another string change for 8.x-1.8...

I initally tried using the String Overrides module for this and that didn't work. +1 for committing this. This sort of thing ought to be configurable.

I no longer support committing this as-is.

I've reviewed the code that currently uses this getter. Every payment gateway we integrate with uses "company". I've also looked at a number of eCommerce solutions (Magento, WooCommerce, Shopify, Sylius etc) and they too use "company".

This tells us two things:
1) It was not unreasonable to make "Company" the default label.
2) There is an almost certain chance that if we commit this change in a stable release, a number of people will show up to complain. Possibly much larger than the number of people advocating for this change.

I think that we need official docs on how to replace the "Company" string with "Organization", and then to consider punting this to 2.x.

Companies are organizations. Not all organizations are companies, e.g. non-profits. Just sayin'.

+100 to #23.

I don't personally care about payment gateways at all, but I know that puts me in the minority of Address module maintainers. ;)

Re:

I think that we need official docs on how to replace the "Company" string with "Organization", and then to consider punting this to 2.x.

I don't know how to write those docs, since I don't know how to change this without patching things. @bojanz: can you write them?

Thanks,
-Derek

There was never a dilemma about #23. I agree with that logic too. This is about preserving backwards compatibility and expectations for current users (== almost 50 thousand sites).

The Commerce docs have an example for replacing the "Company" label with "Organization":
https://docs.drupalcommerce.org/commerce2/developer-guide/customers/addr...
I think that we need to copy all Address-specific docs from the Commerce documentation to drupal.org.

I have a request for one of our clients to change the 'Postal code' label to 'Post code' saying Postal code is an American thing. We are based in Australia.
Since the labels are not configurable from the back-end, is there any proper way to do so through the hooks and without translations definition?
I tried the method mentioned at https://docs.drupalcommerce.org/commerce2/developer-guide/customers/addr..., however in my case, the $form_id is not same on different pages for a same form. It is like

'webform_submission_get_in_touch_node_36877_add_form' 

whereas I expect it to be

'webform_submission_get_in_touch_add_form'

(it is right on some pages though_.
So the above link does not help in my case.
Any workaround would be appreciated.

Thank you

We now have a 2.x branch, so we can proceed with this change there.

Committed. Now let's see how many people complain :)