Closed (won't fix)
Project:
Video Embed Field
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2018 at 15:14 UTC
Updated:
14 Aug 2020 at 01:46 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
eigentor commentedHere is a patch that loads a thumbnail of the size 1280px.
In my experience it loads the next smaller one if no thumbnail of that size is available. So it would gracefully degrade to 640px with in that case.
Comment #3
nkoporecTested the patch and it works as expected, the images are bigger now.Marking as Need review so other people can test it too.
Comment #4
marcel hornburg commentedWorks also fine with Video Embed Field 8.x-2.1
Comment #5
lindsay.wils commentedHave just successfully applied this patch. Drupal 8.7.2, Video Embed Field 8.x-1.6.
This patch really needs to be applied to the module, over 1 year after the original post.
I get media module is now in core, but a lot of sites still use this module and this is a pretty big flaw.
Comment #6
ambient.impactRerolled #2 against 8.x-2.x-dev.
Comment #7
ambient.impactOops, patch failing because the URL in 8.x-2.x branch is "http" and not "https" for some reason. 😕
Comment #8
hockey2112 commented#7 worked great, thanks!
Comment #9
sam152 commentedWith the advent of Media in core, the Video Embed Field module has moved to being minimally maintained. Only issues which assist in the migration to Media in core will be committed. To read more about this decision, please see: #3089599: Maintenance status for Video Embed Field now that media is in core.