While debugging some pretty paths issue, I noticed the url_processor (being a pre query processor) is initialized twice.
First in Facet.php (loadProcessors), later in the DefaultFacetManager.php.

We can probably skip creating the second instance in the facet manager and using loadProcessors on the given Facet instead.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

Status: Active » Needs review
FileSize
1.16 KB

Did not ran test locally, lets see what this does.

borisson_’s picture

Issue tags: +Performance

Awesome, this is another performance improvement. Tagging as such to make sure we can document those in the next release. I'd like to do some tests to test the actual improvement, so we have numbers. Just testing this with ab should be sufficient.

  • borisson_ committed f966284 on 8.x-1.x authored by StryKaizer
    Issue #2933799 by StryKaizer: PreQueryProcessers are initialized twice
    
borisson_’s picture

Status: Needs review » Fixed

I tested this with ab, and there is a significant improvement. Great work @StryKaizer!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.