Apply password policies to password elements on custom forms

D8 ++

Re-patching against latest dev. Nothing changed other than some indexes.

I'm having trouble with this patch but need to pivot to something else. It looks like the array_combine around like 230 in function _password_policy_constraints_validate isn't producing the proper results.

I think that line should be replaced with:

    foreach ($roles as $role => $value) {
      if ($value) {
        $roles[$role] = $role;
      }
    }

I'm also seeing "The password does not satisfy the password policies." on every step of my custom, multi-step form, so it's possible this still needs to be adapted to account for multi-step forms.

Patch with interdiff described above.

Hello, thanks for the patches, all. I took a quick look and, unless I'm mistaken, the latest (#9) has several changes unrelated to this issue. For instance, type hinting is added to unrelated functions. Could the unrelated changes please be removed so we can review the code relevant to this issue?

@AohRveTPV thanks for taking a look. I did my best to recreate the patch from #6 as closely as possible with the latest dev, but I'm happy to remove things if you might clarify what seems extraneous?

The type hinting I see is in function _password_policy_constraints_table and function _password_policy_check_constraints and I agree that seems like it could be extraneous (although open to argument from @paddy.doyle if they're still listening). Are there other changes you'd like to see removed?

Thanks for clarifying.

Initial requested changes.

Hello froboy,

I tried this against pretty much all d8 versions but it won't apply .. I also tried the previous patches but not luck either.

Regards
Essam

@3ssom: This patch seems to apply on '8.x-3.0-alpha5' for me.

But from there, I am stuck as well.
How do I trigger a password policy for a custom form (or in my case: Password Reset Landing Page)?

Thanks in advance.

Hello

I just installed new Drupal install with Version: 8.x-3.0-alpha5 of this module to test it applies but still the same:

error: patch failed: password_policy.module:14
error: password_policy.module: patch does not apply

I'm not sure how did you apply it!

So me not getting this to work which I by the way need in my custom registrations form makes difficult to answer your question because I don't know how it should work! it might get attached to any ['account']['pass'] if it's == 'password_confirm'.

If you read the code that what you will see but unfortunately I can't see that .. if you could please make sure how did you apply the patch so we can help each other on this! I'm stuck also here.

Regards

My apologies, I made a mistake.
It should work on 8.x-3.x-dev using cweagans/composer-patches (well, it says it applied succesfully).

The patch doesn't apply anymore (probably because of #2971079: Can't edit user profile because password policy validates even when password unchanged).

Re-roll patch created, Please review.

Please ignore previous patch(#19).

The patch does apply, but I see no changes.

Thanks to everyone for your work on this issue.

As the 8.x is no longer supported, I'm postponing this issue for now and need feedback as to whether or not this issue is relevant to 4.0.x.

If it is, please reopen and change the version, make sure the issue summary is clear and complete, including concrete steps to reproduce, and reroll the patch. If it's not, please close.

If there is no response to this in a month addressing the above, it can be closed.

Note that I just closed #2562481: Apply password policies to account password elements on custom forms as fixed, which is the Drupal 7 version. Refer to that code if needed.