Note leftover media_entity in http://cgit.drupalcode.org/video_embed_field/tree/video_embed_field.info...

test_dependencies:
  - media_entity:media_entity
  - media_entity_embeddable_video:media_entity_embeddable_video
CommentFileSizeAuthor
#3 2922476-3-change_test_dependencies.patch381 bytesroberto_araya
#2 2922476-2-change_test_dependencies.patch365 byteszeip

Comments

axel.rutz created an issue. See original summary.

zeip’s picture

zeip commented
Status: Active » Needs review
Parent issue: » #2902316: Create a port of video_embed_media compatible with media in core API
StatusFileSize
new 2922476-2-change_test_dependencies.patch365 bytes

I think this should do it.

roberto_araya’s picture

roberto_araya commented
StatusFileSize
new 2922476-3-change_test_dependencies.patch381 bytes

Update patch, change media by drupal:media (>= 8.4)

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Reviewed & tested by the community

Patch #3 is working.
the other way drupal composer packaging will bring media_entity into the modules/contrib code.

sam152’s picture

sam152 commented
Status: Reviewed & tested by the community » Needs review

These are test dependencies only, do we really need to specify > 8.4? 8.5 is the only supported version of core.

rajab natshah’s picture

rajab natshah
he/him
commented

Hi Sam,

You are right I have double tested the scenarios again and seems its working now

Not sure about specify > 8.4? 8.5

The issue which we had In the last 2 weeks was as in the following:

mkdir /var/www/html/test
cd /var/www/html/test
composer create-project drupal/drupal:8.5.1 drupal851test -vvv
cd /var/www/html/test/drupal851test
composer require drupal/video_embed_field:2.0 -vvv

It was bringing the media_entity module, but not now.

It is acting as we do for
drush dl video_embed_field-8.x-2.0 -vvv
it will read the .info.yml file and bring dependences!!! 

mkdir /var/www/html/test
cd /var/www/html/test
composer create-project drupal-composer/drupal-project:8.x-dev drupal851test2 --stability dev --no-interaction -vvv
cd /var/www/html/test/drupal851test2
composer require drupal/video_embed_field:2.0 -vvv

Now this behavior of the Drupal composer packaging has changed. or could it be a composer.json settings or extra config which do the behavior

You are right No need for the patch at this time.

sam152’s picture

sam152 commented

Hm previously the 1.x branch was the recommended and supported branch. I've recently created a stable release of 2.0 and made that the recommended branch. Was it possible the 1.x version was being downloaded before?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@Sam152, because there is a composer.json in the repo, the version is reporting as 1.x, did you want to keep that and update it or let it get created automagically?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Created a patch, we can discuss there: #2994151: Version conflict in composer.json

sam152’s picture

sam152 commented

Ah, we should delete that.

sylvainm’s picture

sylvainm commented
Status: Needs review » Reviewed & tested by the community

I think this should be committed, as the 2.x version uses the core media module and on more the media_entity contrib one.

Currently, it makes composer download the media_entity module that we don't use with this version

alison’s picture

alison
she/her
commented

Applies cleanly for me! Anything still needed before committing to module, or is it more of a time thing? Thanks!

chris matthews’s picture

chris matthews commented
Parent issue: #2902316: Create a port of video_embed_media compatible with media in core API » #3095176: Plan for Video Embed Field 8.x-2.5 release
Related issues: +#2902316: Create a port of video_embed_media compatible with media in core API
mpp’s picture

mpp commented

RTBC++

This seems to block other issues as test are now failing: Eg https://www.drupal.org/project/video_embed_field/issues/2922476

jkswoods’s picture

jkswoods commented
Priority: Normal » Major

RTBC. To reiterate what @mpp has said, this is blocking other issues.