The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.If a customer overpays, show how much change they should receive. It should just show as a highlighted line item, see 7.x version for example if needed.
*Note, this issue depends on #2907670: POS Payment Page which should be merged in shortly
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 2916643-16.patch | 8.3 KB | sorabh.v6 |
| #16 | 2916643-16-interdiff.txt | 581 bytes | sorabh.v6 |
| #14 | 2916643-13.patch | 8.25 KB | sorabh.v6 |
| #14 | 2916643-13-interdiff.txt | 6.82 KB | sorabh.v6 |
| #10 | 2916643-10.patch | 5.07 KB | rakesh.gectcr |
Comments
Comment #2
smccabe commentedAlso will have to update the ability to add payment over the total, right now it will not allow any overpay.
Comment #3
sorabh.v6Working on it.
Comment #4
sorabh.v6I am trying to add change row to the order payment container. But I think some code from https://www.drupal.org/project/commerce_pos/issues/2907670 needs to be updated. For example when I enter 15 in keypad and order total is 12 then row with payment option and payment amount shows 12 but it should be 15 instead. Similarly, Total paid is the order total and it should be the amount user paid, that is, 15.
Attaching image for reference.
@smccabe Please share your opinion on this.
Thanks
Comment #5
sorabh.v6Patch posted for showing the 'change' row in the order total container. Please review.
Comment #6
jnrfred commentedPatch worked for me.
Comment #8
smccabe commentedPatch is causing 2 failing tests, so that needs to be reviewed and either tests updated or code fixed.
Comment #9
deepakaryan1988Comment #10
rakesh.gectcrJust checking why the testing is getting failed. In my local instance, it is working fine.
Comment #12
sorabh.v6@deepakaryan1988 I did not saw any progress posted on this from your end so I decided to work on this. I will be posting patch shortly. Also, I noticed today that the patch I posted in #5 doesn't cover a case and due to that, the test is failing. I will also update the test file with the test for the updated code for showing change.
Comment #13
deepakaryan1988Thanks @sorabh.v6
Please proceed!
Comment #14
sorabh.v6Hi Guys, I have corrected the error I made in #5 and updated POSFormTest with the code for testing 'Change'. Uploading patch and interdiff.
Comment #16
sorabh.v6Update code for test.
Comment #17
sorabh.v6Comment #18
subhojit777Comment #19
deepakaryan1988@subhojit777
I think, it's working for me atleast.
Comment #20
subhojit777Unassigning. Some important stuff has come up.
RTBC-ing on behalf of Deepak.
Comment #22
smccabe commentedAs per recommendation by Matt F, did a slight change to always show change and to pay labels, just at 0 if nothing is needed.
Otherwise good, committed!