Retrieve title and description for videos

Here is the patch, but it's not for the 1.x-dev but the 2.x-dev (with Media from Core 8.4^).
And it's only for the title.
Hoping you will find it useful.

Looks good for me. Just two small points:

1. +++ b/modules/video_embed_media/src/Plugin/media/Source/VideoEmbedField.php
   @@ -134,6 +134,14 @@ class VideoEmbedField extends MediaSourceBase {
   +          if (method_exists($provider, 'getName')) {
   +            return $provider->getName();
   +          }
   

   $provider must implement \Drupal\video_embed_field\ProviderPluginInterface and it is a guarantee for the existance of getName(). There is no need for this check.

2. +++ b/modules/video_embed_media/src/Plugin/media/Source/VideoEmbedField.php
   @@ -149,6 +157,7 @@ class VideoEmbedField extends MediaSourceBase {
   +      'video_title' => $this->t('Gets the video title from source'),
   

   I'd prefer no verb. "Video title from source" would be better (like with "source_name").

Okay, it's fix.
Here is the new patch.

Tested the latest patch, and it's working as expected.

Tested the latest patch and it's working as expected.

Tested the patch and it's working as expected.

Okay, I see the problem, and two differents solutions for it.

In Drupal\Tests\video_embed_media\Kernel\DefaultNameTest.php ,

      'YouTube' => [
        'https://www.youtube.com/watch?v=gnERPdAiuSo',
        'YouTube Video (gnERPdAiuSo)',
      ],

We change it for "DrupalCon Austin 2014: Keynote: Dries Buytaert", adopting the same approach as Vimeo provider.

Or we don't implement a getName() method in Youtube Provider, but a different one (something like getTitle), to not get mixed up.
But this need to change the Vimeo provider to add another method, which will be a doublon (or re-use) the getName method.

I go more for the second option, and implement a getDefaultName() and a getName() methods in the ProviderPluginBase.
I also modified a little the tests to adapt them.

Another idea to get Description on Youtube video :
https://www.googleapis.com/youtube/v3

Example :
https://www.googleapis.com/youtube/v3/videos?id={ID_VIDEO}&key={YOUR_API_KEY}&part=snippet,contentDetails,statistics,status

Updated the patch to also support retrieving the description.

Right now is it only retrieving from Vimeo due to Youtube not including description in their oembed endpoint. It could be retrieved using their API, as mentioned by mgerbault, but that will require another form / UI where the Youtube API key can be configured.

Added a related issue retrieving duration, which is also not possible in the Youtube oembed endpoint. We might want to create a separate follow up issue adding the Youtube API support and configuration.

Patch from #16 is working fine, changing status to RTBC.

Follow-up #3001487: Using YouTube API for metadata for API use.

I would like to ask where is this file located? I downloaded the module and there is not such a file and subfolder.
Thanks

Same here. Where are these directories? Is this patch no longer applicable top the current dev version of this module?

@m_dimitris @hockey2112 The patch is working for the 8.x-2.x branch

I've create a new patch that also fix this issue "Provide title attribute in iframe tag for accessibility" by adding a new title attribute to the iframe

@gurvan, I have successfully applied the patch... how can I display the video title via the field display config, or via a View? I'd like to display the thumbnail (clickable with Colorbox), and the video title underneath the thumbnail. My provider is Vimeo.

Change the test case because the video used in test has been modified.

With the advent of Media in core, the Video Embed Field module has moved to being minimally maintained. Only issues which assist in the migration to Media in core will be committed. To read more about this decision, please see: #3089599: Maintenance status for Video Embed Field now that media is in core.

The latest releases break the patch we were using from this issue. It was closed because the module was no longer being updated with new features, however that doesn't seem to be the case anymore. Can we re-open this issue then? Is this still relevant? I have not had time to investigate how critical the patch is to the codebase I'm supporting, and the use of the patch predates my time. Apologies if I'm just adding more noise and if/when I do get time to investigate more I'll update.

I attempted to reroll the 2913925-28.patch in #28 for Video Embed Field 3.0.0. In this, some of the changes were already present in 3.0.0 and I didn't roll over any getDefaultName stuff.

I have NOT tested this AT ALL and so no guarantees it works and doesn't break stuff. I see that "patch files are no longer recommended, use merge requests instead" but I haven't made the jump to that yet and I figure others may not have either. I will look at that next; time allowing.