Add a setting to enable/disable inline editing for existing entities

Rerolled the patch because of warning when you apply the patch, also setting Needs review so other people can test it.

Patch #5 applies nicely. I have quickly manually tested it and it works. Changing status to RTbC.

Rerolled pattch #5

Hello,
The #7 patch applied correctly and working as expected.
+1 for RTBC.
Tested on dev branch.
But it has conflicts with https://www.drupal.org/project/inline_entity_form/issues/2979075 so I applied all changes manually, but both patches work well together.
Also there are extra spaces in line
+ if (empty($entity_id) || ( $this->getSetting('allow_edit') && $entity->access('update') ) ) {
near brackets it should be removed.
Patch should be rerolled after https://www.drupal.org/project/inline_entity_form/issues/2979075 is commited.

Per @joachim's comment in #2576445: Inline Entity Form stable release plan #20, this RTBC issue is blocked until #2974544: Convert tests from Simpletest to FunctionalJavascript is fixed.

#2974544: Convert tests from Simpletest to FunctionalJavascript is in now. I guess this should have a test.

NW for tests.

Reroll the patch

Wonderful Idea! #14 applied in core 9.0.3

Let's see if I can get up with some tests for this one.

Meh, got an unexpected other assignment, going to have to postpone my work on this one.

I applied #14 to D9 and then extended it to include the restriction on deletion functionality again that was available in the original patch as we needed that functionality for our site

+1 for this on Drupal 10

Oh, now that I check, changing the permission to edit the entity already covers my requirement (with inline_entity_form 8.x-1.0-rc14 and Drupal 10)

I suggest closing this issue as a "won't fix." This is a permission issue, not a reason to add more bloat to the field widget's settings. As noted in #20, Drupal Core includes granular permissions which may be configured to only allow access to edit or delete a user's own Media entities. In my opinion, this would need an explanation of how the permissions are insufficient enough to justify additional burden on maintainers and frankly every site builder who has to set up the widget.

Yeah, I can see the benefit of allowing users to be able to edit their own entities (via other UI paths) but *not* to do so via IEF. I'm +1 to having these be widget settings. But for this to not be a maintenance burden, this feature *definitely* needs solid test coverage before it can be considered. Also, it should target the forthcoming 3.1.x series, since 3.0.0 is deep into RCs and IMHO it's too late to be adding new features there...

Rerolled against rc19 and:

• Replaced empty($entity_id) calls (that don't work for entities with machine names) with $entity->isNew().
• On the widget configuration form, dynamically hide "Keep or delete unreferenced..." if the "Allow users to delete existing..." checkbox is unchecked.
• Don't display the "Keep or delete..." setting in the widget configuration summary if configured not to allow deleting existing entities.

Following up in this issue
After #3143422: Allow to hide the Edit button in Complex widget

Deleting existing entities can be in a new issue.
like #2833972: Widget setting to allow or disallow deleting entities from the system

Attached a static inline_entity_form--2024-12-27--2913571--mr-127.patch file, from the MR127 up to this point.
to be used with Composer Patches

I tried this out but the new setting was not saving on the display form. I made a small change to the MR. Here is a patch for composer.

Added allow_edit to schema yml